Re: [PATCH 3/4] drm/xe: Fix xe_lrc.h

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Mon, May 13, 2024 at 10:42:17AM +0200, Michal Wajdeczko wrote:
> Prefer forward declarations over #include xe_lrc_types.h

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_lrc.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_lrc.h b/drivers/gpu/drm/xe/xe_lrc.h
> index 06a95a598736..e0e841963c23 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.h
> +++ b/drivers/gpu/drm/xe/xe_lrc.h
> @@ -5,14 +5,17 @@
>  #ifndef _XE_LRC_H_
>  #define _XE_LRC_H_
>  
> -#include "xe_lrc_types.h"
> +#include <linux/types.h>
>  
>  struct drm_printer;
>  struct xe_bb;
>  struct xe_device;
>  struct xe_exec_queue;
>  enum xe_engine_class;
> +struct xe_gt;
>  struct xe_hw_engine;
> +struct xe_lrc;
> +struct xe_lrc_snapshot;
>  struct xe_vm;
>  
>  #define LRC_PPHWSP_SCRATCH_ADDR (0x34 * 4)
> -- 
> 2.43.0
>