From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6596C25B10 for ; Mon, 13 May 2024 14:31:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6Wi7-0006iu-0x; Mon, 13 May 2024 10:31:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Wi5-0006iN-4Q for qemu-devel@nongnu.org; Mon, 13 May 2024 10:31:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6Wi2-0002BF-Rh for qemu-devel@nongnu.org; Mon, 13 May 2024 10:31:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715610681; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4js0GywERsc8aXXdPlgEI13IPolZmURJ6aQxvtqNJcI=; b=h79pmvugO4zYwbjaVkJ8NhlcOPgvsU5kD+T6ywAqG41UAX84PgNMwP7WYSR1cfT214LNpt iLhZOAJDMS82fxs+MsZCntYFBABmkXuQb6ClyvFb8xV5Bx5b1j7OlYpwrbM5l6Fq22TBtc WHH3qCvzVHVMSk+85/NRtI8ohgPILWY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-591-zNrWLvSwOme_kfU-B66brQ-1; Mon, 13 May 2024 10:26:20 -0400 X-MC-Unique: zNrWLvSwOme_kfU-B66brQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1E2861818680; Mon, 13 May 2024 14:26:20 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 301E247B; Mon, 13 May 2024 14:26:19 +0000 (UTC) Date: Mon, 13 May 2024 15:26:17 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one) Message-ID: References: <20240513102252.48884-1-thuth@redhat.com> <20240513102252.48884-3-thuth@redhat.com> <41974e51-cee5-4a62-bcab-db9b78f76aee@redhat.com> <22d84c81-7c7b-4656-8606-cf919b26d0a1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <22d84c81-7c7b-4656-8606-cf919b26d0a1@redhat.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.974, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, May 13, 2024 at 04:22:00PM +0200, Thomas Huth wrote: > On 13/05/2024 14.11, Daniel P. Berrangé wrote: > > On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote: > > > On 13/05/2024 12.28, Daniel P. Berrangé wrote: > > > > A better way to handle this would be to define a separate project > > > > > > > > 'tests/lcitool/projects/qemu-win-installer.yml' > > > > > > > > With > > > > > > > > packages > > > > - g++ > > > > > > > > Then enable the extra project for win64 > > > > > > > > generate_dockerfile("fedora-win64-cross", "fedora-38", > > > > project='qemu,qemu-win-installer', > > > > cross="mingw64", > > > > trailer=cross_build("x86_64-w64-mingw32-", > > > > "x86_64-softmmu")) > > > > > > > > which should result in an identical container to what we have today > > > > for win64, while letting us slim the other containers. > > > > > > Ok, good idea! ... but then we need to teach lcitool about mingw-w64-tools > > > first, otherwise that vss code won't get built due to the missing "widl" > > > tool. > > > > Why is that a pre-requisite ? What i've suggested will result in a > > Dockerfile for win64 that is 100% identical to what we already have > > in git today. So surely that will already succeed to the same extent > > that CI succeeds today ? > > If you want to have the same result, we can also simply remove g++ > everywhere, also for the mingw cross containers, since the vss code is > currently not built at all due to the missing widl program. Oh, I'm getting mixed up between the qemu-setup.exe and the qga installer exe. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|