From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: <igt-dev@lists.freedesktop.org>,
Janga Rahul Kumar <janga.rahul.kumar@intel.com>,
Badal Nilawar <badal.nilawar@intel.com>
Subject: Re: [PATCH i-g-t 2/3] tests/intel/xe_pm: Move mocs documentation to the right place
Date: Mon, 13 May 2024 13:22:07 -0400 [thread overview]
Message-ID: <ZkJMPx7P6qZVEInt@intel.com> (raw)
In-Reply-To: <20240513162435.952578-2-lucas.demarchi@intel.com>
On Mon, May 13, 2024 at 09:24:33AM -0700, Lucas De Marchi wrote:
> {s_state}-mocs is not tested by test_exec(). Move it on top of the right
> function.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> tests/intel/xe_pm.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c
> index 1215b5c2a..584cb8548 100644
> --- a/tests/intel/xe_pm.c
> +++ b/tests/intel/xe_pm.c
> @@ -251,10 +251,6 @@ static void close_fw_handle(int sig)
> * Description: suspend/autoresume on %arg[1] state and exec after RPM
> * Functionality: pm - %arg[1]
> *
> - * SUBTEST: %s-mocs
> - * Description: test checks for mocs state before and after %arg[1] state
> - * Functionality: pm - %arg[1]
> - *
> * arg[1]:
> *
> * @s2idle: s2idle
> @@ -624,6 +620,17 @@ static void test_mmap(device_t device, uint32_t placement, uint32_t flags)
> * Functionality: mocs
> * Run type: FULL
> */
> +/**
> + * SUBTEST: %s-mocs
> + * Description: test checks for mocs state before and after %arg[1] state
> + * Functionality: pm - %arg[1]
> + *
> + * arg[1]:
> + *
> + * @s2idle: s2idle
> + * @s3: s3
> + * @s4: s4
> + */
> static void test_mocs_suspend_resume(device_t device, int s_state)
> {
> int gt;
> --
> 2.43.0
>
next prev parent reply other threads:[~2024-05-13 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 16:24 [PATCH i-g-t 1/3] tests/intel/xe_pm: Rename and clarify mocs_suspend_resume Lucas De Marchi
2024-05-13 16:24 ` [PATCH i-g-t 2/3] tests/intel/xe_pm: Move mocs documentation to the right place Lucas De Marchi
2024-05-13 16:44 ` Cavitt, Jonathan
2024-05-13 17:22 ` Rodrigo Vivi [this message]
2024-05-13 16:24 ` [PATCH i-g-t 3/3] tests/intel/xe_pm: Fix S4 testing Lucas De Marchi
2024-05-13 16:48 ` Cavitt, Jonathan
2024-05-13 17:22 ` Rodrigo Vivi
2024-05-13 16:48 ` [PATCH i-g-t 1/3] tests/intel/xe_pm: Rename and clarify mocs_suspend_resume Cavitt, Jonathan
2024-05-13 17:21 ` Rodrigo Vivi
2024-05-13 22:30 ` ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] " Patchwork
2024-05-13 22:39 ` ✓ CI.xeBAT: " Patchwork
2024-05-14 0:49 ` ✗ CI.xeFULL: failure " Patchwork
2024-05-14 13:04 ` Lucas De Marchi
2024-05-14 10:53 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkJMPx7P6qZVEInt@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=badal.nilawar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=janga.rahul.kumar@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.