From: Leo Liang <ycliang@andestech.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Rick Chen <rick@andestech.com>,
Ben Dooks <ben.dooks@codethink.co.uk>, <u-boot@lists.denx.de>
Subject: Re: [PATCH 1/1] riscv: simplify backtrace report
Date: Tue, 14 May 2024 17:54:01 +0800 [thread overview]
Message-ID: <ZkM0pqez5Wsg_S_M@swlinux02> (raw)
In-Reply-To: <20240514055142.26178-1-heinrich.schuchardt@canonical.com>
On Tue, May 14, 2024 at 07:51:42AM +0200, Heinrich Schuchardt wrote:
> * We already have a header 'backtrace', there is no need to repeat the
> word backtrace on every line.
> * Add a blank line before the backtrace section of the crash report for
> improved readability.
> * If U-Boot is compiled without backtrace, there is no need to write a
> message at all.
> * Avoid #ifdef. We prefer functions to always be compiled and let
> the linker remove them if not needed.
> * Foresee 3 digits for the backtrace index.
>
> For testing the 'exception' command can be used.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> arch/riscv/lib/interrupts.c | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
Reviewed-by: Leo Yu-Chi Liang <ycliang@andestech.com>
prev parent reply other threads:[~2024-05-14 9:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 5:51 [PATCH 1/1] riscv: simplify backtrace report Heinrich Schuchardt
2024-05-14 9:54 ` Leo Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkM0pqez5Wsg_S_M@swlinux02 \
--to=ycliang@andestech.com \
--cc=ben.dooks@codethink.co.uk \
--cc=heinrich.schuchardt@canonical.com \
--cc=rick@andestech.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.