From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F24B5C04FFE for ; Tue, 14 May 2024 06:28:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 971E282835; Tue, 14 May 2024 06:28:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id KHQ3Rte6CBls; Tue, 14 May 2024 06:28:36 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org E3E4C827C6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1715668116; bh=gT4Nz2jQUqpKWfezzwbivRUFS8SbyTPv/0FnLOpRIzI=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=CVbDNssx8tKMeIsl9a6jFPkD7n/xs7j37OXZuGidAvVjCxyXxNPv8mn3islFKymky QKMuk9CrLhBb4EvJilxlg4s7DnEOmXbTGchgSzrekx0qErRc1z+5PvlzOxtJQ6WL9n e3D30/RcE0zMeTM2YCUsJxpabpON/bLxsZBBXzI5alJVVSskxGBTnZsXd5b9SdR/gT Q6IRedPuSpqrjeOunQfzCNpXxbNsNIpEuiKAiNd/9OQd4LT0BOZJrp87MiEoU+DjSa MecRARVItFZroutr2aFjZ4FWy7+Xqc/0AixbaIeXdEzR2pE8B0wCOUD43HyW7yQ7xW Yr9DpnzPg45GQ== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id E3E4C827C6; Tue, 14 May 2024 06:28:35 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 6EC6A1BF38D for ; Tue, 14 May 2024 06:28:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 5A920401A6 for ; Tue, 14 May 2024 06:28:34 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id AuEqnJeoraRi for ; Tue, 14 May 2024 06:28:33 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=192.198.163.10; helo=mgamail.intel.com; envelope-from=michal.swiatkowski@linux.intel.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 4199640184 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4199640184 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by smtp4.osuosl.org (Postfix) with ESMTPS id 4199640184 for ; Tue, 14 May 2024 06:28:33 +0000 (UTC) X-CSE-ConnectionGUID: ZGdmQY+LReKhT/cpk457sA== X-CSE-MsgGUID: 4Z2xuc+CT46YxPxm24yL0g== X-IronPort-AV: E=McAfee;i="6600,9927,11072"; a="23032217" X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="23032217" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2024 23:28:33 -0700 X-CSE-ConnectionGUID: //F9auJcTIWsJ3JlW9L7eQ== X-CSE-MsgGUID: wYzLra60TIy7l8Y0KH2v0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="30526862" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2024 23:28:30 -0700 Date: Tue, 14 May 2024 08:27:57 +0200 From: Michal Swiatkowski To: Simon Horman Message-ID: References: <20240513083735.54791-1-michal.swiatkowski@linux.intel.com> <20240513083735.54791-9-michal.swiatkowski@linux.intel.com> <20240513160947.GQ2787@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240513160947.GQ2787@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715668113; x=1747204113; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uvLtRB2vRXuhGSiN6dmEWnhdZEwKhSyXzmwhQ4T0ths=; b=SmuyXb4KkOfhBLg5uXmRoyld1CENjrsw64fJ4gNx0mvp9VTjT940FE2u y15h9eh2xsWQWQqGKgL6iC/fnNeCgY1XRSD/bo1l03srXikBthI7uB3Gg Cf5vAIPSljiwbFf4dSMI6lIrlZca3eLZi6b8S1IbzJdo3myus0ciODTwW kZC1RCZbwQXk7vMq6/Fux4w2vOTrjAX/8L/Hf/KnPWLvUqs1rZA/zC6Bh 23wtUGPZTZlSWqc9FVmxqx4OPpeymGSoePKrpCiza0F2FGgJURi7n1hP7 pzdkrNQt4IJLbNfvdThBdw/RA/atI/RazxLBYa5ZHkAf0F5WGE+wiEKpy Q==; X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=none (p=none dis=none) header.from=linux.intel.com X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=SmuyXb4K Subject: Re: [Intel-wired-lan] [iwl-next v2 08/15] ice: make reprresentor code generic X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shayd@nvidia.com, maciej.fijalkowski@intel.com, mateusz.polchlopek@intel.com, netdev@vger.kernel.org, jiri@nvidia.com, michal.kubiak@intel.com, intel-wired-lan@lists.osuosl.org, pio.raczynski@gmail.com, sridhar.samudrala@intel.com, jacob.e.keller@intel.com, wojciech.drewek@intel.com, przemyslaw.kitszel@intel.com Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, May 13, 2024 at 05:09:47PM +0100, Simon Horman wrote: > On Mon, May 13, 2024 at 10:37:28AM +0200, Michal Swiatkowski wrote: > > Keep the same flow of port representor creation, but instead of general > > attach function create helpers for specific representor type. > > > > Store function pointer for add and remove representor. > > > > Type of port representor can be also known based on VSI type, but it > > is more clean to have it directly saved in port representor structure. > > > > Add devlink lock for whole port representor creation and destruction. > > > > Reviewed-by: Wojciech Drewek > > Signed-off-by: Michal Swiatkowski > > nit: In subject, reprresentor -> representor > > > --- > > .../ethernet/intel/ice/devlink/devlink_port.h | 1 + > > drivers/net/ethernet/intel/ice/ice_eswitch.c | 74 +++++++++++----- > > drivers/net/ethernet/intel/ice/ice_eswitch.h | 11 +-- > > drivers/net/ethernet/intel/ice/ice_repr.c | 88 +++++++++---------- > > drivers/net/ethernet/intel/ice/ice_repr.h | 16 +++- > > drivers/net/ethernet/intel/ice/ice_sriov.c | 4 +- > > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 +- > > 7 files changed, 121 insertions(+), 77 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h b/drivers/net/ethernet/intel/ice/devlink/devlink_port.h > > index e4acd855d9f9..6e14b9e4d621 100644 > > --- a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h > > +++ b/drivers/net/ethernet/intel/ice/devlink/devlink_port.h > > @@ -23,6 +23,7 @@ struct ice_dynamic_port { > > struct devlink_port devlink_port; > > struct ice_pf *pf; > > struct ice_vsi *vsi; > > + unsigned long repr_id; > > nit: Please add an entry for repr_id to the Kernel doc for this structure. > > And also the attached field which is added by the last patch > of this series. > Thanks, will recheck every field > > u32 sfnum; > > }; > > > > ... From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 385E71B7FD for ; Tue, 14 May 2024 06:28:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715668115; cv=none; b=CFB7t9xtxYFeZvch/Uer+/GSNCyKJp3pJ7OW0XLVw/MS1hmMx+dFrElkQ0TE6l35XGIK1wz5znITUtKHb+wP+UqkKQDQNgdqBNxbXIAaLushn9U6+bE66dHXH62SxcYLGH0JTUnKsfiWFBE6xvTEnZn6IFvtRAnFBv+9DuLDU5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715668115; c=relaxed/simple; bh=uvLtRB2vRXuhGSiN6dmEWnhdZEwKhSyXzmwhQ4T0ths=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r2kSoDD4wbay4+DopsyMmK/272vWP3tQqld7gFkrcGlm6xSvkiX7n+F8K0R0d3jXr7Xz51rV7QviQHWugtjI8NOUhKeLjKjadVhLGKgwO7BpRi28ou4LY9XUc94r33D6Y4kMr1A/SBcqQTm+PADHP5mpcUCNM2jqpAm0LsYn2JA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=SmuyXb4K; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="SmuyXb4K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715668113; x=1747204113; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=uvLtRB2vRXuhGSiN6dmEWnhdZEwKhSyXzmwhQ4T0ths=; b=SmuyXb4KkOfhBLg5uXmRoyld1CENjrsw64fJ4gNx0mvp9VTjT940FE2u y15h9eh2xsWQWQqGKgL6iC/fnNeCgY1XRSD/bo1l03srXikBthI7uB3Gg Cf5vAIPSljiwbFf4dSMI6lIrlZca3eLZi6b8S1IbzJdo3myus0ciODTwW kZC1RCZbwQXk7vMq6/Fux4w2vOTrjAX/8L/Hf/KnPWLvUqs1rZA/zC6Bh 23wtUGPZTZlSWqc9FVmxqx4OPpeymGSoePKrpCiza0F2FGgJURi7n1hP7 pzdkrNQt4IJLbNfvdThBdw/RA/atI/RazxLBYa5ZHkAf0F5WGE+wiEKpy Q==; X-CSE-ConnectionGUID: g//uZVJWRV+DgfLf+6y/MA== X-CSE-MsgGUID: iNxJkVauQUK7c7OCArzx1Q== X-IronPort-AV: E=McAfee;i="6600,9927,11072"; a="23032218" X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="23032218" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2024 23:28:33 -0700 X-CSE-ConnectionGUID: //F9auJcTIWsJ3JlW9L7eQ== X-CSE-MsgGUID: wYzLra60TIy7l8Y0KH2v0g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="30526862" Received: from unknown (HELO mev-dev) ([10.237.112.144]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2024 23:28:30 -0700 Date: Tue, 14 May 2024 08:27:57 +0200 From: Michal Swiatkowski To: Simon Horman Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, jacob.e.keller@intel.com, michal.kubiak@intel.com, maciej.fijalkowski@intel.com, sridhar.samudrala@intel.com, przemyslaw.kitszel@intel.com, wojciech.drewek@intel.com, pio.raczynski@gmail.com, jiri@nvidia.com, mateusz.polchlopek@intel.com, shayd@nvidia.com Subject: Re: [iwl-next v2 08/15] ice: make reprresentor code generic Message-ID: References: <20240513083735.54791-1-michal.swiatkowski@linux.intel.com> <20240513083735.54791-9-michal.swiatkowski@linux.intel.com> <20240513160947.GQ2787@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240513160947.GQ2787@kernel.org> On Mon, May 13, 2024 at 05:09:47PM +0100, Simon Horman wrote: > On Mon, May 13, 2024 at 10:37:28AM +0200, Michal Swiatkowski wrote: > > Keep the same flow of port representor creation, but instead of general > > attach function create helpers for specific representor type. > > > > Store function pointer for add and remove representor. > > > > Type of port representor can be also known based on VSI type, but it > > is more clean to have it directly saved in port representor structure. > > > > Add devlink lock for whole port representor creation and destruction. > > > > Reviewed-by: Wojciech Drewek > > Signed-off-by: Michal Swiatkowski > > nit: In subject, reprresentor -> representor > > > --- > > .../ethernet/intel/ice/devlink/devlink_port.h | 1 + > > drivers/net/ethernet/intel/ice/ice_eswitch.c | 74 +++++++++++----- > > drivers/net/ethernet/intel/ice/ice_eswitch.h | 11 +-- > > drivers/net/ethernet/intel/ice/ice_repr.c | 88 +++++++++---------- > > drivers/net/ethernet/intel/ice/ice_repr.h | 16 +++- > > drivers/net/ethernet/intel/ice/ice_sriov.c | 4 +- > > drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 +- > > 7 files changed, 121 insertions(+), 77 deletions(-) > > > > diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h b/drivers/net/ethernet/intel/ice/devlink/devlink_port.h > > index e4acd855d9f9..6e14b9e4d621 100644 > > --- a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h > > +++ b/drivers/net/ethernet/intel/ice/devlink/devlink_port.h > > @@ -23,6 +23,7 @@ struct ice_dynamic_port { > > struct devlink_port devlink_port; > > struct ice_pf *pf; > > struct ice_vsi *vsi; > > + unsigned long repr_id; > > nit: Please add an entry for repr_id to the Kernel doc for this structure. > > And also the attached field which is added by the last patch > of this series. > Thanks, will recheck every field > > u32 sfnum; > > }; > > > > ...