From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH 1/4] x86/gen-cpuid: Minor cleanup
Date: Tue, 14 May 2024 09:14:03 +0200 [thread overview]
Message-ID: <ZkMPOxF2aR6wp1Vj@macbook> (raw)
In-Reply-To: <20240510224002.2324578-2-andrew.cooper3@citrix.com>
On Fri, May 10, 2024 at 11:39:59PM +0100, Andrew Cooper wrote:
> Rename INIT_FEATURE_NAMES to INIT_FEATURE_NAME_TO_VAL as we're about to gain a
> inverse mapping of the same thing.
>
> Use dict.items() unconditionally. iteritems() is a marginal perf optimsiation
> for Python2 only, and simply not worth the effort on a script this small.
My understanding is that what used to be iteritems() in Python 2 is
the behavior of items() in Python 3 (return a generator instead of a
copy of the dictionary list).
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Thanks, Roger.
next prev parent reply other threads:[~2024-05-14 7:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 22:39 [PATCH v3 0/4] x86/xen-cpuid: Use automagically generated names Andrew Cooper
2024-05-10 22:39 ` [PATCH 1/4] x86/gen-cpuid: Minor cleanup Andrew Cooper
2024-05-14 7:14 ` Roger Pau Monné [this message]
2024-05-20 14:17 ` Andrew Cooper
2024-05-10 22:40 ` [PATCH 2/4] tools/xen-cpuid: Rename decodes[] to leaf_info[] Andrew Cooper
2024-05-14 7:14 ` Roger Pau Monné
2024-05-10 22:40 ` [PATCH 3/4] tools/xen-cpuid: Use automatically generated feature names Andrew Cooper
2024-05-14 7:53 ` Roger Pau Monné
2024-05-14 13:05 ` Jan Beulich
2024-05-14 13:05 ` Andrew Cooper
2024-05-14 14:27 ` Roger Pau Monné
2024-05-14 14:30 ` Andrew Cooper
2024-05-20 14:33 ` [PATCH v3.5 " Andrew Cooper
2024-05-20 15:07 ` Roger Pau Monné
2024-05-20 15:20 ` Andrew Cooper
2024-05-20 16:29 ` Roger Pau Monné
2024-05-20 17:37 ` Andrew Cooper
2024-05-10 22:40 ` [PATCH 4/4] tools/xen-cpuid: Drop old names Andrew Cooper
2024-05-14 7:53 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkMPOxF2aR6wp1Vj@macbook \
--to=roger.pau@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.