Re: [PATCH v1 0/4] add tests to verify IFS (In Field Scan) driver functionality

[Pengfei Xu <pengfei.xu@intel.com>]

On 2024-05-14 at 20:55:11 -0700, Kuppuswamy, Sathyanarayanan wrote:
> 
> On 4/29/24 8:31 PM, Pengfei Xu wrote:
> > To verify IFS (In Field Scan [1]) driver functionality, add the following 6
> > test cases:
> >   1. Verify that IFS sysfs entries are created after loading the IFS module
> >   2. Check if loading an invalid IFS test image fails and loading a valid
> >      one succeeds
> >   3. Perform IFS scan test on each CPU using all the available image files
> >   4. Perform IFS scan with first test image file on a random CPU for 3
> >      rounds
> >   5. Perform IFS ARRAY BIST(Board Integrated System Test) test on each CPU
> >   6. Perform IFS ARRAY BIST test on a random CPU for 3 rounds
> >
> > These are not exhaustive, but some minimal test runs to check various
> > parts of the driver. Some negative tests are also included.
> >
> > [1] https://docs.kernel.org/arch/x86/ifs.html
> 
> Looks good to me.
> 
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Thanks for Sathya's tag, and thanks Shuah and Jithu also.

Best Regards,
Thanks!

> 
> > Pengfei Xu (4):
> >   selftests: ifs: verify test interfaces are created by the driver
> >   selftests: ifs: verify test image loading functionality
> >   selftests: ifs: verify IFS scan test functionality
> >   selftests: ifs: verify IFS ARRAY BIST functionality
> >
> >  MAINTAINERS                                   |   1 +
> >  tools/testing/selftests/Makefile              |   1 +
> >  .../drivers/platform/x86/intel/ifs/Makefile   |   6 +
> >  .../platform/x86/intel/ifs/test_ifs.sh        | 496 ++++++++++++++++++
> >  4 files changed, 504 insertions(+)
> >  create mode 100644 tools/testing/selftests/drivers/platform/x86/intel/ifs/Makefile
> >  create mode 100755 tools/testing/selftests/drivers/platform/x86/intel/ifs/test_ifs.sh
> >
> -- 
> Sathyanarayanan Kuppuswamy
> Linux Kernel Developer
>