From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA68AC25B74 for ; Thu, 16 May 2024 11:07:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F2FAD10EC6A; Thu, 16 May 2024 11:07:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="BkWzfcQ7"; dkim-atps=neutral Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EE4D10EC6E for ; Thu, 16 May 2024 11:07:45 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4B1ECE0003; Thu, 16 May 2024 11:07:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1715857662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mPzwo8GURkKv057NaSVRyjsaXMP54tiK1Z3Jjq48Yh8=; b=BkWzfcQ7jwfOAqnwEdzMCpV9fr07ChPRZSb7kTF/ShveC6Dx+b9FkN0yLPVQN3cfp+LBeK zSXaZ2OSQHX/Cutzewl1nFTcmBEx9Wjae8YPyZA6jSYOzXNPTtAg2W7HKOWiUk8h8dhO2e RBb9ur7Pk80QXoKNTVB0888jsFMaO9OyecR7Aku7dMpewKrKseU6h6g8XScCIiXR+95hd0 P709tiRf4nf7+V/ocl/QqXM9Ou8y2EyUwDh1LoGnlQaq1XJI/c3Vf/D/a0yaCqaQPg7/h0 lURTKtaMZAcWLEiBK0gbp6CBJHJxoA2tPbzO8TcamimWXhMlVLBPag5scD003w== Date: Thu, 16 May 2024 13:07:36 +0200 From: Louis Chauvet To: =?iso-8859-1?Q?Ma=EDra?= Canal Cc: Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , rdunlap@infradead.org, arthurgrillo@riseup.net, Jonathan Corbet , pekka.paalanen@haloniitty.fi, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com Subject: Re: [PATCH v7 11/17] drm/vkms: Remove useless drm_rotation_simplify Message-ID: Mail-Followup-To: =?iso-8859-1?Q?Ma=EDra?= Canal , Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , rdunlap@infradead.org, arthurgrillo@riseup.net, Jonathan Corbet , pekka.paalanen@haloniitty.fi, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com References: <20240513-yuv-v7-0-380e9ffec502@bootlin.com> <20240513-yuv-v7-11-380e9ffec502@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-GND-Sasl: louis.chauvet@bootlin.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Le 16/05/24 - 07:43, Maíra Canal a écrit : > Hi Louis, > > On 5/13/24 04:50, Louis Chauvet wrote: > > As all the rotation are now supported by VKMS, this simplification does > > not make sense anymore, so remove it. > > > > Signed-off-by: Louis Chauvet > > I'd like to push all commits up to this point to drm-misc-next. Do you > see a problem with it? Reason: I'd like Melissa to take a look at the > YUV patches and patches 1 to 11 fix several composition errors. > > Let me know your thoughts about it. Hi, This version is missing performance numbers and one fix from Pekka, so please don't merge v7. I will push a v8 today (if I have the time to fetch all the performance numbers), with the performance numbers and the fix. Thanks, Louis Chauvet > Best Regards, > - Maíra > > > --- > > drivers/gpu/drm/vkms/vkms_plane.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > > index 8875bed76410..5a028ee96c91 100644 > > --- a/drivers/gpu/drm/vkms/vkms_plane.c > > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > > @@ -115,12 +115,7 @@ static void vkms_plane_atomic_update(struct drm_plane *plane, > > frame_info->fb = fb; > > memcpy(&frame_info->map, &shadow_plane_state->data, sizeof(frame_info->map)); > > drm_framebuffer_get(frame_info->fb); > > - frame_info->rotation = drm_rotation_simplify(new_state->rotation, DRM_MODE_ROTATE_0 | > > - DRM_MODE_ROTATE_90 | > > - DRM_MODE_ROTATE_270 | > > - DRM_MODE_REFLECT_X | > > - DRM_MODE_REFLECT_Y); > > - > > + frame_info->rotation = new_state->rotation; > > > > vkms_plane_state->pixel_read_line = get_pixel_read_line_function(fmt); > > } > > -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com