Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config

[Hongren Zheng <i@zenithal.me>]

On Mon, May 13, 2024 at 03:18:53PM +0800, Yangyu Chen wrote:
> I think this patch also needs to back-port to stable-8.2.

Indeed, downstream OpenSSL CI using Ubuntu 24.04, which ships
QEMU 8.2.2, encountered this bug and that is quite confusing

QEMU 9.0.0 is also affected

Links
https://github.com/openssl/openssl/pull/24403/commits/5f7750fa0d366fd87d3280c18f7539f720a8d0be
https://github.com/openssl/openssl/pull/24403#issuecomment-2115320298

> 
> I added qemu-stable@nongnu.org to cc.
> 
> > On May 11, 2024, at 19:26, Yangyu Chen <cyy@cyyself.name> wrote:
> > 
> > This code has a typo that writes zvkb to zvkg, causing users can't
> > enable zvkb through the config. This patch gets this fixed.
> > 
> > Signed-off-by: Yangyu Chen <cyy@cyyself.name>
> > Fixes: ea61ef7097d0 ("target/riscv: Move vector crypto extensions to riscv_cpu_extensions")
> > Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
> > ---
> > target/riscv/cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c
> > index eb1a2e7d6d..13cd34adbd 100644
> > --- a/target/riscv/cpu.c
> > +++ b/target/riscv/cpu.c
> > @@ -1535,7 +1535,7 @@ const RISCVCPUMultiExtConfig riscv_cpu_extensions[] = {
> >     /* Vector cryptography extensions */
> >     MULTI_EXT_CFG_BOOL("zvbb", ext_zvbb, false),
> >     MULTI_EXT_CFG_BOOL("zvbc", ext_zvbc, false),
> > -    MULTI_EXT_CFG_BOOL("zvkb", ext_zvkg, false),
> > +    MULTI_EXT_CFG_BOOL("zvkb", ext_zvkb, false),
> >     MULTI_EXT_CFG_BOOL("zvkg", ext_zvkg, false),
> >     MULTI_EXT_CFG_BOOL("zvkned", ext_zvkned, false),
> >     MULTI_EXT_CFG_BOOL("zvknha", ext_zvknha, false),
> > -- 
> > 2.43.0
> > 
> 
> 
>