From: Vishal Moola <vishal.moola@gmail.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Matthew Wilcox <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeel.butt@linux.dev>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm: refactor folio_undo_large_rmappable()
Date: Thu, 16 May 2024 08:54:08 -0700 [thread overview]
Message-ID: <ZkYsIHAII6gUQg4w@fedora> (raw)
In-Reply-To: <20240515064506.72253-1-wangkefeng.wang@huawei.com>
On Wed, May 15, 2024 at 02:45:06PM +0800, Kefeng Wang wrote:
> All folio_undo_large_rmappable() callers will check folio_test_large()
> which already checked by folio_order(), so only add the check
This commit message is a little misleading. The folio_order() check in
folio_undo_large_rmappable() is primarily for catching order-1 folios,
not to check folio_test_large(). You can read more about it in
commit: 8897277acfef7f70fdecc.
Aside from that, I like the patch. It should make this code easier to
maintain.
next prev parent reply other threads:[~2024-05-16 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 6:45 [PATCH] mm: refactor folio_undo_large_rmappable() Kefeng Wang
2024-05-15 6:53 ` Lance Yang
2024-05-16 4:43 ` Kefeng Wang
2024-05-16 15:54 ` Vishal Moola [this message]
2024-05-17 5:18 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkYsIHAII6gUQg4w@fedora \
--to=vishal.moola@gmail.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.