From: Marcel Telka <marcel@telka.sk>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] t/t9902-completion.sh: backslashes in echo
Date: Fri, 24 May 2024 00:39:05 +0200 [thread overview]
Message-ID: <Zk_FiYd8uk-P5jIi@telcontar> (raw)
In-Reply-To: <Zk-5YCKSO32vPKDP@telcontar>
On Thu, May 23, 2024 at 11:47:13PM +0200, Marcel Telka wrote:
> Interesting. I came to this issue because the test failed here due to
> the echo. So apparently the re-run under bash didn't happen here for
> some reason or bash's echo behaved differently? I need to dig into it
> again to find what's going on.
Okay, I found the cause. Bash on OpenIndiana is compiled with
--enable-xpg-echo-default so escape sequencies are expanded by default.
> OTOH, it seems that the fix is maybe not needed because it is solving a
> non-problem.
There is a problem, but definitely the justification in the commit
message is not accurate because we do not care about POSIX here at all.
Also maybe it would be better/simpler to use `echo -E` instead of
`printf`, but I'm not sure here.
Thanks.
--
+-------------------------------------------+
| Marcel Telka e-mail: marcel@telka.sk |
| homepage: http://telka.sk/ |
+-------------------------------------------+
next prev parent reply other threads:[~2024-05-23 22:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 14:08 [PATCH] t/t9902-completion.sh: backslashes in echo Marcel Telka
2024-05-23 17:59 ` Junio C Hamano
2024-05-23 20:31 ` Marcel Telka
2024-05-23 21:06 ` Eric Sunshine
2024-05-23 21:47 ` Marcel Telka
2024-05-23 22:39 ` Marcel Telka [this message]
2024-05-23 22:45 ` Marcel Telka
2024-05-23 23:03 ` Junio C Hamano
2024-05-23 23:14 ` Eric Sunshine
2024-05-23 23:21 ` Marcel Telka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zk_FiYd8uk-P5jIi@telcontar \
--to=marcel@telka.sk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.