Re: [Buildroot] [PATCH] package/ntp: fix build with GCC 14.x

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Yegor, All,

On 2024-05-17 14:00 +0200, yegorslists--- via buildroot spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Fix pthread_detach() detection that is broken when building
> with GCC 14.x.
> 
> The patch is taken from a Gentoo repository:
> 
> https://gitweb.gentoo.org/repo/gentoo.git/diff/net-misc/ntp/files/ntp-4.2.8_p15-configure-clang16.patch?id=56ef5ce33891feec34cd0c39a0a774a81a587dc7
> 
> Bonus: refresh the 0002-ntp-syscalls-fallback.patch file.

Sure, but it's relatively obvious, by looking and the changeset, that
the patch was modified; the interesting information to have in the
commit log is why it was refreshed:

    Addtionally, refresh patch 0002 to fix the offset of hunk 1.

> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  package/ntp/0002-ntp-syscalls-fallback.patch  |  9 ++++---
>  .../ntp/0003-fix-pthread-detach-check.patch   | 27 +++++++++++++++++++

    $ make check-package
    package/ntp/0003-fix-pthread-detach-check.patch:0: missing Upstream in the header (https://nightly.buildroot.org/#_additional_patch_documentation)

Yes, you do provide the location where you grabbed the patch from, and
this is very good. Still, we need to know what the upstream status for
that patch is: has it been submitted? If no, why? If yes, what is the
URL to the PR/MR, bug report, email?

It is a bit unfortunate that ntp uses bitkeeper as a VCS, which makes it
a bit more difficult to contribute to, but we still need that in
formation...

I see that the last commits dates from just a few days ago, so the
project is not dead.

Could you please check whether this patch was submitted? Maybe there is
some info about that in the gentoo history for that patch?

> diff --git a/package/ntp/0002-ntp-syscalls-fallback.patch b/package/ntp/0002-ntp-syscalls-fallback.patch
> index 535fc93dfd..46704b9d3f 100644
> --- a/package/ntp/0002-ntp-syscalls-fallback.patch
> +++ b/package/ntp/0002-ntp-syscalls-fallback.patch
> @@ -8,10 +8,11 @@ Signed-off-by: James Knight <james.knight@rockwellcollins.com>
>   configure.ac | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>  
> -diff --git a/configure.ac b/configure.ac
> ---- a/configure.ac
> -+++ b/configure.ac
> -@@ -1523,11 +1523,11 @@ AC_CACHE_CHECK(
> +Index: ntp-4.2.8p17/configure.ac
> +===================================================================
> +--- ntp-4.2.8p17.orig/configure.ac
> ++++ ntp-4.2.8p17/configure.ac
> +@@ -1472,11 +1472,11 @@ AC_CACHE_CHECK(

Just fixing the line would have made for a smaller delta, with less
useless changes in the diff metadata.

Also, the patch was (almost) git-formatted, which is the preferred form
for bundled patches. Unless it is submitted to, or backported from the
upstream VCS, in which case it should be in a format supported by that
VCS. ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot