From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Petr Beneš" <w1benny@gmail.com>
Cc: xen-devel@lists.xenproject.org, Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH for-4.19? v4 1/6] x86/p2m: Add braces for better code clarity
Date: Mon, 20 May 2024 10:31:02 +0200 [thread overview]
Message-ID: <ZksKRrr5aeWnkK1l@macbook> (raw)
In-Reply-To: <36d1488857a595fd6a286ab2de26cd672df3f387.1716029860.git.w1benny@gmail.com>
On Sat, May 18, 2024 at 11:02:12AM +0000, Petr Beneš wrote:
> From: Petr Beneš <w1benny@gmail.com>
>
> No functional change.
>
> Signed-off-by: Petr Beneš <w1benny@gmail.com>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
TBH I'm fine without the braces, but if lack of them can cause
confusion:
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
CODING_STYLE states that braces can be omitted for blocks with single
statements, I guess we should clarify whether multi-line statements
are accepted, as the example contains a single-line statement.
Thanks, Roger.
next prev parent reply other threads:[~2024-05-20 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-18 11:02 [PATCH for-4.19? v4 0/6] x86: Make MAX_ALTP2M configurable Petr Beneš
2024-05-18 11:02 ` [PATCH for-4.19? v4 1/6] x86/p2m: Add braces for better code clarity Petr Beneš
2024-05-20 8:31 ` Roger Pau Monné [this message]
2024-05-18 11:02 ` [PATCH for-4.19? v4 2/6] tools/xl: Add altp2m_count parameter Petr Beneš
2024-05-18 11:02 ` [PATCH for-4.19? v4 3/6] docs/man: Add altp2m_count parameter to the xl.cfg manual Petr Beneš
2024-05-18 11:02 ` [PATCH for-4.19? v4 4/6] x86: Make the maximum number of altp2m views configurable Petr Beneš
2024-05-20 8:25 ` Roger Pau Monné
2024-05-21 10:59 ` Jan Beulich
2024-05-26 23:55 ` Petr Beneš
2024-05-27 6:19 ` Jan Beulich
2024-05-29 19:20 ` Petr Beneš
2024-05-18 11:02 ` [PATCH for-4.19? v4 5/6] tools/libxl: Activate the altp2m_count feature Petr Beneš
2024-05-18 11:02 ` [PATCH for-4.19? v4 6/6] tools/ocaml: Add altp2m_count parameter Petr Beneš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZksKRrr5aeWnkK1l@macbook \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=w1benny@gmail.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.