All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org, linux-spi@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v1 1/1] spi: pxa2xx: Move PXA SSP bindings to the correct folder
Date: Mon, 20 May 2024 13:47:26 +0300	[thread overview]
Message-ID: <ZksqPiSLY8OlE5lT@smile.fi.intel.com> (raw)
In-Reply-To: <CAL_JsqKA7AnY7w3sjrT+khrat348v7uNpAP1+FZ=mdYMhJkf3Q@mail.gmail.com>

On Fri, May 17, 2024 at 03:19:51PM -0500, Rob Herring wrote:
> On Fri, May 17, 2024 at 2:58 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Fri, May 17, 2024 at 06:24:37PM +0100, Mark Brown wrote:
> > > On Fri, May 17, 2024 at 08:11:03PM +0300, Andy Shevchenko wrote:

...

> > > > SSP stands for Serial Synchronous Protocol and has nothing to do with
> > > > UART, also known as USART, where 'A' stands for Asynchronous.
> > > >
> > > > Move the SSP bindings to where it belongs.
> > >
> > > It's a serial device which is also used for other applications (the
> > > other one upstream being audio) so I can see where the current binding
> > > comes from and it's not super obvious that spi is especially better
> > > here.
> >
> > Hmm... okay. Then it's question to DT people. Consider this as a report.
> > Because UART (aka serial) is definitely not the place for SPI/SSP bindings
> > either.
> 
> Move it when it is converted.

The problem is that somebody added a binding (in YAML) for SPI PXA2xx
in the spi/ folder while this one kept unconverted.

If it dangles more, it might be that we will have two asynchronous bindings
for the co-existed drivers.

> Until then, I don't care too much. SPI seems better than serial at least.
> The sound part is its own binding/node (something we wouldn't do today).

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-05-20 10:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-17 17:11 [PATCH v1 1/1] spi: pxa2xx: Move PXA SSP bindings to the correct folder Andy Shevchenko
2024-05-17 17:24 ` Mark Brown
2024-05-17 19:58   ` Andy Shevchenko
2024-05-17 20:19     ` Rob Herring
2024-05-20 10:47       ` Andy Shevchenko [this message]
2024-05-20 20:36         ` Rob Herring
2024-05-21 14:02           ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZksqPiSLY8OlE5lT@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.