From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34246168BD for ; Mon, 20 May 2024 20:53:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716238412; cv=none; b=BpPs9bY28rJPZ9I2q4cvl7O6yeDXNpl3vFu/PZ6WFtk7pvNwYS86cV0OdmaF417CzqPU8+XqCKZtRddnoPR62Mxz+lBfLBjV/wpzPpmhHkpzCTrqGEOD9Zf9PoDKOXjyW4gHWsMJ9bd8r3lkWsmKNcXWEbbtpogmpRfWipgB3Qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716238412; c=relaxed/simple; bh=n6yMqD/WngMwk7w9Jeu47n5HWVQHksGgcRTHISmJ6W0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XwzaL0b7hLtYhK5NkCXkdfuxvtu2DiVEoW3I9KUNKEyOxQzuMo12vB2oMAEBAowGLFoXTq4as0NsURBSYu8udyAoYj0kE77TcxjcAVewul40HmR+c6KonXr2rEo+Qg+wsX57EwzuO+6q5qtp7pWuO3c4uiMwDeWDzHRH9Xk3Sas= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lFFgi+F+; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lFFgi+F+" X-Envelope-To: tabba@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716238408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r0e2eP2YYVoU2x+o/8aZJiXueSDsv6ENv+vQg2tvzwY=; b=lFFgi+F+blut49/BSKLTZAkqokdnmBHw130VFMSQdXTmv7psR9h6bsXjii8vb7OqjBU+6C hwYqlUluEL360ULfWeuGwgmFvpjGiT6O0uM/ugpqt2VR6trPMgWqsXLIioRf3yFUhp4GqW vdaW1NJBaoubsTR041rB42Jr8s+ZJOQ= X-Envelope-To: maz@kernel.org X-Envelope-To: broonie@kernel.org X-Envelope-To: kvmarm@lists.linux.dev X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: will@kernel.org X-Envelope-To: qperret@google.com X-Envelope-To: seanjc@google.com X-Envelope-To: alexandru.elisei@arm.com X-Envelope-To: catalin.marinas@arm.com X-Envelope-To: philmd@linaro.org X-Envelope-To: james.morse@arm.com X-Envelope-To: suzuki.poulose@arm.com X-Envelope-To: mark.rutland@arm.com X-Envelope-To: joey.gouly@arm.com X-Envelope-To: rananta@google.com X-Envelope-To: yuzenghui@huawei.com Date: Mon, 20 May 2024 13:53:20 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Fuad Tabba Cc: Marc Zyngier , Mark Brown , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com Subject: Re: [PATCH v1 0/7] KVM: arm64: Fix handling of host fpsimd/sve state in protected mode Message-ID: References: <20240517131814.719933-1-tabba@google.com> <87pltg3ntq.wl-maz@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Migadu-Flow: FLOW_OUT Hey Fuad, On Mon, May 20, 2024 at 06:57:36PM +0100, Fuad Tabba wrote: > Hi Oliver, > > On Mon, May 20, 2024 at 6:37 PM Oliver Upton wrote: > > > > On Mon, May 20, 2024 at 09:11:13AM +0100, Marc Zyngier wrote: > > > On Mon, 20 May 2024 08:35:47 +0100, Fuad Tabba wrote: > > > > The reason for that is that in pKVM we want to avoid leaking any > > > > information about protected VM activity to the host, including whether > > > > the VM might have performed fpsimd/sve operations. Therefore, we need > > > > to ensure that the host SVE state looks the same after a protected > > > > guest has run as it did before a protected guest has run. > > > > Wouldn't it be equally valid to just zero the state that will not be > > preserved regardless of whether or not the guest used fpsimd/sve? > > Yes it would. I think I did mention that as an option. Apologies, I probably missed it earlier on then. > However, that would need to be done at every protected guest exit, whereas > restoring the host SVE state only needs to be done if the guest has used > fpsimd/sve. Indeed, what I was _hoping_ is that implementations do a decent job of handling a zeroing idiom for SVE and avoid needing to fetch a bunch of state out of memory. > I think the code for the latter (i.e., zeroing out), would be simpler. > I'm happy to do it that way if you and the others think it's better. Right, I have no fundamental objections to fully managing the host SVE state in EL2. Strong preference for something simple + correct in the interim. Anyway, thanks for suffering through my whining and hopefully we can land a fix soon :) -- Best, Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 465FDC25B77 for ; Mon, 20 May 2024 20:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jvPWJQNka28vKtXHBExGEJM63NCXKfSDs3WF+tmN3Nw=; b=Gx3E82CeWF1Tsc wfJq5Ny08NPJFQqPqYHxRGo3IhsByYsASSBTetFpKLCfTZM3X7lO/ccKWVk2kEvLGrJB4mGWeWq4D 4SiqZjmVdWXowuYWceo423wQ2Y9ZQyM/pCeOa+OHFL/ehpPsojiunl2uIwGz0IOlWjOIOF2W1bxSX gDLyoG0zKThNxMqlpwAf1qbEsGwah0cWqwt7CpB3wZXvo/dksFmb56AwZ/B8Re2JRBT+c8Kei6t7J e3TFIqQKtlIihW79AFirpowDgzvl4W1qy6bmR/bOXPz5xp65+uMFWcGd47kPMPO/obkYsN/3QpEcP 9CBu6PdsUyqDfyqDbd5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9A0n-0000000FWom-2EOO; Mon, 20 May 2024 20:53:37 +0000 Received: from out-172.mta0.migadu.com ([91.218.175.172]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9A0j-0000000FWo7-1pn1 for linux-arm-kernel@lists.infradead.org; Mon, 20 May 2024 20:53:35 +0000 X-Envelope-To: tabba@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716238408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r0e2eP2YYVoU2x+o/8aZJiXueSDsv6ENv+vQg2tvzwY=; b=lFFgi+F+blut49/BSKLTZAkqokdnmBHw130VFMSQdXTmv7psR9h6bsXjii8vb7OqjBU+6C hwYqlUluEL360ULfWeuGwgmFvpjGiT6O0uM/ugpqt2VR6trPMgWqsXLIioRf3yFUhp4GqW vdaW1NJBaoubsTR041rB42Jr8s+ZJOQ= X-Envelope-To: maz@kernel.org X-Envelope-To: broonie@kernel.org X-Envelope-To: kvmarm@lists.linux.dev X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: will@kernel.org X-Envelope-To: qperret@google.com X-Envelope-To: seanjc@google.com X-Envelope-To: alexandru.elisei@arm.com X-Envelope-To: catalin.marinas@arm.com X-Envelope-To: philmd@linaro.org X-Envelope-To: james.morse@arm.com X-Envelope-To: suzuki.poulose@arm.com X-Envelope-To: mark.rutland@arm.com X-Envelope-To: joey.gouly@arm.com X-Envelope-To: rananta@google.com X-Envelope-To: yuzenghui@huawei.com Date: Mon, 20 May 2024 13:53:20 -0700 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Fuad Tabba Cc: Marc Zyngier , Mark Brown , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, will@kernel.org, qperret@google.com, seanjc@google.com, alexandru.elisei@arm.com, catalin.marinas@arm.com, philmd@linaro.org, james.morse@arm.com, suzuki.poulose@arm.com, mark.rutland@arm.com, joey.gouly@arm.com, rananta@google.com, yuzenghui@huawei.com Subject: Re: [PATCH v1 0/7] KVM: arm64: Fix handling of host fpsimd/sve state in protected mode Message-ID: References: <20240517131814.719933-1-tabba@google.com> <87pltg3ntq.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240520_135333_848942_F228899F X-CRM114-Status: GOOD ( 22.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGV5IEZ1YWQsCgpPbiBNb24sIE1heSAyMCwgMjAyNCBhdCAwNjo1NzozNlBNICswMTAwLCBGdWFk IFRhYmJhIHdyb3RlOgo+IEhpIE9saXZlciwKPiAKPiBPbiBNb24sIE1heSAyMCwgMjAyNCBhdCA2 OjM34oCvUE0gT2xpdmVyIFVwdG9uIDxvbGl2ZXIudXB0b25AbGludXguZGV2PiB3cm90ZToKPiA+ Cj4gPiBPbiBNb24sIE1heSAyMCwgMjAyNCBhdCAwOToxMToxM0FNICswMTAwLCBNYXJjIFp5bmdp ZXIgd3JvdGU6Cj4gPiA+IE9uIE1vbiwgMjAgTWF5IDIwMjQgMDg6MzU6NDcgKzAxMDAsIEZ1YWQg VGFiYmEgPHRhYmJhQGdvb2dsZS5jb20+IHdyb3RlOgo+ID4gPiA+IFRoZSByZWFzb24gZm9yIHRo YXQgaXMgdGhhdCBpbiBwS1ZNIHdlIHdhbnQgdG8gYXZvaWQgbGVha2luZyBhbnkKPiA+ID4gPiBp bmZvcm1hdGlvbiBhYm91dCBwcm90ZWN0ZWQgVk0gYWN0aXZpdHkgdG8gdGhlIGhvc3QsIGluY2x1 ZGluZyB3aGV0aGVyCj4gPiA+ID4gdGhlIFZNIG1pZ2h0IGhhdmUgcGVyZm9ybWVkIGZwc2ltZC9z dmUgb3BlcmF0aW9ucy4gVGhlcmVmb3JlLCB3ZSBuZWVkCj4gPiA+ID4gdG8gZW5zdXJlIHRoYXQg dGhlIGhvc3QgU1ZFIHN0YXRlIGxvb2tzIHRoZSBzYW1lIGFmdGVyIGEgcHJvdGVjdGVkCj4gPiA+ ID4gZ3Vlc3QgaGFzIHJ1biBhcyBpdCBkaWQgYmVmb3JlIGEgcHJvdGVjdGVkIGd1ZXN0IGhhcyBy dW4uCj4gPgo+ID4gV291bGRuJ3QgaXQgYmUgZXF1YWxseSB2YWxpZCB0byBqdXN0IHplcm8gdGhl IHN0YXRlIHRoYXQgd2lsbCBub3QgYmUKPiA+IHByZXNlcnZlZCByZWdhcmRsZXNzIG9mIHdoZXRo ZXIgb3Igbm90IHRoZSBndWVzdCB1c2VkIGZwc2ltZC9zdmU/Cj4gCj4gWWVzIGl0IHdvdWxkLiBJ IHRoaW5rIEkgZGlkIG1lbnRpb24gdGhhdCBhcyBhbiBvcHRpb24uCgpBcG9sb2dpZXMsIEkgcHJv YmFibHkgbWlzc2VkIGl0IGVhcmxpZXIgb24gdGhlbi4KCj4gSG93ZXZlciwgdGhhdCB3b3VsZCBu ZWVkIHRvIGJlIGRvbmUgYXQgZXZlcnkgcHJvdGVjdGVkIGd1ZXN0IGV4aXQsIHdoZXJlYXMKPiBy ZXN0b3JpbmcgdGhlIGhvc3QgU1ZFIHN0YXRlIG9ubHkgbmVlZHMgdG8gYmUgZG9uZSBpZiB0aGUg Z3Vlc3QgaGFzIHVzZWQKPiBmcHNpbWQvc3ZlLgoKSW5kZWVkLCB3aGF0IEkgd2FzIF9ob3Bpbmdf IGlzIHRoYXQgaW1wbGVtZW50YXRpb25zIGRvIGEgZGVjZW50IGpvYiBvZgpoYW5kbGluZyBhIHpl cm9pbmcgaWRpb20gZm9yIFNWRSBhbmQgYXZvaWQgbmVlZGluZyB0byBmZXRjaCBhIGJ1bmNoIG9m CnN0YXRlIG91dCBvZiBtZW1vcnkuCgo+IEkgdGhpbmsgdGhlIGNvZGUgZm9yIHRoZSBsYXR0ZXIg KGkuZS4sIHplcm9pbmcgb3V0KSwgd291bGQgYmUgc2ltcGxlci4KPiBJJ20gaGFwcHkgdG8gZG8g aXQgdGhhdCB3YXkgaWYgeW91IGFuZCB0aGUgb3RoZXJzIHRoaW5rIGl0J3MgYmV0dGVyLgoKUmln aHQsIEkgaGF2ZSBubyBmdW5kYW1lbnRhbCBvYmplY3Rpb25zIHRvIGZ1bGx5IG1hbmFnaW5nIHRo ZSBob3N0IFNWRQpzdGF0ZSBpbiBFTDIuIFN0cm9uZyBwcmVmZXJlbmNlIGZvciBzb21ldGhpbmcg c2ltcGxlICsgY29ycmVjdCBpbiB0aGUKaW50ZXJpbS4gQW55d2F5LCB0aGFua3MgZm9yIHN1ZmZl cmluZyB0aHJvdWdoIG15IHdoaW5pbmcgYW5kIGhvcGVmdWxseQp3ZSBjYW4gbGFuZCBhIGZpeCBz b29uIDopCgotLSAKQmVzdCwKT2xpdmVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==