From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F17E2C25B78 for ; Mon, 20 May 2024 20:11:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aEk7wU24RcwH8/Oi9oCElpDdXSoPMNnWQRBAS92bD+I=; b=QpVg5aPtMyZJf7 RO7CEHh4Vdc5lu+7+PGtwUWVXdUXE3r2Xd7rSEDlYk+3l0lHeym2R0YFsEgymGZXF+jBX4jU+OxjN 114FO3xRDeAarSjNsYw/qZ/3sdLwRA+P/jleRu8nxsvD13dNkNOQyBy5QGjmhoahQE+T3pT+rhl5o IwMhWwbyyu+d7k3oNg621rVs1HoLcmnt2IDcKY8a9AKsPvyxnmw5iOreA7MhQAfh6NSrUPvLCkReQ PxHJHOILwXwSYYrAOTIIaA3K1QVle/1HRLN0dQkGIFlvI9gT2ZjnFy6+dsxBC8Ua1RHn9CcNcD8T7 wIZPQdvAMgjMepX4WBJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s99MJ-0000000FQxe-3BuH; Mon, 20 May 2024 20:11:47 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s99MG-0000000FQwr-3Sbt for linux-riscv@lists.infradead.org; Mon, 20 May 2024 20:11:46 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1ecd3867556so89665365ad.0 for ; Mon, 20 May 2024 13:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1716235903; x=1716840703; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9PM2o5jNXfuRUuP6TxEIEBudbQR4NtCgVAI1O+sTf7U=; b=mZgBkM/Zxv2+aBCKU6zWXH0YSm6k6uEVfiZCn5YlnD4KiuaZCfceXyW1QpHHZkdh74 FsbRfBJmQdYcfhKmZGJofQ7ReMZXwzXuYMX6yeoAKuR7COab3W3aCz1sDImG533WEKAK 5Z4Lm9eACdSrYcW/Gs/Dr0PthFJBQrst75HL3oB0PJqXs5aunKf9SDKvV+zRtTKlk3LE 6QIuCsMOK4mvJcTRdgBGNJnMBBPfXbS0PToknOqZPU/t6QAceO0WdPEmVzovFnlJ4TR1 /QDGM3Wy22mAY2pwTwveSgGeyfjt4o6mrwlSBcqUnYp1doMoLvtRKBbuIGTVJVnkwEUV EeCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716235903; x=1716840703; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9PM2o5jNXfuRUuP6TxEIEBudbQR4NtCgVAI1O+sTf7U=; b=Y27Lq6JjI6Qs/Yq4WrNV1+DpeBm4tf3mXR0/TA6jhTUE+voJeRG1d9az3w2QTFx5ne D0M4K7PYq1bA7iuLgpokjT5VCk9aflgshDRrhf8ZXx+iRLW84zpzchjxEuEHqTJeul5N +DZyCSiVRFXsLKLQGhwIWXpqFFsUXBeA8g5n6wbR3ebu/ZUmqNHpU7b51kdWgtueh0tr tfnJq6bpufxajFWfXhZHsI4H/aJBYpJntFUg/rJIx3obySLNdhuh0ki0dr+KVZDCWY+6 y72Z1BlqvEy592PDThL+/UMQ/Ck0Ud/QUTen4DQiSep/nf+t0gTqXpQKEe6oKGeX2q32 n/+Q== X-Forwarded-Encrypted: i=1; AJvYcCUvrKZsA8+CYKMbA33yRN301MrG0kPexdwrgV7zBTmKZukXhjCae6uDRhWXX5FOZA2ZiO4bwZ+qQZPXiHVVVPsbf+rHodIyvZLikxabUuG9 X-Gm-Message-State: AOJu0YzqHDUIzn98guJUobL8xj88aFkLMZwzCXiuYXX/T1GdGTiWWCNg F+PMnTsLqg2ZA1fzQtjxawzBrWWDYTx12KvSLBa8Ti4hnv7SBkpRy0xjM1pA1hU= X-Google-Smtp-Source: AGHT+IFRZhmOYJwGAcLbXRL2uDIeayGTe8D9hUj1uP1w+nEBbftf22Y46efOclD6gUxBji0DKSfZog== X-Received: by 2002:a05:6a20:3c90:b0:1ad:9394:2d30 with SMTP id adf61e73a8af0-1afde139a99mr33701775637.37.1716235902866; Mon, 20 May 2024 13:11:42 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2a9d94csm20112830b3a.95.2024.05.20.13.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 13:11:42 -0700 (PDT) Date: Mon, 20 May 2024 13:11:39 -0700 From: Charlie Jenkins To: Jessica Clarke Cc: Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Palmer Dabbelt , linux-riscv , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Conor Dooley Subject: Re: [PATCH 0/2] riscv: Allow vlenb to be probed from DT Message-ID: References: <20240515-add_vlenb_to_dt-v1-0-4ebd7cba0aa1@rivosinc.com> <6DDF33DF-07D6-4230-8674-F91A91660686@jrtc27.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6DDF33DF-07D6-4230-8674-F91A91660686@jrtc27.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240520_131145_008282_0CE42FB5 X-CRM114-Status: GOOD ( 35.65 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCBNYXkgMTYsIDIwMjQgYXQgMDE6NTg6MjlBTSArMDEwMCwgSmVzc2ljYSBDbGFya2Ug d3JvdGU6Cj4gT24gMTYgTWF5IDIwMjQsIGF0IDAwOjA4LCBDaGFybGllIEplbmtpbnMgPGNoYXJs aWVAcml2b3NpbmMuY29tPiB3cm90ZToKPiA+IAo+ID4gT24gV2VkLCBNYXkgMTUsIDIwMjQgYXQg MTE6MjU6MTZQTSArMDEwMCwgSmVzc2ljYSBDbGFya2Ugd3JvdGU6Cj4gPj4gT24gMTUgTWF5IDIw MjQsIGF0IDIyOjUwLCBDaGFybGllIEplbmtpbnMgPGNoYXJsaWVAcml2b3NpbmMuY29tPiB3cm90 ZToKPiA+Pj4gCj4gPj4+IFRoZSBrZXJuZWwgY3VycmVudGx5IHJlcXVpcmVzIGFsbCBoYXJ0cyB0 byBoYXZlIHRoZSBzYW1lIHZhbHVlIGluIHRoZQo+ID4+PiB2bGVuYiBjc3IgdGhhdCBpcyBwcmVz ZW50IHdoZW4gYSBoYXJ0IHN1cHBvcnRzIHZlY3Rvci4gSW4gb3JkZXIgdG8gcmVhZAo+ID4+PiB0 aGlzIGNzciwgdGhlIGtlcm5lbCBuZWVkcyB0byBib290IHRoZSBoYXJ0LiBBZGRpbmcgdmxlbmIg dG8gdGhlIERUIHdpbGwKPiA+Pj4gYWxsb3cgdGhlIGtlcm5lbCB0byBkZXRlY3QgdGhlIGluY29u c2lzdGVuY3kgZWFybHkgYW5kIG5vdCB3YXN0ZSB0aW1lCj4gPj4+IHRyeWluZyB0byBib290IGhh cnRzIHRoYXQgaXQgZG9lc24ndCBzdXBwb3J0Lgo+ID4+IAo+ID4+IFRoYXQgZG9lc27igJl0IHNl ZW0gc3VmZmljaWVudCBqdXN0aWZpY2F0aW9uIHRvIG1lLiBJZiBpdCBjYW4gYmUgcmVhZAo+ID4+ IGZyb20gdGhlIGhhcmR3YXJlLCB3aHkgc2hvdWxkIHdlIGhhdmUgdG8gcHV0IGl0IGluIHRoZSBG RFQ/IFRoZSB3aG9sZQo+ID4+IHBvaW50IG9mIHRoZSBGRFQgaXMgdG8gY29tbXVuaWNhdGUgdGhl IGhhcmR3YXJlIGNvbmZpZ3VyYXRpb24gdGhhdAo+ID4+IGlzbuKAmXQgb3RoZXJ3aXNlIGRpc2Nv dmVyYWJsZS4KPiA+IAo+ID4gWWVzIHlvdSBhcmUgY29ycmVjdCBpbiB0aGF0IHZsZW5iIGlzIGRp c2NvdmVyYWJsZSBvbiBhbnkgY29uZm9ybWluZwo+ID4gY2hpcC4gSG93ZXZlciwgdGhlIG1vdGl2 YXRpb24gaGVyZSBpcyBmb3IgbWFraW5nIGRlY2lzaW9ucyBhYm91dCBob3cgdG8KPiA+IGJvb3Qg YSBoYXJ0IGJlZm9yZSBpdCBpcyBib290ZWQuIEJ5IHBsYWNpbmcgaXQgaW4gdGhlIGRldmljZSB0 cmVlLCB3ZQo+ID4gYXJlIGFibGUgdG8gZGlzYWJsZSB2ZWN0b3IgYmVmb3JlIHRoZSBjaGlwIGlz IGJvb3RlZCBpbnN0ZWFkIG9mIHRyeWluZwo+ID4gdG8gYm9vdCB0aGUgY2hpcCB3aXRoIHZlY3Rv ciBlbmFibGVkIG9ubHkgdG8gZGlzYWJsZSBpdCBsYXRlci4gSW4gYm90aAo+ID4gY2FzZXMgd2hl biB0aGVyZSBpcyBkaWZmZXJlbnQgdmxlbmIgb24gZGlmZmVyZW50IGhhcnRzLCBhbGwgaGFydHMg c3RpbGwKPiA+IGJvb3QgYW5kIHRoZSBvdXRjb21lIGlzIHRoYXQgdmVjdG9yIGlzIGRpc2FibGVk LiBUaGUgZGlmZmVyZW5jZSBpcyB0aGF0Cj4gPiB3aXRoIHRoZSBEVCBlbnRyeSwgbm8gdmVjdG9y IHNldHVwIGNvZGUgbmVlZHMgdG8gYmUgcmFuIG9uIGEgYm9vdGluZwo+ID4gaGFydCB3aGVuIHRo ZSBvdXRjb21lIHdpbGwgYmUgdGhhdCB2ZWN0b3IgaXMgbm90IGVuYWJsZWQuCj4gCj4gV2h5IGRv ZXMgdmxlbiBnZXQgdGhpcyBzcGVjaWFsIHRyZWF0bWVudD8gWW91IGNvdWxkIG1ha2UgZXhhY3Rs eSB0aGUKPiBzYW1lIGFyZ3VtZW50IGZvciB0aGUgbnVtYmVyIG9mIGFzaWQgYml0cy4gVGhlIHBy ZWNlZGVudCBpbiB0aGUga2VybmVsLAo+IHdoZXRoZXIgUklTQy1WIG9yIG90aGVyIGFyY2hpdGVj dHVyZXMsIGlzIHRvIG5vdCBkbyB0aGlzLiBZb3UgY2FuCj4gZGV0ZWN0IGl0LCBzbyB5b3Ugc2hv dWxkLCBlc3BlY2lhbGx5IHNpbmNlIG9wdGltaXNpbmcgZm9yIGFuCj4gZXhjZXB0aW9uYWwsIHVu ZXhwZWN0ZWQgZXJyb3IgY2FzZSBpcyBub3Qgd29ydGh3aGlsZS4KPiAKPiA+PiBBcyBmb3IgVC1I RUFEIHN0dWZmLCBpZiB0aGV5IG5lZWQgaXQgdGhleSBjYW4gaGF2ZSBhIGN1c3RvbSBwcm9wZXJ0 eS4KPiA+PiBUaG91Z2ggbmFpdmVseSBJ4oCZZCBhc3N1bWUgdGhlcmXigJlzIGEgd2F5IHRvIGF2 b2lkIGl0IHN0aWxsLi4uCj4gPiAKPiA+IFQtSGVhZCBkb2VzIG5vdCBleHBvc2UgdmxlbmIgb24g YWxsIG9mIHRoZWlyIGNoaXBzIHNvIEkgZG8gbm90IGtub3cgb2YKPiA+IGFueSBvdGhlciB3YXkg b2YgZ2V0dGluZyB0aGUgdmxlbmIgd2l0aG91dCBoYXZpbmcgaXQgYmUgcHJvdmlkZWQgaW4gYQo+ ID4gRFQuIFRoYXQgd2FzIHRoZSBtb3RpdmF0aW9uIGZvciB0aGlzIHBhdGNoIGluIHRoZSBmaXJz dCBwbGFjZSwgYnV0Cj4gPiBtYWtpbmcgdGhpcyBhdmFpbGFibGUgdG8gYWxsIHZlbmRvcnMgYWxs b3dzIG9wdGltaXphdGlvbnMgdG8gaGFwcGVuCj4gPiBkdXJpbmcgYm9vdC4KPiAKPiBIb3cgZG9l cyB1c2Vyc3BhY2UgcmVhZCBpdCB0aGVuPyBCdXQgaWYgVC1IRUFEIG5lZWQgaXQsIHRoYXQgbWVh bnMgaXQKPiBzaG91bGQgYmUgYSB0aGVhZCx2bGVuLCBub3QgYSByaXNjdix2bGVuLgo+IAo+IEpl c3MKPiAKCkknbGwgbGV0IFBhbG1lciBkZWNpZGUgaWYgaXQgaXMgcmVhc29uYWJsZSB0byBoYXZl IHZsZW5iIGFsbG93ZWQgdG8gYmUKcGxhY2VkIGluIHRoZSBkZXZpY2UgdHJlZSB0byBzdXBwb3J0 IGNvcmVzIGxpa2Ugb25lcyBtYWRlIGJ5IHRoZWFkIHdoaWNoCmRvbid0IHN1cHBvcnQgdmxlbmIu IE90aGVyd2lzZSBJIHdpbGwgcmVwbGFjZSBpdCB3aXRoIGEgdGhlYWQtc3BlY2lmaWMKYmluZGlu Zy4gCgotIENoYXJsaWUKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B916926AC1 for ; Mon, 20 May 2024 20:11:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716235905; cv=none; b=DPvZEkz3bb2BM/jNf450plbBMpW4tEn5WyEHuxkHYqb2H/dNrl6mExG8M/zplGcn+NSaDKuTCh9yw7nIeNJJu2PzlNTaKnTXloYYARs/SDTD84Q5MJTlMcGv1nJSmCOCLKGtppTq8mzQiGE87lsWxZwEg959F1vwbcmCnM7Ybkw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716235905; c=relaxed/simple; bh=3mK/XupUfbYiEhVWmSK+krmIhOz4u5ZP0yn/RTc9hLU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o//mNXdTNHOiO2Gil2d00QyPrLxgd/60hInh5sNEU/soubCeAPMGS4cRR/+NlMRR1H3Ejucsb9o46slQA0uFQw0Eg5+UbTjFudSNYa9rireuAcxBMu/BkFNIkmnwtjpWZQHE107jsGyJr27iPNzMKW3YOLkb9YvCrVsF6jNp+fM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=Xf3/A3yu; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="Xf3/A3yu" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1e651a9f3ffso83200595ad.1 for ; Mon, 20 May 2024 13:11:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1716235903; x=1716840703; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9PM2o5jNXfuRUuP6TxEIEBudbQR4NtCgVAI1O+sTf7U=; b=Xf3/A3yuqqkAKOCO9daG3tXGDreCYNT054DCLigkb7sSdPafCb4tqmTSUABdoiayP7 2IS5/1PNjM+/gW0TjiWwO1qHJtEhb6X2wTSFzMwb9KMVQUYPhy5h35tOANl67t3DHqo8 KM4fZTTzj23+UryKu1tyCIxXErixdm2v9RTDRoNNOVzq1eHw54R8fbq4tDX6DyQqMN6q qvRCzs83iDdXrPX6qljisZPmjlFC9HmMaP/BViMIb2c/08uzH9wgt4uf5juvcutkE11L Y95kLIdJ7tVn0y5UGQk3S8rmSWooyWjRjCgF5rDb4TjHQDX8YCf4TiDarGpU8o0X73T0 PoMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716235903; x=1716840703; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9PM2o5jNXfuRUuP6TxEIEBudbQR4NtCgVAI1O+sTf7U=; b=tEOlfQEr34flTQC/CAH7/minAVsDyMdHdVX2bro2t9yyeUJFV0NMAoIcVz3w+i5XS3 MZqs0IOvokzh2uyPE41cN6NAgOFQPrh7sNrrZ/z2SX2Jeg4Cq7e+Y0aU0ehy3NweS+hX dnO/McSgiM8MAAatSyOq6ga+5CnenkSHYXeyn72YJOwZT7IvjquftpCyrWt9oC037/iY /crH63PiBagK/w9DjgKWY/6eFjP1N45RaqESZBMCg0dmYp1APBrmo8Z3FAZkQ5QO/lvH JIdKiAKzi37jLEgoiItAKiUQbFJ8N2oeD+Mbt3FaSN8CMQybEuCaAWFJ9NUk32P+O9By 5kbQ== X-Forwarded-Encrypted: i=1; AJvYcCUpupaLDZIUM98th1dVpgQUgFfLgSCFpPjm7h/dCzEsZ3jghf+jHrYkENYKfMyzWWbPrj1EPcROdlTJebyOJuNAjVuDcXbNg4QCJw== X-Gm-Message-State: AOJu0Ywloa1EuN9rLjN0yAIYqRUsf0gOh7nvrrhiU3xRtH+IYqOnLLqB qObxLqyh96QJwYwnfQKDR8B0kmi6MAS9vCq0/5PJ/GsEqFQS7fLv9IxJuBHZeLY= X-Google-Smtp-Source: AGHT+IFRZhmOYJwGAcLbXRL2uDIeayGTe8D9hUj1uP1w+nEBbftf22Y46efOclD6gUxBji0DKSfZog== X-Received: by 2002:a05:6a20:3c90:b0:1ad:9394:2d30 with SMTP id adf61e73a8af0-1afde139a99mr33701775637.37.1716235902866; Mon, 20 May 2024 13:11:42 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2a9d94csm20112830b3a.95.2024.05.20.13.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 13:11:42 -0700 (PDT) Date: Mon, 20 May 2024 13:11:39 -0700 From: Charlie Jenkins To: Jessica Clarke Cc: Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Palmer Dabbelt , linux-riscv , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Conor Dooley Subject: Re: [PATCH 0/2] riscv: Allow vlenb to be probed from DT Message-ID: References: <20240515-add_vlenb_to_dt-v1-0-4ebd7cba0aa1@rivosinc.com> <6DDF33DF-07D6-4230-8674-F91A91660686@jrtc27.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6DDF33DF-07D6-4230-8674-F91A91660686@jrtc27.com> On Thu, May 16, 2024 at 01:58:29AM +0100, Jessica Clarke wrote: > On 16 May 2024, at 00:08, Charlie Jenkins wrote: > > > > On Wed, May 15, 2024 at 11:25:16PM +0100, Jessica Clarke wrote: > >> On 15 May 2024, at 22:50, Charlie Jenkins wrote: > >>> > >>> The kernel currently requires all harts to have the same value in the > >>> vlenb csr that is present when a hart supports vector. In order to read > >>> this csr, the kernel needs to boot the hart. Adding vlenb to the DT will > >>> allow the kernel to detect the inconsistency early and not waste time > >>> trying to boot harts that it doesn't support. > >> > >> That doesn’t seem sufficient justification to me. If it can be read > >> from the hardware, why should we have to put it in the FDT? The whole > >> point of the FDT is to communicate the hardware configuration that > >> isn’t otherwise discoverable. > > > > Yes you are correct in that vlenb is discoverable on any conforming > > chip. However, the motivation here is for making decisions about how to > > boot a hart before it is booted. By placing it in the device tree, we > > are able to disable vector before the chip is booted instead of trying > > to boot the chip with vector enabled only to disable it later. In both > > cases when there is different vlenb on different harts, all harts still > > boot and the outcome is that vector is disabled. The difference is that > > with the DT entry, no vector setup code needs to be ran on a booting > > hart when the outcome will be that vector is not enabled. > > Why does vlen get this special treatment? You could make exactly the > same argument for the number of asid bits. The precedent in the kernel, > whether RISC-V or other architectures, is to not do this. You can > detect it, so you should, especially since optimising for an > exceptional, unexpected error case is not worthwhile. > > >> As for T-HEAD stuff, if they need it they can have a custom property. > >> Though naively I’d assume there’s a way to avoid it still... > > > > T-Head does not expose vlenb on all of their chips so I do not know of > > any other way of getting the vlenb without having it be provided in a > > DT. That was the motivation for this patch in the first place, but > > making this available to all vendors allows optimizations to happen > > during boot. > > How does userspace read it then? But if T-HEAD need it, that means it > should be a thead,vlen, not a riscv,vlen. > > Jess > I'll let Palmer decide if it is reasonable to have vlenb allowed to be placed in the device tree to support cores like ones made by thead which don't support vlenb. Otherwise I will replace it with a thead-specific binding. - Charlie