All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ping Cheng <pinglinux@gmail.com>
Cc: linux-input@vger.kernel.org,
	Aaron Armstrong Skomra <skomra@gmail.com>,
	Jason Gerecke <killertofu@gmail.com>,
	Joshua Dickens <joshua.dickens@wacom.com>,
	Joshua Dickens <Joshua@joshua-dickens.com>
Subject: Re: [PATCH] Input: wacom_w8001: Check for string overflow from strscpy calls
Date: Mon, 20 May 2024 16:28:51 -0700	[thread overview]
Message-ID: <Zkvcs0yg1ltamZPY@google.com> (raw)
In-Reply-To: <CAF8JNhKKCCwRzUxookmv9VUecT37fR8psoz7uSVBQqDhnYEBgQ@mail.gmail.com>

Hi Ping,

On Mon, May 20, 2024 at 11:00:26AM -0700, Ping Cheng wrote:
> Hi Dmitry,
> 
> This fix is the same as [1]. Without checking the return value,
> Wolfram's patch [2] fails our downstream build script. I'm adding my
> r-b, if it makes any difference ;).

Could you please tell me how exactly it makes your build script to fail?

My concern is that the warnings are not actionable and therefore pretty
much worthless.

Thanks.

-- 
Dmitry

  reply	other threads:[~2024-05-20 23:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10 23:43 [PATCH] Input: wacom_w8001: Check for string overflow from strscpy calls joshua
2024-05-20 18:00 ` Ping Cheng
2024-05-20 23:28   ` Dmitry Torokhov [this message]
2024-05-21  3:55     ` Ping Cheng
2024-05-22 17:23       ` Dmitry Torokhov
2024-05-23 16:51         ` Jason Gerecke
2024-05-30 23:48           ` Dmitry Torokhov
2024-06-05 16:46             ` [PATCH] Input: wacom_w8001: Correct device name generation Gerecke, Jason
2024-06-06 21:09               ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zkvcs0yg1ltamZPY@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=Joshua@joshua-dickens.com \
    --cc=joshua.dickens@wacom.com \
    --cc=killertofu@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=pinglinux@gmail.com \
    --cc=skomra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.