Re: [PATCH bpf-next v2 3/4] samples/bpf: Add bpf sample to offload flowtable traffic to xdp

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1180 bytes --]

> Alexei Starovoitov <alexei.starovoitov@gmail.com> writes:
> 
> > On Sat, May 18, 2024 at 3:13 AM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >>
> >> Introduce xdp_flowtable_offload bpf sample to offload sw flowtable logic
> >> in xdp layer if hw flowtable is not available or does not support a
> >> specific kind of traffic.
> >>
> >> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >> ---
> >>  samples/bpf/Makefile                     |   7 +-
> >>  samples/bpf/xdp_flowtable_offload.bpf.c  | 591 +++++++++++++++++++++++
> >>  samples/bpf/xdp_flowtable_offload_user.c | 128 +++++
> >>  3 files changed, 725 insertions(+), 1 deletion(-)
> >>  create mode 100644 samples/bpf/xdp_flowtable_offload.bpf.c
> >>  create mode 100644 samples/bpf/xdp_flowtable_offload_user.c
> >
> > I feel this sample code is dead on arrival.
> > Make selftest more real if you want people to use it as an example,
> > but samples dir is just a dumping ground.
> > We shouldn't be adding anything to it.
> 
> Agreed. We can integrate a working sample into xdp-tools instead :)

ack fine, I can post a patch for xdp-tools.

Regards,
Lorenzo

> 
> -Toke
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]