From: Jiri Olsa <olsajiri@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-api@vger.kernel.org, linux-man@vger.kernel.org,
x86@kernel.org, bpf@vger.kernel.org,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Borislav Petkov (AMD)" <bp@alien8.de>,
Ingo Molnar <mingo@redhat.com>, Andy Lutomirski <luto@kernel.org>,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
Deepak Gupta <debug@rivosinc.com>
Subject: Re: [PATCHv6 bpf-next 1/9] x86/shstk: Make return uprobe work with shadow stack
Date: Tue, 21 May 2024 18:54:13 +0200 [thread overview]
Message-ID: <ZkzRtTI72YPAMhIp@krava> (raw)
In-Reply-To: <20240521142221.GA19434@redhat.com>
On Tue, May 21, 2024 at 04:22:21PM +0200, Oleg Nesterov wrote:
> On 05/21, Jiri Olsa wrote:
> >
> > Currently the application with enabled shadow stack will crash
> > if it sets up return uprobe. The reason is the uretprobe kernel
> > code changes the user space task's stack, but does not update
> > shadow stack accordingly.
> >
> > Adding new functions to update values on shadow stack and using
> > them in uprobe code to keep shadow stack in sync with uretprobe
> > changes to user stack.
>
> I don't think my ack has any value in this area but looks good to me.
>
> Reviewed-by: Oleg Nesterov <oleg@redhat.com>
>
>
> > Fixes: 8b1c23543436 ("x86/shstk: Add return uprobe support")
>
> Hmm... Was this commit ever applied?
should have been:
488af8ea7131 x86/shstk: Wire in shadow stack interface
will send new version
thanks,
jirka
>
> Oleg.
>
next prev parent reply other threads:[~2024-05-21 16:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 10:48 [PATCHv6 bpf-next 0/9] uprobe: uretprobe speed up Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 1/9] x86/shstk: Make return uprobe work with shadow stack Jiri Olsa
2024-05-21 14:22 ` Oleg Nesterov
2024-05-21 16:54 ` Jiri Olsa [this message]
2024-05-30 23:04 ` Edgecombe, Rick P
2024-05-21 10:48 ` [PATCHv6 bpf-next 2/9] uprobe: Wire up uretprobe system call Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 3/9] uprobe: Add uretprobe syscall to speed up return probe Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 4/9] selftests/x86: Add return uprobe shadow stack test Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 5/9] selftests/bpf: Add uretprobe syscall test for regs integrity Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 6/9] selftests/bpf: Add uretprobe syscall test for regs changes Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 7/9] selftests/bpf: Add uretprobe syscall call from user space test Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 bpf-next 8/9] selftests/bpf: Add uretprobe shadow stack test Jiri Olsa
2024-05-21 10:48 ` [PATCHv6 9/9] man2: Add uretprobe syscall page Jiri Olsa
2024-05-21 11:36 ` Alejandro Colomar
2024-05-21 11:48 ` Jiri Olsa
2024-05-21 20:24 ` Jiri Olsa
2024-05-21 20:54 ` Alejandro Colomar
2024-05-22 7:54 ` Jiri Olsa
2024-05-22 10:59 ` Alejandro Colomar
2024-05-22 11:52 ` Jiri Olsa
2024-05-21 20:49 ` [PATCHv6 bpf-next 0/9] uprobe: uretprobe speed up Deepak Gupta
2024-05-21 20:57 ` Alexei Starovoitov
2024-05-22 8:55 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZkzRtTI72YPAMhIp@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=debug@rivosinc.com \
--cc=john.fastabend@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=songliubraving@fb.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.