Re: [Buildroot] [External] [PATCH 1/2] support/download: introduce curl backend for FTP transfers

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Brandon, All,

On 2024-05-21 16:19 +0000, Maier, Brandon L                            Collins spake thusly:
> > From: buildroot <buildroot-bounces@buildroot.org> On Behalf Of Yann E.
> > MORIN
[--SNIP--]
> > +config BR2_CURL
> > +     string "Curl command"
> > +     default "curl -q --ftp-pasv --retry 3"
> 
> In my testing I found we need `-L`/`--location` which allows curl to
> follow redirects. Otherwise, some URLs like github tarballs will silently
> fail to download.
> 
> Also I'd suggest `-f`/`--fail` which allows curl to detect some HTTP 4XX
> errors and print them to stderr.

The curl backend is only supposed to handle ftp and ftps URIs, not http
or https. See that part in the download wrapper:

   92         case "${backend}" in
   93             git|svn|cvs|bzr|file|scp|hg|sftp) ;;
   94             ftp|ftps) backend="curl" ;;
   95             *) backend="wget" ;;
   96         esac

So, unless I borked something, curl should not be used for http or
https.

If you have a reproducer, I'm all eyes to test here and fix the
breakage.

Thanks for the feedback, much appreciated! 👍

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot