Re: [Buildroot] [PATCH 12/23] package/lynx: use http:// _SITE

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Peter Korsgaard <peter@korsgaard.com>
Cc: Mario Lang <mlang@blind.guru>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 12/23] package/lynx: use http:// _SITE
Date: Mon, 3 Jun 2024 11:21:19 +0200	[thread overview]
Message-ID: <Zl2LD1oI4LbDPlIH@landeda> (raw)
In-Reply-To: <20240603071726.532652-12-peter@korsgaard.com>

Peter, All,

On 2024-06-03 09:17 +0200, Peter Korsgaard spake thusly:
> The ftp server does not allow anonymous login, causing the download to fail:
> 
> wget --passive-ftp -nd -t 3 -O '/home/peko/source/buildroot/output-qt/build/.lynx2.8.9rel.1.tar.bz2.XlcdCK/output' 'ftp://ftp.invisible-island.net/lynx/tarballs/lynx2.8.9rel.1.tar.bz2'
> --2024-06-02 22:21:49--  ftp://ftp.invisible-island.net/lynx/tarballs/lynx2.8.9rel.1.tar.bz2
>            => ‘/home/peko/source/buildroot/output-qt/build/.lynx2.8.9rel.1.tar.bz2.XlcdCK/output’
> Resolving ftp.invisible-island.net (ftp.invisible-island.net)... 216.194.253.29
> Connecting to ftp.invisible-island.net (ftp.invisible-island.net)|216.194.253.29|:21... connected.
> Logging in as anonymous ...
> Login incorrect.
> 
> Luckily the tarball is also available over http://, so use that instead.

I've switched to https instead.

> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/lynx/lynx.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/lynx/lynx.mk b/package/lynx/lynx.mk
> index da57eb2601..41f9161f10 100644
> --- a/package/lynx/lynx.mk
> +++ b/package/lynx/lynx.mk
> @@ -6,7 +6,7 @@
>  
>  LYNX_VERSION = 2.8.9rel.1
>  LYNX_SOURCE = lynx$(LYNX_VERSION).tar.bz2
> -LYNX_SITE = ftp://ftp.invisible-island.net/lynx/tarballs
> +LYNX_SITE = http://invisible-mirror.net/archives/lynx/tarballs/

As disucssed on IRC:

    package/lynx/lynx.mk:60: *** LYNX_SITE (https://invisible-mirror.net/archives/lynx/tarballs/) cannot have a trailing slash. Stop.

So I dropped the trailing slash too.

Applied to master, thanks.

Regards,
Yann E. MORIN.

>  LYNX_PATCH = \
>  	https://salsa.debian.org/lynx-team/lynx/-/raw/debian/2.9.0dev.6-3_deb11u1/debian/patches/90_CVE-2021-38165.patch
>  # 90_CVE-2021-38165.patch
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot