All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>
Cc: gregkh@linuxfoundation.org, dmitry.baryshkov@linaro.org,
	jthies@google.com, bleung@chromium.org,
	abhishekpandit@chromium.org, saranya.gopal@intel.com, lk@c--e.de,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	pmalani@chromium.org
Subject: Re: [PATCH 1/2] usb: typec: ucsi: Add new capability bits
Date: Mon, 3 Jun 2024 13:09:56 +0300	[thread overview]
Message-ID: <Zl2WdKqjQXVyQ6O9@kuha.fi.intel.com> (raw)
In-Reply-To: <20240524105837.15342-2-diogo.ivo@tecnico.ulisboa.pt>

On Fri, May 24, 2024 at 11:58:20AM +0100, Diogo Ivo wrote:
> Newer UCSI versions defined additional optional capability bits. Add
> their definitions.
> 
> Signed-off-by: Diogo Ivo <diogo.ivo@tecnico.ulisboa.pt>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/ucsi/ucsi.h | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index e70cf5b15562..ca4a879d9606 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -225,7 +225,13 @@ struct ucsi_capability {
>  #define UCSI_CAP_CABLE_DETAILS			BIT(5)
>  #define UCSI_CAP_EXT_SUPPLY_NOTIFICATIONS	BIT(6)
>  #define UCSI_CAP_PD_RESET			BIT(7)
> -#define UCSI_CAP_GET_PD_MESSAGE		BIT(8)
> +#define UCSI_CAP_GET_PD_MESSAGE			BIT(8)
> +#define UCSI_CAP_GET_ATTENTION_VDO		BIT(9)
> +#define UCSI_CAP_FW_UPDATE_REQUEST		BIT(10)
> +#define UCSI_CAP_NEGOTIATED_PWR_LEVEL_CHANGE	BIT(11)
> +#define UCSI_CAP_SECURITY_REQUEST		BIT(12)
> +#define UCSI_CAP_SET_RETIMER_MODE		BIT(13)
> +#define UCSI_CAP_CHUNKING_SUPPORT		BIT(14)
>  	u8 reserved_1;
>  	u8 num_alt_modes;
>  	u8 reserved_2;
> -- 
> 2.45.1

-- 
heikki

  reply	other threads:[~2024-06-03 10:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-24 10:58 [PATCH 0/2] usb: typec: ucsi: Update optional notifications for UCSI v2.0 Diogo Ivo
2024-05-24 10:58 ` [PATCH 1/2] usb: typec: ucsi: Add new capability bits Diogo Ivo
2024-06-03 10:09   ` Heikki Krogerus [this message]
2024-05-24 10:58 ` [PATCH 2/2] usb: typec: ucsi: Enable UCSI v2.0 notifications Diogo Ivo
2024-05-24 15:28   ` kernel test robot
2024-05-24 15:38   ` kernel test robot
2024-05-24 20:31   ` Dmitry Baryshkov
2024-06-03 10:10   ` Heikki Krogerus
2024-05-24 20:30 ` [PATCH 0/2] usb: typec: ucsi: Update optional notifications for UCSI v2.0 Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zl2WdKqjQXVyQ6O9@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=abhishekpandit@chromium.org \
    --cc=bleung@chromium.org \
    --cc=diogo.ivo@tecnico.ulisboa.pt \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jthies@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lk@c--e.de \
    --cc=pmalani@chromium.org \
    --cc=saranya.gopal@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.