From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
Eric Blake <eblake@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 1/4] qom: allow to mark objects (including devices) as deprecated.
Date: Mon, 3 Jun 2024 12:42:09 +0100 [thread overview]
Message-ID: <Zl2sEb27q_guGzyM@redhat.com> (raw)
In-Reply-To: <20240530112718.1752905-2-kraxel@redhat.com>
On Thu, May 30, 2024 at 01:27:14PM +0200, Gerd Hoffmann wrote:
> Add deprecation_note field (string) to ObjectClass.
> Add deprecated bool to ObjectTypeInfo, report in 'qom-list-types'.
> Print the note when listing devices via '-device help'.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> include/qom/object.h | 1 +
> qom/qom-qmp-cmds.c | 4 ++++
> system/qdev-monitor.c | 5 +++++
> qapi/qom.json | 4 +++-
> 4 files changed, 13 insertions(+), 1 deletion(-)
I replied to v1 before noticing your v2, so see my comment there
about printing a warning on stderr when creating an instance.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-06-03 11:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 11:27 [PATCH v2 0/4] allow to deprecate objects and devices Gerd Hoffmann
2024-05-30 11:27 ` [PATCH v2 1/4] qom: allow to mark objects (including devices) as deprecated Gerd Hoffmann
2024-05-30 12:42 ` Eric Blake
2024-06-03 11:42 ` Daniel P. Berrangé [this message]
2024-05-30 11:27 ` [PATCH v2 2/4] usb: add config options for the hub and hid devices Gerd Hoffmann
2024-06-03 15:12 ` Philippe Mathieu-Daudé
2024-05-30 11:27 ` [PATCH v2 3/4] usb/hub: deprecate, don't build by default Gerd Hoffmann
2024-05-30 11:27 ` [PATCH v2 4/4] vga/cirrus: " Gerd Hoffmann
2024-05-30 11:40 ` BALATON Zoltan
2024-05-30 12:22 ` Mark Cave-Ayland
2024-05-30 14:04 ` Gerd Hoffmann
2024-06-03 11:40 ` Daniel P. Berrangé
2024-06-03 11:49 ` Peter Maydell
2024-06-03 15:25 ` Philippe Mathieu-Daudé
2024-06-05 7:32 ` Gerd Hoffmann
2024-06-05 8:33 ` Daniel P. Berrangé
2024-06-04 6:50 ` Mark Cave-Ayland
2024-06-04 8:05 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl2sEb27q_guGzyM@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.