From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 286F5C25B75 for ; Mon, 3 Jun 2024 13:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VVNZP64YFlsXSQ9Ja1ILItMb+Z1WkCOvVik7FQsjAdc=; b=QfiW+f0zf27mfS iI1j3hPHqQiyoc1Drn6flQ+I7ykrr8ey4F78+dC/Rwe7d0N65Z7foouNFyNrbkSivTke0wtJ14uZI 16eelyhY0NTQm5Rz+BOPK+ZUfZZzT0/gxS78VUUYQlpzdvYq4zOEGT1hKw+t5ebJ27VDKrB++amp5 FzCNDCU8WTTW8+rtyOa94XMg9dgnny5v3oZGcHrdVE+bFmrLUuKBv8/SvxS1Air0dbQYhGhyxwYoR lmi4VySfhTtZ1aFde4rvk2kyMUpUp9hlmtywrQvb3gL2jqUnptHEEOP8VNf+q2/DWM5zwPPSghajp MeJk2o8sYlm6u9s+E2bQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE7uL-0000000GwYk-06HU; Mon, 03 Jun 2024 13:39:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sE7uI-0000000GwWM-17mV for linux-arm-kernel@lists.infradead.org; Mon, 03 Jun 2024 13:39:28 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91D791042; Mon, 3 Jun 2024 06:39:47 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6538A3F64C; Mon, 3 Jun 2024 06:39:22 -0700 (PDT) Date: Mon, 3 Jun 2024 14:39:20 +0100 From: Sudeep Holla To: Geert Uytterhoeven Cc: Cristian Marussi , Sudeep Holla , Jassi Brar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mailbox: ARM_MHU_V3 should depend on ARM64 Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240603_063926_706295_E71C194A X-CRM114-Status: GOOD ( 28.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXkgMjksIDIwMjQgYXQgMDE6MzY6NDJQTSArMDIwMCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IEhpIENyaXN0aWFuLAo+Cj4gT24gV2VkLCBNYXkgMjksIDIwMjQgYXQgMTI6 MTPigK9QTSBDcmlzdGlhbiBNYXJ1c3NpCj4gPGNyaXN0aWFuLm1hcnVzc2lAYXJtLmNvbT4gd3Jv dGU6Cj4gPiBPbiBXZWQsIE1heSAyOSwgMjAyNCBhdCAwOTozMDo0NUFNICswMjAwLCBHZWVydCBV eXR0ZXJob2V2ZW4gd3JvdGU6Cj4gPiA+IFRoZSBBUk0gTUhVdjMgY29udHJvbGxlciBpcyBvbmx5 IHByZXNlbnQgb24gQVJNNjQgU29Dcy4gIEhlbmNlIGFkZCBhCj4gPiA+IGRlcGVuZGVuY3kgb24g QVJNNjQsIHRvIHByZXZlbnQgYXNraW5nIHRoZSB1c2VyIGFib3V0IHRoaXMgZHJpdmVyIHdoZW4K PiA+ID4gY29uZmlndXJpbmcgYSBrZXJuZWwgZm9yIGEgZGlmZmVyZW50IGFyY2hpdGVjdHVyZSB0 aGFuIEFSTTY0Lgo+ID4KPiA+IHRoZSBBUk02NCBkZXBlbmRlbmN5IHdhcyBkcm9wcGVkIG9uIHB1 cnBvc2UgYWZ0ZXIgYSBmZXcgaXRlcmF0aW9ucyBvZgo+ID4gdGhpcyBzZXJpZXMgc2luY2UsIGRl c3BpdGUgdGhpcyBiZWluZyBhbiBBUk0gSVAsIGl0IGhhcyByZWFsbHkgbm8gdGVjaG5pY2FsCj4g PiBkZXBlbmRlbmN5IG9uIEFSTSBhcmNoLCBub3QgZXZlbiB0aGUgdXN1YWwgb25lIG9uIEFSTSBB TUJBIGJ1cywgYmVpbmcgdGhpcyBhCj4gPiBwbGF0Zm9ybSBkcml2ZXIsIHNvIGl0IHNlZW1lZCBh biB1bmVlZGVkIGFydGlmaWNpYWwgcmVzdHJpY3Rpb24gdG8gaW1wb3NlLi4uCj4gPiAuLi5oYXZp bmcgc2FpZCB0aGF0LCBzdXJlbHkgbXkgbGl2ZSB0ZXN0aW5nIHdlcmUgcGVyZm9ybWVkIG9ubHkg b24gYXJtNjQgbW9kZWxzCj4gPiBhcyBvZiBub3cuCj4KPiBGb3IgdGhhdCwgd2UgaGF2ZSBDT01Q SUxFX1RFU1Q9eS4KPgo+ID4gU28sIEkgYW0gbm90IHNheWluZyB0aGF0IEkgYW0gYWdhaW5zdCB0 aGlzIHByb3Bvc2VkIGZpeCBidXQgd2hhdCBpcyB0aGUKPiA+IGlzc3VlIHRoYXQgaXMgdHJ5aW5n IHRvIHNvbHZlLCBoYXZlIHlvdSBzZWVuIGFueSBjb21waWxhdGlvbiBlcnJvciA/IG9yCj4gPiBp cyBpdCBqdXN0IHRvIGF2b2lkIHRoZSB1c2VyLXByb21wdGluZyA/Cj4KPiBJIGRpZCBub3Qgc2Vl IGEgY29tcGlsZSBlcnJvciAoSSBkaWRuJ3QgZW5hYmxlIGl0IG9uIGFueSBub24tQVJNCj4gcGxh dGZvcm0pLgo+Cj4gQnV0IGl0IGlzIHJhdGhlciBmdXRpbGUgdG8gYXNrIHRoZSB1c2VyIGFib3V0 ICh0aG91c2FuZHMgb2YpIGRyaXZlcnMKPiBmb3IgaGFyZHdhcmUgdGhhdCBjYW5ub3QgcG9zc2li bHkgYmUgcHJlc2VudCBvbiB0aGUgc3lzdGVtIGhlIGlzCj4gY29uZmlndXJpbmcgYSBrZXJuZWwg Zm9yLgoKSSBhbSBmaW5lIHdpdGggdGhpcyBmaXggYnV0IEkgaGF2ZSBzZWVuIHF1aXRlIG9wcG9z aXRlIGFyZ3VtZW50LiBUaGF0IGlzCm5vdCB0byBhZGQgZGVwZW5kZW5jeSBpZiBpdCBpcyBub3Qg c3RyaWN0bHkgcmVxdWlyZWQuCgpBbHNvIHNpbmNlIHlvdSBzdGF0ZSB0aGF0IHRoZSBmaXggaXMg dG8gYXZvaWQgdXNlcnMgb2Ygb3RoZXIgYXJjaHMgYmVpbmcKcG9zZWQgd2l0aCB0aGUgcXVlc3Rp b24gdGhhdCB0aGV5IG1heSBnZXQgYW5ub3llZCBvciBjYW4ndCBhbnN3ZXIsIEkKd29uZGVyIGlm IHRoZSByaWdodCBhcHByb2FjaCBpcyB0byBtYWtlIHRoaXMgZHJpdmVyIGRlZmF1bHQgIm4iIGlu c3RlYWQuCgpJIGRvbid0IGtub3cgd2hhdCBpcyB0aGUgcmlnaHQgb3IgcHJlZmVycmVkIGFwcHJv YWNoIGhlcmUuIEkgYW0gZmluZQplaXRoZXIgd2F5LgoKLS0KUmVnYXJkcywKU3VkZWVwCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5B45012DD94 for ; Mon, 3 Jun 2024 13:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717421966; cv=none; b=hZPHsNY3McIIidVVWmvkDHhmcALLsKcDyr8Hx0+21uWA7MaIhZjL8uBQaIoFlvo1vAiDMo3ubcge9bVbwxZqC8ZGwtdxgf9I+V6V0MeBWybnB86FhUkssmVRuQZoJcOqNvvbHnFQ3/LTS0Yq49RL2FlIm9fXo/mD0qMkARBytts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717421966; c=relaxed/simple; bh=OahMZUYoVHVoUKzOotRrQHjhatSUK3OGMQ0LIAqYYMQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=d91cmnI1I9bxBBVkyDAQZcpwi0a27AiFyQlg976X/PgXZz+BX8n8h6ClhQdkpOUDUWR9z7lPDQKZjlBWRQpLRVx0eQ33N1VeQa9ubwRkilZu5Qi6SHa0tteANMIG0AaluaxT+aKon109sVZbwWPMzDRVnX71vm8LQC4qjxWEmgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 91D791042; Mon, 3 Jun 2024 06:39:47 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6538A3F64C; Mon, 3 Jun 2024 06:39:22 -0700 (PDT) Date: Mon, 3 Jun 2024 14:39:20 +0100 From: Sudeep Holla To: Geert Uytterhoeven Cc: Cristian Marussi , Sudeep Holla , Jassi Brar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mailbox: ARM_MHU_V3 should depend on ARM64 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, May 29, 2024 at 01:36:42PM +0200, Geert Uytterhoeven wrote: > Hi Cristian, > > On Wed, May 29, 2024 at 12:13 PM Cristian Marussi > wrote: > > On Wed, May 29, 2024 at 09:30:45AM +0200, Geert Uytterhoeven wrote: > > > The ARM MHUv3 controller is only present on ARM64 SoCs. Hence add a > > > dependency on ARM64, to prevent asking the user about this driver when > > > configuring a kernel for a different architecture than ARM64. > > > > the ARM64 dependency was dropped on purpose after a few iterations of > > this series since, despite this being an ARM IP, it has really no technical > > dependency on ARM arch, not even the usual one on ARM AMBA bus, being this a > > platform driver, so it seemed an uneeded artificial restriction to impose... > > ...having said that, surely my live testing were performed only on arm64 models > > as of now. > > For that, we have COMPILE_TEST=y. > > > So, I am not saying that I am against this proposed fix but what is the > > issue that is trying to solve, have you seen any compilation error ? or > > is it just to avoid the user-prompting ? > > I did not see a compile error (I didn't enable it on any non-ARM > platform). > > But it is rather futile to ask the user about (thousands of) drivers > for hardware that cannot possibly be present on the system he is > configuring a kernel for. I am fine with this fix but I have seen quite opposite argument. That is not to add dependency if it is not strictly required. Also since you state that the fix is to avoid users of other archs being posed with the question that they may get annoyed or can't answer, I wonder if the right approach is to make this driver default "n" instead. I don't know what is the right or preferred approach here. I am fine either way. -- Regards, Sudeep