From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D38FC25B75 for ; Mon, 3 Jun 2024 21:33:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 3BEE960A5B; Mon, 3 Jun 2024 21:33:53 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id OqLIUEpV4FXU; Mon, 3 Jun 2024 21:33:52 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 1EFD960A6A Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 1EFD960A6A; Mon, 3 Jun 2024 21:33:52 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 722891BF2FA for ; Mon, 3 Jun 2024 21:33:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5EA8E60A6A for ; Mon, 3 Jun 2024 21:33:50 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id nbSBWBEt-FyO for ; Mon, 3 Jun 2024 21:33:49 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=212.27.42.3; helo=smtp3-g21.free.fr; envelope-from=yann.morin.1998@free.fr; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 3248A60A5B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 3248A60A5B Received: from smtp3-g21.free.fr (smtp3-g21.free.fr [212.27.42.3]) by smtp3.osuosl.org (Postfix) with ESMTPS id 3248A60A5B for ; Mon, 3 Jun 2024 21:33:48 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8290:3800:e05a:3b8d:ff83:9629]) (Authenticated sender: yann.morin.1998@free.fr) by smtp3-g21.free.fr (Postfix) with ESMTPSA id D926413F86A; Mon, 3 Jun 2024 23:33:42 +0200 (CEST) Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Mon, 03 Jun 2024 23:33:42 +0200 Date: Mon, 3 Jun 2024 23:33:42 +0200 From: "Yann E. MORIN" To: yegorslists@googlemail.com Message-ID: References: <20240603134358.3504092-1-yegorslists@googlemail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240603134358.3504092-1-yegorslists@googlemail.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1717450426; bh=ahhJJhQiZdyAXI/t1dJweT5v38aX5si0TX9L5fXhK5s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EBIkZzsN0U+fL19Cr4F5CX8gml7WB5/qizdhaZJ93LTVEpXuXYm5WjWftr/nyd9q7 G3jYAame53XmVPeZlzeJJIWsoOD4t5jQt53qgLzRhwdX+cNpbX/HvKJ3mu0LSCgaR3 CAbsxXYVRQTIW9WAuQI2YRyZL11W3B7BGQlPMSdR8+JxvADoy/AG+ns7cWWx9X/OKt 3cKXCGIdWjgVBaGr72fcPO77yJZ9eEL/MNPqPe/PBdF8foJyA6d7LD0PTJSXO8XcXt DEmmlIjAwAx+1D506zMmSYym4mrw9O6KjTkEdcgFoviYUVPGZXq9HVNHGTCgIlRbYB ou3cAufUZWqPw== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dmarc=pass (p=none dis=none) header.from=free.fr X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=free.fr header.i=@free.fr header.a=rsa-sha256 header.s=smtp-20201208 header.b=EBIkZzsN Subject: Re: [Buildroot] [PATCH v3] package/ntp: fix build with GCC 14.x X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bernd Kuhls , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Yegor, All, On 2024-06-03 15:43 +0200, yegorslists--- via buildroot spake thusly: > From: Yegor Yefremov > > Fix pthread_detach() detection that is broken when building > with GCC 14.x: > > checking for pthread_kill... yes > checking for pthread_rwlock_destroy with ... yes > checking for pthread_detach with ... no > configure: error: could not locate pthread_detach() > make[1]: *** [package/pkg-generic.mk:273: > /home/user/buildroot/bsp-barebox/build/ntp-4.2.8p17/.stamp_configured] > Error 1 > make: *** [Makefile:82: _all] Error 2 > > Reference: https://bugs.ntp.org/show_bug.cgi?id=3926 > > Additionally, refresh patch 0002 to fix the offset of hunk 1. > > Signed-off-by: Yegor Yefremov Applied to master, thanks. Regards, Yann E. MORIN. > --- > Changes v1 -> v2: > - add upstream reference (Yann E. MORIN) > - rework 0002 refresh reason (Yann E. MORIN) > - add error log > > Changes v2 -> v3: > - add proper Upstream tag to the 0003-fix-pthread-detach-check.patch > file > > package/ntp/0002-ntp-syscalls-fallback.patch | 9 ++++--- > .../ntp/0003-fix-pthread-detach-check.patch | 26 +++++++++++++++++++ > 2 files changed, 31 insertions(+), 4 deletions(-) > create mode 100644 package/ntp/0003-fix-pthread-detach-check.patch > > diff --git a/package/ntp/0002-ntp-syscalls-fallback.patch b/package/ntp/0002-ntp-syscalls-fallback.patch > index 535fc93dfd..46704b9d3f 100644 > --- a/package/ntp/0002-ntp-syscalls-fallback.patch > +++ b/package/ntp/0002-ntp-syscalls-fallback.patch > @@ -8,10 +8,11 @@ Signed-off-by: James Knight > configure.ac | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > -diff --git a/configure.ac b/configure.ac > ---- a/configure.ac > -+++ b/configure.ac > -@@ -1523,11 +1523,11 @@ AC_CACHE_CHECK( > +Index: ntp-4.2.8p17/configure.ac > +=================================================================== > +--- ntp-4.2.8p17.orig/configure.ac > ++++ ntp-4.2.8p17/configure.ac > +@@ -1472,11 +1472,11 @@ AC_CACHE_CHECK( > [ntp_cv_var_ntp_syscalls], > [ > ntp_cv_var_ntp_syscalls=no > diff --git a/package/ntp/0003-fix-pthread-detach-check.patch b/package/ntp/0003-fix-pthread-detach-check.patch > new file mode 100644 > index 0000000000..894b422f2c > --- /dev/null > +++ b/package/ntp/0003-fix-pthread-detach-check.patch > @@ -0,0 +1,26 @@ > +fix pthread_detach check > + > +Upstream: https://bugs.ntp.org/show_bug.cgi?id=3926 > + > +Signed-off-by: Yegor Yefremov > +--- > + sntp/m4/openldap-thread-check.m4 | 6 ++---- > + 1 file changed, 2 insertions(+), 4 deletions(-) > + > +Index: ntp-4.2.8p17/sntp/m4/openldap-thread-check.m4 > +=================================================================== > +--- ntp-4.2.8p17.orig/sntp/m4/openldap-thread-check.m4 > ++++ ntp-4.2.8p17/sntp/m4/openldap-thread-check.m4 > +@@ -262,10 +262,8 @@ pthread_rwlock_t rwlock; > + dnl save the flags > + AC_LINK_IFELSE([AC_LANG_PROGRAM([[ > + #include > +-#ifndef NULL > +-#define NULL (void*)0 > +-#endif > +-]], [[pthread_detach(NULL);]])],[ol_cv_func_pthread_detach=yes],[ol_cv_func_pthread_detach=no]) > ++pthread_t thread; > ++]], [[pthread_detach(thread);]])],[ol_cv_func_pthread_detach=yes],[ol_cv_func_pthread_detach=no]) > + ]) > + > + if test $ol_cv_func_pthread_detach = no ; then > -- > 2.34.1 > > _______________________________________________ > buildroot mailing list > buildroot@buildroot.org > https://lists.buildroot.org/mailman/listinfo/buildroot -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot