From: Oscar Salvador <osalvador@suse.com>
To: David Hildenbrand <david@redhat.com>
Cc: Anastasia Belova <abelova@astralinux.ru>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] mm/memory_hotplug: prevent accessing by index=-1
Date: Mon, 3 Jun 2024 19:53:55 +0200 [thread overview]
Message-ID: <Zl4DM_4ll3gFnYLw@localhost.localdomain> (raw)
In-Reply-To: <3c2b1b1e-c9b3-442e-8f7b-5c7518d3fbdb@redhat.com>
On Mon, Jun 03, 2024 at 06:07:39PM +0200, David Hildenbrand wrote:
> pgdat is never dereferenced when "nid == NUMA_NO_NODE".
Right.
> NODE_DATA is defined as
>
> arch/arm64/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)])
> arch/loongarch/include/asm/mmzone.h:#define NODE_DATA(nid) (node_data[(nid)])
> arch/mips/include/asm/mach-ip27/mmzone.h:#define NODE_DATA(n) (&__node_data[(n)]->pglist)
All look fine, but mips.
Is it not dangerous to try to derefence &__node_data[-1]->pglist?
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2024-06-03 17:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 11:28 [PATCH] mm/memory_hotplug: prevent accessing by index=-1 Anastasia Belova
2024-06-03 16:07 ` David Hildenbrand
2024-06-03 17:53 ` Oscar Salvador [this message]
2024-06-03 17:58 ` David Hildenbrand
2024-06-03 19:54 ` Fedor Pchelkin
2024-06-03 20:15 ` David Hildenbrand
2024-06-06 8:06 ` [PATCH v2] " Anastasia Belova
2024-06-06 8:13 ` David Hildenbrand
2024-06-07 7:34 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl4DM_4ll3gFnYLw@localhost.localdomain \
--to=osalvador@suse.com \
--cc=abelova@astralinux.ru \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.