All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jianguo Wu <wujianguo106@163.com>
Cc: netdev <netdev@vger.kernel.org>,
	contact@proelbtn.com, David Ahern <dsahern@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] seg6: fix parameter passing when calling NF_HOOK() in End.DX4 and End.DX6 behaviors
Date: Mon, 3 Jun 2024 21:23:05 +0200	[thread overview]
Message-ID: <Zl4YGQ3pqEobNTAl@calendula> (raw)
In-Reply-To: <2a78f16a-0ff5-46bf-983b-9ab038f5a5cd@163.com>

Hi,

On Thu, May 30, 2024 at 03:43:38PM +0800, Jianguo Wu wrote:
> From: Jianguo Wu <wujianguo@chinatelecom.cn>
> 
> input_action_end_dx4() and input_action_end_dx6() call NF_HOOK() for PREROUTING hook,
> for PREROUTING hook, we should passing a valid indev, and a NULL outdev to NF_HOOK(),
> otherwise may trigger a NULL pointer dereference, as below:

Could you also add a selftest to improve coverage of this infrastructure?

Thanks.

  parent reply	other threads:[~2024-06-03 19:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-30  7:43 [PATCH net-next] seg6: fix parameter passing when calling NF_HOOK() in End.DX4 and End.DX6 behaviors Jianguo Wu
2024-06-03 18:21 ` Simon Horman
2024-06-04  6:33   ` Jianguo Wu
2024-06-03 19:23 ` Pablo Neira Ayuso [this message]
2024-06-04  6:34   ` Jianguo Wu
2024-06-04  9:14     ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zl4YGQ3pqEobNTAl@calendula \
    --to=pablo@netfilter.org \
    --cc=contact@proelbtn.com \
    --cc=dsahern@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=wujianguo106@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.