From: Sean Christopherson <seanjc@google.com>
To: Manali Shukla <manali.shukla@amd.com>
Cc: kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
pbonzini@redhat.com, shuah@kernel.org, nikunj@amd.com,
thomas.lendacky@amd.com
Subject: Re: [PATCH] KVM: selftest: Add family and model check for zen4 in PMU filter test
Date: Mon, 3 Jun 2024 15:17:16 -0700 [thread overview]
Message-ID: <Zl5A7GuqAKCZ7I5M@google.com> (raw)
In-Reply-To: <7a5ffaa2-9b18-4700-b4b6-da414333d894@amd.com>
On Tue, May 28, 2024, Manali Shukla wrote:
> On 5/1/2024 9:02 PM, Sean Christopherson wrote:
> > On Wed, May 01, 2024, Manali Shukla wrote:
> >> PMU event filter test fails on zen4 architecture because of
> >> unavailability of family and model check for zen4 in use_amd_pmu().
> >> So, add family and model check for zen4 architecture in use_amd_pmu().
> >
> > Is there a less ugly way to detect that 0xc2,0 == "branch instructions retired"?
> > E.g. can we instead check for v2 PMU support, or are there no guarantees going
> > forward? Pivoting on FMS is so painful :-(
>
> We have confirmed with the hardware team that 0xc2,0 == "branch instructions retired"
> is always true going forward, we intend to maintain backward compatibility for branch
> instruction retired. Since event 0xc2 is supported on all currently released F17h+
> processors as branch instructions retired, we can check for "family >= 0x17" for all
> Zen and its successors instead of checking them individually in pmu_event_filter_test.c.
Can you send a patch for this? Please :-)
next prev parent reply other threads:[~2024-06-03 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-01 15:24 [PATCH] KVM: selftest: Add family and model check for zen4 in PMU filter test Manali Shukla
2024-05-01 15:32 ` Sean Christopherson
2024-05-28 5:31 ` Manali Shukla
2024-06-03 22:17 ` Sean Christopherson [this message]
2024-06-05 5:23 ` Manali Shukla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl5A7GuqAKCZ7I5M@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=manali.shukla@amd.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=shuah@kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.