From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Mon, 3 Jun 2024 17:23:06 -0700 Subject: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging In-Reply-To: References: <20240529180510.2295118-3-jthoughton@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jun 03, 2024, James Houghton wrote: > On Mon, Jun 3, 2024 at 4:03?PM Sean Christopherson wrote: > > But before we do that, I think we need to perform due dilegence (or provide data) > > showing that having KVM take mmu_lock for write in the "fast only" API provides > > better total behavior. I.e. that the additional accuracy is indeed worth the cost. > > That sounds good to me. I'll drop the Kconfig. I'm not really sure > what to do about the self-test, but that's not really all that > important. Enable it only on architectures+setups that are guaranteed to implement the fast-only API? E.g. on x86, it darn well better be active if the TDP MMU is enabled. If the test fails because that doesn't hold true, then we _want_ the failure. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFDC22119 for ; Tue, 4 Jun 2024 00:23:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717460590; cv=none; b=Ojm8iDYkF8tEOkqdvWjPJGl8pScR5HL7ljbda9b3c1kgvKC0uBQ9Eh8jGb25w4SNvaYaK7kjhKRW4Ewi8s/WhBTaEtgo0woAcuKtsuZ4PWbWDdTlwjAig/qRGCKcLh1GawztfXUjvTpF3NLUZr8FHGbod92DWrMaCtj+cAOtgSQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717460590; c=relaxed/simple; bh=ouvtVl7K0PAyNCf/CqS8kHiqugncCwG8s3P79l84eTI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=PYSuFlcShJydTgXpDwo8K4p4mFqMIuCNhNjlZigardY0dOudge8rC4engaM9PI6BtAgnSR3kMir39wbJEuuj51W00JKs/xWmuFD/7mq+NjvpZZcVUK2ctlVET+bLjMbOSfmzL0p9fOk1z0zZIq9Yd8DaW5GExCanYDByTs1lolc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UojUQ2BH; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UojUQ2BH" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-627e9a500faso80793717b3.1 for ; Mon, 03 Jun 2024 17:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717460588; x=1718065388; darn=lists.linux.dev; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=HRuXM8qP8LdDvX6fn1r8scesSI9q9pU2JyFDr4cXXhA=; b=UojUQ2BH9v5rp6hRT9wq3SvE+B0LcgiWW6LvCxc0Ly1+6zwA6VDcDgvV66091vNOKo cZ7mk+4AvWo/STdfaTA+2iBbVfHlrUjnQNvIgOK+Y2SsDdISsj8QlibEVb87lwhoabWC 5N7O7p8hF9jWTM63j2+Rbi2OD2AUbz4WJyK0/CgUKLXVQ6sUzV53XnOVkU2XjANDyZ/L BRvhfRxisNIw2RunD0GwWnvLxHKCw3GiRSf77V2vVZmXBFI2/gSEmC7nruh5AAsHzbyg 4Jo2ZC3nl8hEZp5kvDFjeJC0+2wJ+lCMp2SxtC033hWZX3dpjTqw0DK99DOPR4Ysmxue Hhmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717460588; x=1718065388; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HRuXM8qP8LdDvX6fn1r8scesSI9q9pU2JyFDr4cXXhA=; b=kkPWPHsLGc4KymqpJHvsPDDeTGODhR+97NioODmo7GTnzNH/O72riGRpl/h+dmlc0O DQK2W+2Xnu/NhbWlDwu4uyMAuW+6ZV+XJWz4ZaZjcmsQhyZUbIaCZjGA58SrYvSBPd3l lNPrTkaBXxrQWpHBN2ixUlW5FQgW7OnpXNazX6o4Gmxu2leWZRgroYpJ21kge9WZI8Qq T9RHlDEmS6k9HWaRigMyYD1rEQ9Sc2EuISjw/TzkXIx4QCXJLLRY+5sevaJ8i/BJrmhb GNCqj1WCxDxmLiNHJh8ZVxkoyxbMYRm/fimLCJBASc3qnHEf3CG5oClrzfZqIg0CZm+Y SRcw== X-Forwarded-Encrypted: i=1; AJvYcCWrvPZGRjQVbHVRqzSxC5XiQQmxSBEnsCYS0esUPJr98yxMvv3jePJPYWnf/dh+eE9FTe9nOKLssCoV+EzJRw95udCfrsSL X-Gm-Message-State: AOJu0Ywz23UJM8VQP9hLBS5RbaI1QphQyXyOXogimCwaHiTu5TT12Ocy xkG7GGjoWqjWH8KFzC56R8MYZvPkVybrtgXk0zupPj9JVjt5QhVXDf0ngqrzmaK3E5QikOqOGx4 rtQ== X-Google-Smtp-Source: AGHT+IEk24C6d/QoiBbCyIExMW7OdPZLjaBEK4ZPTTj/IX3O1NfqjnOFuoealUEhXp84xV+hhBOGjvPTh7s= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:707:b0:dfa:ba40:6f43 with SMTP id 3f1490d57ef6-dfaba407295mr112473276.2.1717460587664; Mon, 03 Jun 2024 17:23:07 -0700 (PDT) Date: Mon, 3 Jun 2024 17:23:06 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240529180510.2295118-3-jthoughton@google.com> Message-ID: Subject: Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging From: Sean Christopherson To: James Houghton Cc: Yu Zhao , Andrew Morton , Paolo Bonzini , Albert Ou , Ankit Agrawal , Anup Patel , Atish Patra , Axel Rasmussen , Bibo Mao , Catalin Marinas , David Matlack , David Rientjes , Huacai Chen , James Morse , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Oliver Upton , Palmer Dabbelt , Paul Walmsley , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Will Deacon , Zenghui Yu , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Mon, Jun 03, 2024, James Houghton wrote: > On Mon, Jun 3, 2024 at 4:03=E2=80=AFPM Sean Christopherson wrote: > > But before we do that, I think we need to perform due dilegence (or pro= vide data) > > showing that having KVM take mmu_lock for write in the "fast only" API = provides > > better total behavior. I.e. that the additional accuracy is indeed wor= th the cost. >=20 > That sounds good to me. I'll drop the Kconfig. I'm not really sure > what to do about the self-test, but that's not really all that > important. Enable it only on architectures+setups that are guaranteed to implement the fast-only API? E.g. on x86, it darn well better be active if the TDP MMU i= s enabled. If the test fails because that doesn't hold true, then we _want_ = the failure. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A49DBC25B78 for ; Tue, 4 Jun 2024 00:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=X/3FSQZCdWcbHT41gWm7rUd4FcBIsupSCVKVHW+IcEM=; b=VX1cW53Cl5ev+rP7UBMqoEoa9Z +mZWGQ4+SKzM2fJXLXsCJ6Pcr52OXadfvFsMu45ax4tm+s/L7FZq/yYJ4fcyNYZ5QwYwr1RcgrNfc /Q1IEEtg1v248DGj0yGn93U/smZ33mBxuNtO3P1R98hh535yArtb6wc2gs33FfqdJ7BVVMYVmzdpX wIXEcWeCoiB9WpPzIkPJVFedRbFkhKcfrijn9U+c/Jb6hHzZQDI1hCktOU3gjq+WprTY9CDJKIXPO vBuYlml+ASfEzQzUL9AKqDLCxOsY+yZ9U/nPZKDWAy0LqkwyZBoAn63IqD0JT8Dd82XTXFzue2jwI vITwwcUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEHxK-00000000j7x-2AZE; Tue, 04 Jun 2024 00:23:14 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEHxG-00000000j4z-05rI for linux-riscv@lists.infradead.org; Tue, 04 Jun 2024 00:23:12 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-dfa79b84623so5522275276.2 for ; Mon, 03 Jun 2024 17:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717460588; x=1718065388; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=HRuXM8qP8LdDvX6fn1r8scesSI9q9pU2JyFDr4cXXhA=; b=NCK+gAO8stENmQsjYQNejenTso0mPsUUrIcGxIy70mfYETQIJoiKU0aWy7JDn33qyk +X34ppOQOeKcNg22+E5m3UvmhosDwMNTCGJEunmab24MksUfOb5zj1pcozPRUPdiqB2k 77lIejimnzhmXB3/uocik92DeU8FmgbjdHxKmG7OprTQ9UqLNhbubhUizYo/0wKFFafG wixxBLscTBBVBn6dh/9QUOp5GY4DyMeMK4tv/vWAUcmLRk9/roJVJyeRmvt5gfy4vaLx L2sjMoXI4iV9vWAd0aLkMKUcB/8J1rManezmdd4uX7r2azBik+fa/kEj58D4zdsomhoj 9Y3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717460588; x=1718065388; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HRuXM8qP8LdDvX6fn1r8scesSI9q9pU2JyFDr4cXXhA=; b=eIt43vKA8FP0LMeZX8B2TVH3htX+C78ixG1B1Bd1pgYcBKYrtdzFxOMz8h/lYnROjk 75TtrThoeUBJtPO/Hd3QuTlGumWzB3hosB676bB4KS4ZEXNDNJ/lCipd53wvognIS2rV PwKswlMe2C/cA5YmaGrziG/pkFAgJJdhKCIceHVx9DrOo6LbvYSbai+E6V+8mUHoyzFM C3Kh4CWKqzXmJvmlC6zZy88SW5Nv+6xLfnZ4BFTAz0YHxkRlDnBnOJHGNvVJSKiD4eOS sY0db/HW/wBaYf2P2u5+xpafs+WsaFxqx1r0zmIdOqloSBA6jKJhohw3hKEMuUDXWaCD HHYA== X-Forwarded-Encrypted: i=1; AJvYcCVcE+FBm9rDx2pPVwVe9h6GN9ZmR9DrBK+Dti6ikUf9Wzs8654EjOO+OScHz4x1pexfsrOD4GmCLXj31N4lw5u+4I/dsNlagRCjBrz36Pxi X-Gm-Message-State: AOJu0Yyvu3eLGgQjBKof2CaDcFx5FJNgDl39RxHqiXnecQqIbKqexq+c eBp+/VXOrJ+78gLHLO1YI2K4Qwq8BomsfMibVDE2lczxvLrKvqjSvNlGMAfz8djzWW8iMdhqVQe 2cw== X-Google-Smtp-Source: AGHT+IEk24C6d/QoiBbCyIExMW7OdPZLjaBEK4ZPTTj/IX3O1NfqjnOFuoealUEhXp84xV+hhBOGjvPTh7s= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:707:b0:dfa:ba40:6f43 with SMTP id 3f1490d57ef6-dfaba407295mr112473276.2.1717460587664; Mon, 03 Jun 2024 17:23:07 -0700 (PDT) Date: Mon, 3 Jun 2024 17:23:06 -0700 In-Reply-To: Mime-Version: 1.0 References: <20240529180510.2295118-3-jthoughton@google.com> Message-ID: Subject: Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging From: Sean Christopherson To: James Houghton Cc: Yu Zhao , Andrew Morton , Paolo Bonzini , Albert Ou , Ankit Agrawal , Anup Patel , Atish Patra , Axel Rasmussen , Bibo Mao , Catalin Marinas , David Matlack , David Rientjes , Huacai Chen , James Morse , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Oliver Upton , Palmer Dabbelt , Paul Walmsley , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Will Deacon , Zenghui Yu , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240603_172310_082758_06BED63C X-CRM114-Status: GOOD ( 13.53 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMDMsIDIwMjQsIEphbWVzIEhvdWdodG9uIHdyb3RlOgo+IE9uIE1vbiwgSnVu IDMsIDIwMjQgYXQgNDowM+KAr1BNIFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5qY0Bnb29nbGUu Y29tPiB3cm90ZToKPiA+IEJ1dCBiZWZvcmUgd2UgZG8gdGhhdCwgSSB0aGluayB3ZSBuZWVkIHRv IHBlcmZvcm0gZHVlIGRpbGVnZW5jZSAob3IgcHJvdmlkZSBkYXRhKQo+ID4gc2hvd2luZyB0aGF0 IGhhdmluZyBLVk0gdGFrZSBtbXVfbG9jayBmb3Igd3JpdGUgaW4gdGhlICJmYXN0IG9ubHkiIEFQ SSBwcm92aWRlcwo+ID4gYmV0dGVyIHRvdGFsIGJlaGF2aW9yLiAgSS5lLiB0aGF0IHRoZSBhZGRp dGlvbmFsIGFjY3VyYWN5IGlzIGluZGVlZCB3b3J0aCB0aGUgY29zdC4KPiAKPiBUaGF0IHNvdW5k cyBnb29kIHRvIG1lLiBJJ2xsIGRyb3AgdGhlIEtjb25maWcuIEknbSBub3QgcmVhbGx5IHN1cmUK PiB3aGF0IHRvIGRvIGFib3V0IHRoZSBzZWxmLXRlc3QsIGJ1dCB0aGF0J3Mgbm90IHJlYWxseSBh bGwgdGhhdAo+IGltcG9ydGFudC4KCkVuYWJsZSBpdCBvbmx5IG9uIGFyY2hpdGVjdHVyZXMrc2V0 dXBzIHRoYXQgYXJlIGd1YXJhbnRlZWQgdG8gaW1wbGVtZW50IHRoZQpmYXN0LW9ubHkgQVBJPyAg RS5nLiBvbiB4ODYsIGl0IGRhcm4gd2VsbCBiZXR0ZXIgYmUgYWN0aXZlIGlmIHRoZSBURFAgTU1V IGlzCmVuYWJsZWQuICBJZiB0aGUgdGVzdCBmYWlscyBiZWNhdXNlIHRoYXQgZG9lc24ndCBob2xk IHRydWUsIHRoZW4gd2UgX3dhbnRfIHRoZQpmYWlsdXJlLgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4 LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B9B3C25B78 for ; Tue, 4 Jun 2024 00:23:57 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=T1rlt0WU; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VtWY73Hnlz3dSG for ; Tue, 4 Jun 2024 10:23:55 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=T1rlt0WU; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::1149; helo=mail-yw1-x1149.google.com; envelope-from=3a15ezgykdnooa6jf8ckkcha.8kihejqtll8-9arheopo.kvh67o.knc@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VtWXJ1nVWz3clH for ; Tue, 4 Jun 2024 10:23:10 +1000 (AEST) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-627eb3fb46cso82394107b3.2 for ; Mon, 03 Jun 2024 17:23:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717460588; x=1718065388; darn=lists.ozlabs.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=HRuXM8qP8LdDvX6fn1r8scesSI9q9pU2JyFDr4cXXhA=; b=T1rlt0WUAazu+bGviD6zmA5HxNfUb6ntnzVIBfc77GoI/qu13oBslM3zgQ6LHo9xS1 +8bwbhOzutIFXypGnrF5Qq9dZdSc7E+Spwk6BKtW7Mw0PqKZvKCrvi+fFq9vf0yyF8U5 WlHXoCsVsDJT8R1qHFlhDpYP87k9PaWumcB67KWjePd0JUcAWvDOOPFTmWPyC4DSL9dm hw+O7iAz0SMC09wJH63jX6Une7kC5ulAqhrmPJuVU6Cr480ZouOqUSx5C22b55+xIpfK eDEWUNczqlJgTpmhtK1l8u+Xs6U4r/HiuKX35ICDFzL+iiS6Lz06YP5aWSFJh6rbdTqH paNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717460588; x=1718065388; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HRuXM8qP8LdDvX6fn1r8scesSI9q9pU2JyFDr4cXXhA=; b=VPbAYmeVBkN3xjhoi2deHhLqBpLGqXrLGoL82SdrNP4iF/oVEZITPPDGtqfVxVeO3T VaU09U0OKmAiaK11Xo106jr+vlzRc/lQVnIfsWfKPJpez9oqKc9G1JZ3mv6WqiklM5To RH62LqgU+tCxfogMuXOpPEJ6UT0FyidF9PQwjGDJ9Vd2qj6fXmArxu+OIa9izIkx7Lh1 k1uJ5Q4Pnm1eF4XW186eQkWcPWyOqZXECjlok7SSkeNbnZiB7PMzbKC6TiIXc2EFIGNq uRaz+rf7NbwX5AHeZLcr5jLTJzHLeuYBqMNij30ebl5M5G2zx7vlvpi7Aj6cepVIkv3z ATgg== X-Forwarded-Encrypted: i=1; AJvYcCUMT4k53GzvY1yMhuc2GrUjUtHsVGEUF7R55qgqEsb5Mq+H27rvnP63uN4GRk0wG+KN6/H1CHVEiMjkA1iXE5r9j0THksF5obQkifOUlQ== X-Gm-Message-State: AOJu0YxwNO04X0QvWn42DUYxjM119J9HPgXCs5vsV7rL2zneTF1PMJPN CgoawnX3KZD59blujFgOO0JAQ+reUKa6yLVG7iWkd6/lHJUtV5ZdMbV7KLwjLrif1TQ5ubiNWf+ b/Q== X-Google-Smtp-Source: AGHT+IEk24C6d/QoiBbCyIExMW7OdPZLjaBEK4ZPTTj/IX3O1NfqjnOFuoealUEhXp84xV+hhBOGjvPTh7s= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:707:b0:dfa:ba40:6f43 with SMTP id 3f1490d57ef6-dfaba407295mr112473276.2.1717460587664; Mon, 03 Jun 2024 17:23:07 -0700 (PDT) Date: Mon, 3 Jun 2024 17:23:06 -0700 In-Reply-To: Mime-Version: 1.0 References: <20240529180510.2295118-3-jthoughton@google.com> Message-ID: Subject: Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging From: Sean Christopherson To: James Houghton Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, Catalin Marinas , Atish Patra , linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org, Raghavendra Rao Ananta , linux-riscv@lists.infradead.org, Shuah Khan , Yu Zhao , Jonathan Corbet , Anup Patel , Huacai Chen , David Rientjes , Zenghui Yu , Axel Rasmussen , linux-mips@vger.kernel.org, Albert Ou , Ryan Roberts , Will Deacon , Suzuki K Poulose , Shaoqin Huang , Nicholas Piggin , Bibo Mao , loongarch@lists.linux.dev, Paul Walmsley , David Matlack , Palmer Dabbelt , linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, Ankit Agrawal , Oliver Upton , James Morse , kvm-riscv@lists.infradead.org, Marc Zyngier , Paolo Bonzini , Andrew Morton , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Jun 03, 2024, James Houghton wrote: > On Mon, Jun 3, 2024 at 4:03=E2=80=AFPM Sean Christopherson wrote: > > But before we do that, I think we need to perform due dilegence (or pro= vide data) > > showing that having KVM take mmu_lock for write in the "fast only" API = provides > > better total behavior. I.e. that the additional accuracy is indeed wor= th the cost. >=20 > That sounds good to me. I'll drop the Kconfig. I'm not really sure > what to do about the self-test, but that's not really all that > important. Enable it only on architectures+setups that are guaranteed to implement the fast-only API? E.g. on x86, it darn well better be active if the TDP MMU i= s enabled. If the test fails because that doesn't hold true, then we _want_ = the failure. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE978C25B75 for ; Tue, 4 Jun 2024 00:23:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Ar+dmAIE/Z91j9KChdTw5gWKqOcSuce68XxoQLucyLA=; b=FHx3VXGZ26xoeIwNmMVC1UDaHX oawxS6UhWvUGXl0RbjBvd2SWRExTUXPIkf7CS/5Q4ITRsx9ny1oY+/F/Pf2dKP8QZ3OOhoj4wQ/2e TPHiBQAc6xJCDNo8L6CkEafF2hJJglvcQEGDbECwYTuhAYHKARtBI6UMhytaMFg9GRAleT5qCATV+ 0uWwS4sFBC72dtWsUgDVBNGSZlkb4YWk+k8TC7yEfQFx+nmSOfHsXnMaM2If2nzgqgkc5ojqIEZJ6 GmezNKGahnvZdbw9mImYMJqwHDfZzRQdn61KkzmxcwjV5VBX4zVQUBKN5dSQ+qR40loF5oDjy0Npc hGCP7FrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEHxH-00000000j6Z-44t8; Tue, 04 Jun 2024 00:23:12 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEHxF-00000000j50-3LQ3 for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 00:23:11 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-dfa73db88dcso5668613276.0 for ; Mon, 03 Jun 2024 17:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717460588; x=1718065388; darn=lists.infradead.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=HRuXM8qP8LdDvX6fn1r8scesSI9q9pU2JyFDr4cXXhA=; b=NCK+gAO8stENmQsjYQNejenTso0mPsUUrIcGxIy70mfYETQIJoiKU0aWy7JDn33qyk +X34ppOQOeKcNg22+E5m3UvmhosDwMNTCGJEunmab24MksUfOb5zj1pcozPRUPdiqB2k 77lIejimnzhmXB3/uocik92DeU8FmgbjdHxKmG7OprTQ9UqLNhbubhUizYo/0wKFFafG wixxBLscTBBVBn6dh/9QUOp5GY4DyMeMK4tv/vWAUcmLRk9/roJVJyeRmvt5gfy4vaLx L2sjMoXI4iV9vWAd0aLkMKUcB/8J1rManezmdd4uX7r2azBik+fa/kEj58D4zdsomhoj 9Y3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717460588; x=1718065388; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HRuXM8qP8LdDvX6fn1r8scesSI9q9pU2JyFDr4cXXhA=; b=P2zo2bToY9lofYPy3mgSZBTp3Iwx3ikWDUh1Rj1w3M3ihYPL/dO3M0+Ggcdo1S4ToT 3KTqNIuD0XEs4rTPjrjH9wkmfFVw1I5nMuHuZlyv+HkAVpnWyYgQsn+sGtUA0tguxD9f unyTH8TPNaHxxE9GPzvlUFKa0BxnTKcFxb9mtkMvzuSDpVj73B2m9EXTveFZwQDGPLP9 iL9PeBP0D57qA2PbPXWKbweMkH7Vf//Pbma6MlWiJHXAcASZufzOOibAcaJH/Zn+DMi5 lzoFgCd/SH52XAk2UUXVj2I1bYxNwEp/+j0sEyd79PdaCCpzFXJJ/l2IT1wGXPkKiEKx +KLQ== X-Forwarded-Encrypted: i=1; AJvYcCXpaFSGm5rA9iX8Kw9rj/ttMXQzj0ynxILmjzyBmP1aDgdZ1VXsSMQwWCiqXRzZgAvhFCNhL59rxFglctFCdBHQlDvpgYS/6INjwtGW7xwmRySDbhQ= X-Gm-Message-State: AOJu0YyfnEl5n9KdAgzes2Ha4CRZ3p+JDnBN+2WQxupTXvRMbtulTxyM EgwXN1EJAxMLSmER05/M3OcB6fjvt2wUp+KVrbEfSIfOvZoSjnJ0nmxXQ4csKebLIMNdFE37/5d RoQ== X-Google-Smtp-Source: AGHT+IEk24C6d/QoiBbCyIExMW7OdPZLjaBEK4ZPTTj/IX3O1NfqjnOFuoealUEhXp84xV+hhBOGjvPTh7s= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:707:b0:dfa:ba40:6f43 with SMTP id 3f1490d57ef6-dfaba407295mr112473276.2.1717460587664; Mon, 03 Jun 2024 17:23:07 -0700 (PDT) Date: Mon, 3 Jun 2024 17:23:06 -0700 In-Reply-To: Mime-Version: 1.0 References: <20240529180510.2295118-3-jthoughton@google.com> Message-ID: Subject: Re: [PATCH v4 2/7] mm: multi-gen LRU: Have secondary MMUs participate in aging From: Sean Christopherson To: James Houghton Cc: Yu Zhao , Andrew Morton , Paolo Bonzini , Albert Ou , Ankit Agrawal , Anup Patel , Atish Patra , Axel Rasmussen , Bibo Mao , Catalin Marinas , David Matlack , David Rientjes , Huacai Chen , James Morse , Jonathan Corbet , Marc Zyngier , Michael Ellerman , Nicholas Piggin , Oliver Upton , Palmer Dabbelt , Paul Walmsley , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Shuah Khan , Suzuki K Poulose , Tianrui Zhao , Will Deacon , Zenghui Yu , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240603_172309_863089_B9DD6515 X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMDMsIDIwMjQsIEphbWVzIEhvdWdodG9uIHdyb3RlOgo+IE9uIE1vbiwgSnVu IDMsIDIwMjQgYXQgNDowM+KAr1BNIFNlYW4gQ2hyaXN0b3BoZXJzb24gPHNlYW5qY0Bnb29nbGUu Y29tPiB3cm90ZToKPiA+IEJ1dCBiZWZvcmUgd2UgZG8gdGhhdCwgSSB0aGluayB3ZSBuZWVkIHRv IHBlcmZvcm0gZHVlIGRpbGVnZW5jZSAob3IgcHJvdmlkZSBkYXRhKQo+ID4gc2hvd2luZyB0aGF0 IGhhdmluZyBLVk0gdGFrZSBtbXVfbG9jayBmb3Igd3JpdGUgaW4gdGhlICJmYXN0IG9ubHkiIEFQ SSBwcm92aWRlcwo+ID4gYmV0dGVyIHRvdGFsIGJlaGF2aW9yLiAgSS5lLiB0aGF0IHRoZSBhZGRp dGlvbmFsIGFjY3VyYWN5IGlzIGluZGVlZCB3b3J0aCB0aGUgY29zdC4KPiAKPiBUaGF0IHNvdW5k cyBnb29kIHRvIG1lLiBJJ2xsIGRyb3AgdGhlIEtjb25maWcuIEknbSBub3QgcmVhbGx5IHN1cmUK PiB3aGF0IHRvIGRvIGFib3V0IHRoZSBzZWxmLXRlc3QsIGJ1dCB0aGF0J3Mgbm90IHJlYWxseSBh bGwgdGhhdAo+IGltcG9ydGFudC4KCkVuYWJsZSBpdCBvbmx5IG9uIGFyY2hpdGVjdHVyZXMrc2V0 dXBzIHRoYXQgYXJlIGd1YXJhbnRlZWQgdG8gaW1wbGVtZW50IHRoZQpmYXN0LW9ubHkgQVBJPyAg RS5nLiBvbiB4ODYsIGl0IGRhcm4gd2VsbCBiZXR0ZXIgYmUgYWN0aXZlIGlmIHRoZSBURFAgTU1V IGlzCmVuYWJsZWQuICBJZiB0aGUgdGVzdCBmYWlscyBiZWNhdXNlIHRoYXQgZG9lc24ndCBob2xk IHRydWUsIHRoZW4gd2UgX3dhbnRfIHRoZQpmYWlsdXJlLgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=