From: Zhao Liu <zhao1.liu@intel.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/core: Rename CpuTopology to CPUTopology
Date: Tue, 4 Jun 2024 12:15:34 +0800 [thread overview]
Message-ID: <Zl6U5n+QeEAiCBBv@intel.com> (raw)
In-Reply-To: <87sexus0m0.fsf@pond.sub.org>
On Mon, Jun 03, 2024 at 01:54:15PM +0200, Markus Armbruster wrote:
> Date: Mon, 03 Jun 2024 13:54:15 +0200
> From: Markus Armbruster <armbru@redhat.com>
> Subject: Re: [PATCH] hw/core: Rename CpuTopology to CPUTopology
>
> Zhao Liu <zhao1.liu@intel.com> writes:
>
> > Use CPUTopology to honor the generic style of CPU capitalization
> > abbreviations.
> >
> > Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
>
> Is CPUFoo really more common than CpuFoo? It isn't in the qapi
> schema...
Hi Markus, do you think this style needs to be standardized?
All-caps cases, like the widely used CPUState.
And the common structures declared in include/qemu/typedefs.h, are all
using CPU, not Cpu...
If you feel this is necessary, I'd be happy to help more places change
their names to standardize their style...
next prev parent reply other threads:[~2024-06-04 4:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 13:18 [PATCH] hw/core: Rename CpuTopology to CPUTopology Zhao Liu
2024-06-03 11:54 ` Markus Armbruster
2024-06-04 4:15 ` Zhao Liu [this message]
2024-06-04 5:29 ` Markus Armbruster
2024-06-04 6:36 ` Zhao Liu
2024-06-04 8:38 ` Markus Armbruster
2024-06-19 14:49 ` Zhao Liu
2024-06-19 14:53 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zl6U5n+QeEAiCBBv@intel.com \
--to=zhao1.liu@intel.com \
--cc=armbru@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.