Re: [Buildroot] [PATCH] package/libzenoh-c: add GLIBC and aarch64, x86_64 and arm dependencies

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Michel, All,

On 2024-06-04 07:43 +0000, Michel Alex spake thusly:
> zenoh-c only have support for following targets:
> aarch64-unknown-linux-gnu, x86_64-unknown-linux-gnu, arm-unknown-linux-gnueabi
[--SNIP--]
> diff --git a/package/libzenoh-c/Config.in b/package/libzenoh-c/Config.in
> index d22807c047..06e56c0879 100644
> --- a/package/libzenoh-c/Config.in
> +++ b/package/libzenoh-c/Config.in
> @@ -1,6 +1,17 @@
> +config BR2_PACKAGE_LIBZENOH_C_ARCH_SUPPORTS
> +	bool
> +	default y if BR2_aarch64
> +	default y if BR2_arm
> +	default y if BR2_x86_64
> +	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> +	depends on BR2_TOOLCHAIN_USES_GLIBC

The dependency on the C library should not be in the _ARCH_SUPPORTS
symbol. Indeed, the architecture is something the user can't changem
it's what it is, but the C library is software, so the user has the
option to choose.

So, when the architecture is not supported, there is no reason to show
the main symbol, and there is no reason to show the comment either. But
when the architecture is supported, we want to tell the user the have
the option of changing the C library to use that package. That's why in
my quickly shipped code snippet in my previous mail, the dependency on
the C library was not added to _ARCH_SUPPORTS, but to the main symbol
and, as an inverted test, to the comment.

Can you fix and respin, please?

Regards,
Yann E. MORIN.

> +comment "libzenoh-c needs a glibc toolchain and supports only aarch64, x86_64 and arm architectures"
> +	depends on !BR2_PACKAGE_LIBZENOH_C_ARCH_SUPPORTS
> +
>  config BR2_PACKAGE_LIBZENOH_C
>  	bool "libzenoh-c"
> -	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_LIBZENOH_C_ARCH_SUPPORTS
>  	select BR2_PACKAGE_HOST_RUSTC
>  	help
>  	  This package provides a C binding based on the main
> -- 
> 2.34.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot