From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE87CC27C50 for ; Tue, 4 Jun 2024 09:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dwa7Eg2MXrgdNNeGJkQC9pLmYqgSc3xh7vAmpLCLscY=; b=xFGdW0m2oPR1l8 rDxmy+5uTrwY+wpDusKmKMPAlwF/rK4/ph1uo/IWTeCRv6Tyex0UBblwH8n73arrl+kOQMcx4pqbP h25MB9MvLTFvwLG1j8BUrtKMcqhiDnPLpg1wlrtkqyqLXed+hVlP1yUHDGp6/JIP/zP2GKbP6xGFl kUuY0B7LdpKvzgIRDGxTFbs4ReXJRz9XQcTXIlUHWqmAvotnEqhtyrL8RCgjg+JCDnQjBmjiPTXMK YYzL0ptr+bKx/5alBgZNkEhWbUgR6jQjL+kHxfent7UYB3hFxgraNnXb9N5+h2HvbRd6pFnv4wUs5 bDmHuLSmZqBZ6DznK98g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEQkN-00000001uoH-0aLp; Tue, 04 Jun 2024 09:46:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEQkK-00000001unU-1ox7 for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 09:46:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 995E71042; Tue, 4 Jun 2024 02:46:46 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EC6B3F762; Tue, 4 Jun 2024 02:46:21 -0700 (PDT) Date: Tue, 4 Jun 2024 10:46:19 +0100 From: Cristian Marussi To: Sudeep Holla Cc: Geert Uytterhoeven , Jassi Brar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mailbox: ARM_MHU_V3 should depend on ARM64 Message-ID: References: <20240604070718.ypymfv6j2smvxldr@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240604070718.ypymfv6j2smvxldr@bogus> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_024624_585638_D5B2F939 X-CRM114-Status: GOOD ( 39.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdW4gMDQsIDIwMjQgYXQgMDg6MDc6MThBTSArMDEwMCwgU3VkZWVwIEhvbGxhIHdy b3RlOgo+IE9uIE1vbiwgSnVuIDAzLCAyMDI0IGF0IDA3OjUyOjU2UE0gKzAyMDAsIEdlZXJ0IFV5 dHRlcmhvZXZlbiB3cm90ZToKPiA+IEhpIFN1ZGVlcCwKPiA+Cj4gPiBPbiBNb24sIEp1biAzLCAy MDI0IGF0IDM6MznigK9QTSBTdWRlZXAgSG9sbGEgPHN1ZGVlcC5ob2xsYUBhcm0uY29tPiB3cm90 ZToKPiA+ID4gT24gV2VkLCBNYXkgMjksIDIwMjQgYXQgMDE6MzY6NDJQTSArMDIwMCwgR2VlcnQg VXl0dGVyaG9ldmVuIHdyb3RlOgo+ID4gPiA+IE9uIFdlZCwgTWF5IDI5LCAyMDI0IGF0IDEyOjEz 4oCvUE0gQ3Jpc3RpYW4gTWFydXNzaQo+ID4gPiA+IDxjcmlzdGlhbi5tYXJ1c3NpQGFybS5jb20+ IHdyb3RlOgo+ID4gPiA+ID4gT24gV2VkLCBNYXkgMjksIDIwMjQgYXQgMDk6MzA6NDVBTSArMDIw MCwgR2VlcnQgVXl0dGVyaG9ldmVuIHdyb3RlOgo+ID4gPiA+ID4gPiBUaGUgQVJNIE1IVXYzIGNv bnRyb2xsZXIgaXMgb25seSBwcmVzZW50IG9uIEFSTTY0IFNvQ3MuICBIZW5jZSBhZGQgYQo+ID4g PiA+ID4gPiBkZXBlbmRlbmN5IG9uIEFSTTY0LCB0byBwcmV2ZW50IGFza2luZyB0aGUgdXNlciBh Ym91dCB0aGlzIGRyaXZlciB3aGVuCj4gPiA+ID4gPiA+IGNvbmZpZ3VyaW5nIGEga2VybmVsIGZv ciBhIGRpZmZlcmVudCBhcmNoaXRlY3R1cmUgdGhhbiBBUk02NC4KPiA+ID4gPiA+Cj4gPiA+ID4g PiB0aGUgQVJNNjQgZGVwZW5kZW5jeSB3YXMgZHJvcHBlZCBvbiBwdXJwb3NlIGFmdGVyIGEgZmV3 IGl0ZXJhdGlvbnMgb2YKPiA+ID4gPiA+IHRoaXMgc2VyaWVzIHNpbmNlLCBkZXNwaXRlIHRoaXMg YmVpbmcgYW4gQVJNIElQLCBpdCBoYXMgcmVhbGx5IG5vIHRlY2huaWNhbAo+ID4gPiA+ID4gZGVw ZW5kZW5jeSBvbiBBUk0gYXJjaCwgbm90IGV2ZW4gdGhlIHVzdWFsIG9uZSBvbiBBUk0gQU1CQSBi dXMsIGJlaW5nIHRoaXMgYQo+ID4gPiA+ID4gcGxhdGZvcm0gZHJpdmVyLCBzbyBpdCBzZWVtZWQg YW4gdW5lZWRlZCBhcnRpZmljaWFsIHJlc3RyaWN0aW9uIHRvIGltcG9zZS4uLgo+ID4gPiA+ID4g Li4uaGF2aW5nIHNhaWQgdGhhdCwgc3VyZWx5IG15IGxpdmUgdGVzdGluZyB3ZXJlIHBlcmZvcm1l ZCBvbmx5IG9uIGFybTY0IG1vZGVscwo+ID4gPiA+ID4gYXMgb2Ygbm93Lgo+ID4gPiA+Cj4gPiA+ ID4gRm9yIHRoYXQsIHdlIGhhdmUgQ09NUElMRV9URVNUPXkuCj4gPiA+ID4KPiA+ID4gPiA+IFNv LCBJIGFtIG5vdCBzYXlpbmcgdGhhdCBJIGFtIGFnYWluc3QgdGhpcyBwcm9wb3NlZCBmaXggYnV0 IHdoYXQgaXMgdGhlCj4gPiA+ID4gPiBpc3N1ZSB0aGF0IGlzIHRyeWluZyB0byBzb2x2ZSwgaGF2 ZSB5b3Ugc2VlbiBhbnkgY29tcGlsYXRpb24gZXJyb3IgPyBvcgo+ID4gPiA+ID4gaXMgaXQganVz dCB0byBhdm9pZCB0aGUgdXNlci1wcm9tcHRpbmcgPwo+ID4gPiA+Cj4gPiA+ID4gSSBkaWQgbm90 IHNlZSBhIGNvbXBpbGUgZXJyb3IgKEkgZGlkbid0IGVuYWJsZSBpdCBvbiBhbnkgbm9uLUFSTQo+ ID4gPiA+IHBsYXRmb3JtKS4KPiA+ID4gPgo+ID4gPiA+IEJ1dCBpdCBpcyByYXRoZXIgZnV0aWxl IHRvIGFzayB0aGUgdXNlciBhYm91dCAodGhvdXNhbmRzIG9mKSBkcml2ZXJzCj4gPiA+ID4gZm9y IGhhcmR3YXJlIHRoYXQgY2Fubm90IHBvc3NpYmx5IGJlIHByZXNlbnQgb24gdGhlIHN5c3RlbSBo ZSBpcwo+ID4gPiA+IGNvbmZpZ3VyaW5nIGEga2VybmVsIGZvci4KPiA+ID4KPiA+ID4gSSBhbSBm aW5lIHdpdGggdGhpcyBmaXggYnV0IEkgaGF2ZSBzZWVuIHF1aXRlIG9wcG9zaXRlIGFyZ3VtZW50 LiBUaGF0IGlzCj4gPiA+IG5vdCB0byBhZGQgZGVwZW5kZW5jeSBpZiBpdCBpcyBub3Qgc3RyaWN0 bHkgcmVxdWlyZWQuCj4gPgo+ID4gQ2FuIHlvdSBwbGVhc2UgcG9pbnQgbWUgdG8gdGhhdCByZWZl cmVuY2U/Cj4gPgo+IAo+IEkgZG9uJ3QgaGF2ZSBvbmUgaGFuZHksIEkgbmVlZCB0byBkaWcgYnV0 IEkgaGF2ZSBiZWVuIGFza2VkIHRvIHJlbW92ZQo+IGluIHRoZSBwYXN0Lgo+IAo+ID4gPiBBbHNv IHNpbmNlIHlvdSBzdGF0ZSB0aGF0IHRoZSBmaXggaXMgdG8gYXZvaWQgdXNlcnMgb2Ygb3RoZXIg YXJjaHMgYmVpbmcKPiA+ID4gcG9zZWQgd2l0aCB0aGUgcXVlc3Rpb24gdGhhdCB0aGV5IG1heSBn ZXQgYW5ub3llZCBvciBjYW4ndCBhbnN3ZXIsIEkKPiA+ID4gd29uZGVyIGlmIHRoZSByaWdodCBh cHByb2FjaCBpcyB0byBtYWtlIHRoaXMgZHJpdmVyIGRlZmF1bHQgIm4iIGluc3RlYWQuCj4gPgo+ ID4gVGhlIGRyaXZlciBhbHJlYWR5IGRlZmF1bHRzIHRvICJuIiAod2hpY2ggaXMgdGhlIGRlZmF1 bHQgZGVmYXVsdCA7LSkKPiAKPiBBaCBDcmlzdGlhbiBtZW50aW9uZWQgdGhlIHNhbWUgaW4gcHJp dmF0ZS4gSSBtYXkgaGF2ZSBtaXN1bmRlcnN0b29kCj4gdGhlbiwgZm9yIHNvbWUgcmVhc29uIEkg dGhvdWdodCBleHBsaWNpdCBkZWZhdWx0ICJuIiB3b3VsZCBhdm9pZCBnZXR0aW5nCj4gdGhlIHBy b21wdC4KPiAKCkkganVzdCB0cmllZCB0aGlzIHRyaWNrLCBpdCBkb2VzIG5vdCBzZWVtIHRvIHdv cms6IGFuIGV4cGxpY3QgZGVmYXVsdC1uIHdpbGwKYW55d2F5IHRyaWdnZXIgYSBwcm9tcHQuCgo+ IEFzIEkgc2FpZCBJIGFtIGZpbmUgd2l0aCB0aGUgcHJvcG9zZWQgY2hhbmdlLCBqdXN0IHRvb2sg dGhpcyBkaXNjdXNzaW9uCj4gYXMgYSB3YXkgdG8gbGVhcm4gbGl0dGxlIG1vcmUgYWJvdXQgS2Nv bmZpZy4KPiAKCkNhbiB0aGlzIGJlIGF0IGxlYXN0CgoJZGVwZW5kcyBvbiBBUk0gfHwgQVJNNjQg fHwgQ09NUElMRV9URVNUCgpUaGFua3MsCkNyaXN0aWFuCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E857713B58A for ; Tue, 4 Jun 2024 09:46:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717494384; cv=none; b=aWz7h3VHv2Go3FSgk6V3E0FDu58lJU/QBK/0B5oBq/P6F1ebOwVdijjncAudOIm8YjYnWPZx0AWwoLk6d6zZwEEd8WB4nWY5htO6H7BwTdSx3ol+ASb7z2u5KhkLRI/oTCXkF48wo8PMa9pjlkok5AW3QlSZiLoG4LkvNWtA+r0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717494384; c=relaxed/simple; bh=/zpny/ZM3LBzpHP+P5Rl8ivFh/8aquswNIcUNFLBxoA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U4QAI3JFg/Xfe5iDlfXzyMIGhjaevqjAwsm6Y12IIB8aeRFAz9u2tWGNyiavW9psrK2bGinGTWc8tGBdh1w1yh9m/Naeml3Z9qHfPO5Hf21G5SAPRKZPejPVTi3KMTQGyMXA1f8+Jvb1y312u/ZjliIvla0merusjbcAxDqukQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 995E71042; Tue, 4 Jun 2024 02:46:46 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7EC6B3F762; Tue, 4 Jun 2024 02:46:21 -0700 (PDT) Date: Tue, 4 Jun 2024 10:46:19 +0100 From: Cristian Marussi To: Sudeep Holla Cc: Geert Uytterhoeven , Jassi Brar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mailbox: ARM_MHU_V3 should depend on ARM64 Message-ID: References: <20240604070718.ypymfv6j2smvxldr@bogus> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240604070718.ypymfv6j2smvxldr@bogus> On Tue, Jun 04, 2024 at 08:07:18AM +0100, Sudeep Holla wrote: > On Mon, Jun 03, 2024 at 07:52:56PM +0200, Geert Uytterhoeven wrote: > > Hi Sudeep, > > > > On Mon, Jun 3, 2024 at 3:39 PM Sudeep Holla wrote: > > > On Wed, May 29, 2024 at 01:36:42PM +0200, Geert Uytterhoeven wrote: > > > > On Wed, May 29, 2024 at 12:13 PM Cristian Marussi > > > > wrote: > > > > > On Wed, May 29, 2024 at 09:30:45AM +0200, Geert Uytterhoeven wrote: > > > > > > The ARM MHUv3 controller is only present on ARM64 SoCs. Hence add a > > > > > > dependency on ARM64, to prevent asking the user about this driver when > > > > > > configuring a kernel for a different architecture than ARM64. > > > > > > > > > > the ARM64 dependency was dropped on purpose after a few iterations of > > > > > this series since, despite this being an ARM IP, it has really no technical > > > > > dependency on ARM arch, not even the usual one on ARM AMBA bus, being this a > > > > > platform driver, so it seemed an uneeded artificial restriction to impose... > > > > > ...having said that, surely my live testing were performed only on arm64 models > > > > > as of now. > > > > > > > > For that, we have COMPILE_TEST=y. > > > > > > > > > So, I am not saying that I am against this proposed fix but what is the > > > > > issue that is trying to solve, have you seen any compilation error ? or > > > > > is it just to avoid the user-prompting ? > > > > > > > > I did not see a compile error (I didn't enable it on any non-ARM > > > > platform). > > > > > > > > But it is rather futile to ask the user about (thousands of) drivers > > > > for hardware that cannot possibly be present on the system he is > > > > configuring a kernel for. > > > > > > I am fine with this fix but I have seen quite opposite argument. That is > > > not to add dependency if it is not strictly required. > > > > Can you please point me to that reference? > > > > I don't have one handy, I need to dig but I have been asked to remove > in the past. > > > > Also since you state that the fix is to avoid users of other archs being > > > posed with the question that they may get annoyed or can't answer, I > > > wonder if the right approach is to make this driver default "n" instead. > > > > The driver already defaults to "n" (which is the default default ;-) > > Ah Cristian mentioned the same in private. I may have misunderstood > then, for some reason I thought explicit default "n" would avoid getting > the prompt. > I just tried this trick, it does not seem to work: an explict default-n will anyway trigger a prompt. > As I said I am fine with the proposed change, just took this discussion > as a way to learn little more about Kconfig. > Can this be at least depends on ARM || ARM64 || COMPILE_TEST Thanks, Cristian