From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AD7954903 for ; Tue, 4 Jun 2024 15:56:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717516572; cv=none; b=fBVPvfTF86NnfO63KcOZOcP9tDYWvP6e80XCzUdvWd66c8axKmbLNDp01ovYi7ZC68yD+32aYNgDMQoNBv/N19o+PyWX9ysfliaP/QNqUxZkL8TLqxsmZrx+rKNw/0WK85CtgGF5KbkFz07+2FPTmWfHclYt0I+xvbLbAXWLPz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717516572; c=relaxed/simple; bh=QItl/PKg+wwAMDiPxK9zBoZTc6Wj9x9La9g18aR8r00=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P9jHasVo9nS9ZT7YQNTcFCSST0lAmiQIOYv5L9gubrPb4c1WSxqo1NzhMJKxd2UUeRLQGZhiNYH7k7f0WD9rWL0AyFIMzRJk6hME3yPYPkZOb8SJaq5vsDNE6s1mgbk6y7DrNdhcxWiMgeMDVukV/9kd2n7EgxGZ5UblCrb4Q80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UlT2Gqjh; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UlT2Gqjh" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-42152bb7b81so76175e9.0 for ; Tue, 04 Jun 2024 08:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717516569; x=1718121369; darn=lists.linux.dev; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=d7Sgp9L6slntE6nZTy+7vKK0+zJTJ2LPyv+9VPLgyrQ=; b=UlT2GqjhmiT1Ok7J+MtleWoEVUEAEC4BV/2UcDaXLotEG/k8E8GLB86gi5dwNgW3jl PvetxkPnxvYe5tQkU3cLCT2sd+0u9YKd1GhWtz+okKw3JKL9noecLpgD5BOLjWjP/VxL JKakD0Kj3s/H5o18lDsI0HS4iiDZd6XVqws64I8fMxUk+3r5OCohfGyHWPzJQ6bQoDxr rVsW/rzFDX3QQ2mVRu7dkuFck4Av2TK7UkgDnvpJCyWQc18/ZXOrQwR5AbegEt29Lnq/ lKsz2OqQQAFtenPbcIIJA0F0wAFSmUTnGvg5fwZ1zkfIlxULa6O8NThaYvPofSqE0BqH zcmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717516569; x=1718121369; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d7Sgp9L6slntE6nZTy+7vKK0+zJTJ2LPyv+9VPLgyrQ=; b=T6+NRBo7kpN6/gLE3RHxPLrT1DmUow7tHh+6PmK36aiFljoHlOhnsrRPEYjWHzG5zl 9rbWbSVdFDfFImA9EUGPdnVBwURaGPoJ/82AYXyHiMEG1tyGjnknDCYTew2nPf58Rzqc QIGyo323292ZfO3zB2e5KDjXIXk9kgQtBtL/07SF5bCEuHARfasNuH1TY9EAaDuHBFKz pubbXjC2rziNwgvIINTt2hFU/lHct4WzTryqhPj3SoNsc6F7yaLbiJRuY34JyEtKgTuo Y61drRKZBmh7/Np+rDkExE/pk73F+efQy4zMQLoSlvie8YbjMQ/o5pYRqx/e75KW9jjF YVHg== X-Gm-Message-State: AOJu0YxdpnG0UPJAUMuP8Z92Hx0lgQNM7rnO1jCYF1zqcFFu9UdASX3l riKhu2UMETT349Y5pBpC0GH1Tt1aCWJHEdnl6ghZw/W1dqriU0Gu++lZgH6TXoJvLCuYTZAfJuR b2Q== X-Google-Smtp-Source: AGHT+IEd0pzHoP5jvawRJjsZ+1PlUhqKmRf0LfUuo7vArLwPTh4pkSqjwEUKKAPDDlnZpwywPSy9lw== X-Received: by 2002:a05:600c:5122:b0:41c:ab7:f9af with SMTP id 5b1f17b1804b1-4214b1cc21dmr2318855e9.3.1717516568484; Tue, 04 Jun 2024 08:56:08 -0700 (PDT) Received: from google.com (230.213.79.34.bc.googleusercontent.com. [34.79.213.230]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04d9364sm11958910f8f.53.2024.06.04.08.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 08:56:08 -0700 (PDT) Date: Tue, 4 Jun 2024 15:56:04 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Ryan Roberts Subject: Re: [PATCH 2/7] iommu/arm-smmu-v3: Do not zero the strtab twice Message-ID: References: <0-v1-1b720dce51d1+4f44-smmuv3_tidy_jgg@nvidia.com> <2-v1-1b720dce51d1+4f44-smmuv3_tidy_jgg@nvidia.com> Precedence: bulk X-Mailing-List: iommu@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2-v1-1b720dce51d1+4f44-smmuv3_tidy_jgg@nvidia.com> Hi Jason, On Mon, Jun 03, 2024 at 07:31:28PM -0300, Jason Gunthorpe wrote: > dmam_alloc_coherent() already returns zero'd memory so cfg->strtab.l1_desc > (the list of DMA addresses for the L2 entries) is already zero'd. > > arm_smmu_init_l1_strtab() goes through and calls > arm_smmu_write_strtab_l1_desc() on the newly allocated (and zero'd) struct > arm_smmu_strtab_l1_desc, which ends up computing 'val = 0' and zeroing it > again. > > Remove arm_smmu_init_l1_strtab() and just call devm_kcalloc() from > arm_smmu_init_strtab_2lvl to allocate the companion struct. > > Signed-off-by: Jason Gunthorpe Looking at the code for dmam_alloc_coherent(basically dma_alloc_coherent) I see that the memory is zeroed for both DMA direct and IOMMU, however I don’t see that documented (in DMA-API.txt). Assuming that’s guaranteed to be zeroed (maybe we should update the docs if I am not missing something) Reviewed-by: Mostafa Saleh > --- > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 27 +++++++-------------- > 1 file changed, 9 insertions(+), 18 deletions(-) > > diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > index 6b4f1a664288db..d27dd0600bf1df 100644 > --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c > @@ -3220,23 +3220,6 @@ static int arm_smmu_init_queues(struct arm_smmu_device *smmu) > PRIQ_ENT_DWORDS, "priq"); > } > > -static int arm_smmu_init_l1_strtab(struct arm_smmu_device *smmu) > -{ > - unsigned int i; > - struct arm_smmu_strtab_cfg *cfg = &smmu->strtab_cfg; > - > - cfg->l1_desc = devm_kcalloc(smmu->dev, cfg->num_l1_ents, > - sizeof(*cfg->l1_desc), GFP_KERNEL); > - if (!cfg->l1_desc) > - return -ENOMEM; > - > - for (i = 0; i < cfg->num_l1_ents; ++i) > - arm_smmu_write_strtab_l1_desc( > - &smmu->strtab_cfg.strtab.l1_desc[i], &cfg->l1_desc[i]); > - > - return 0; > -} > - > static int arm_smmu_init_strtab_2lvl(struct arm_smmu_device *smmu) > { > void *strtab; > @@ -3272,7 +3255,15 @@ static int arm_smmu_init_strtab_2lvl(struct arm_smmu_device *smmu) > reg |= FIELD_PREP(STRTAB_BASE_CFG_SPLIT, STRTAB_SPLIT); > cfg->strtab_base_cfg = reg; > > - return arm_smmu_init_l1_strtab(smmu); > + cfg->l1_desc = devm_kcalloc(smmu->dev, cfg->num_l1_ents, > + sizeof(*cfg->l1_desc), GFP_KERNEL); > + if (!cfg->l1_desc) { > + dev_err(smmu->dev, > + "failed to allocate l1 stream table (%zu bytes)\n", > + cfg->num_l1_ents * sizeof(*cfg->l1_desc)); > + return -ENOMEM; > + } > + return 0; > } > > static int arm_smmu_init_strtab_linear(struct arm_smmu_device *smmu) > -- > 2.45.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C312C25B78 for ; Tue, 4 Jun 2024 15:56:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7liX8Xjlp2MYvbc3i7hiDtgnA6YH/fHKmBdKTj2nLto=; b=Jp6J5L0u2yEsKh 0KYBfgsKp7T1CMQ7wKVY+EuOxBGfv+Dnq5WQzRbMvap/RPOZZIM2NDmqFiItX//FFKIsLKxpoyO7Z PsIhoVwt2m3Q+V9b1YEO8wlFJSgxVXoVLlJYHJ9HKYBWcKeAD6Y3Eq9XzgBXV15r0kRG9uePYD270 3vfVHkH0NetGHnEue/whO9r+Jpe/HmV+2t/NNoU8/xmuX9pIgi7Elgz1H9/WXy7U5Ub2iVSvOhbjE mKa3r522iMZZcPMBK3Z3OCcOdhX20sX/UHj5uaNgy3eR87b5jVBxLP8El65HwPRaZxxElJSJtYD77 9ZJrBBBINTQsnZFCeI0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEWWC-000000031g4-31Yg; Tue, 04 Jun 2024 15:56:12 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEWWA-000000031f2-0wNc for linux-arm-kernel@lists.infradead.org; Tue, 04 Jun 2024 15:56:11 +0000 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-42152bb7b81so76185e9.0 for ; Tue, 04 Jun 2024 08:56:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1717516569; x=1718121369; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=d7Sgp9L6slntE6nZTy+7vKK0+zJTJ2LPyv+9VPLgyrQ=; b=rDb5xZNL2UnW71yj0F4Qngw3Iy1ltRr45itRR9Aotce+J2Sz8LjqXI80MUhjxIxGNS 5F8Ov707UhKr0mlo4r7VCqUH19qs1wDLHmOI0dziS/y0Sc06GXgGpq6RtBqSCMII2Clu NbJNB/PWHiiLV0sFhpkq7DAT7hJptVVo5RIXMaXrDX+9SXJTooXx67BPnAy5TQHuM+uT Eg/AhH5KdvdmzyprbAkAXF3Zd0PzCd3wlH+x4xlUmLoL+iZ+xRQm1mYaN2+jaSA82iMv mCvCcwwdAxa2vwpfbfBtMozW2rmx41aTDyZA9VMdvjGEzF5EzqPHMEgJKA1ZgAL1Emph otLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717516569; x=1718121369; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=d7Sgp9L6slntE6nZTy+7vKK0+zJTJ2LPyv+9VPLgyrQ=; b=T7BzkkzygKzZT8FVTdUrTwb+foOOHjcyCkBn2RJ/6K9spNGxU9yJtLapPdSsq9b5m1 i2LUh8IrgmINraceeK/iIJDWcyvlQMC6LMhJeigVNdsANulrzU+4ltGkr3Rj3zqiv/Yw WDBk/ev/RI14v2rw+papPbJKCziNSvyNWzQQYINH4PwqrNsjlqMdRRL6J9S/vdssqvjt zYJ44GNkpnvSEUiLCWnD54y4VjVaD4fISLEd6yXfDLpPLhlHr5dGSvHTmX0+J3mVZpO/ xRpOjUOnTTIai7kycqtoAF7JRvhYNT2E4ahJRsLjziNTtvk5aW/UISsWvtssXOxFiaQr h0lg== X-Forwarded-Encrypted: i=1; AJvYcCWuNVMl6bs1QnBgPPnzdAl/nTKY/xT1Jd15957vjHGYxQ160Q0ogY2atc9I0EURie1+V+sOetsMGQqqdLe9KUB/E0dlw73kp0c6qCmNHr5V6Yh+AXA= X-Gm-Message-State: AOJu0YzI8l8CQ93ErLnKvnB8Gk8AZVOJFFDgSMExJUPha7gtG16Ep6fG JYZ/WXwX0P/WNK5xNa6zkDxOKGqxnfwHLM/ghQDraXlNn/S1uglAawPG2E3tCQ== X-Google-Smtp-Source: AGHT+IEd0pzHoP5jvawRJjsZ+1PlUhqKmRf0LfUuo7vArLwPTh4pkSqjwEUKKAPDDlnZpwywPSy9lw== X-Received: by 2002:a05:600c:5122:b0:41c:ab7:f9af with SMTP id 5b1f17b1804b1-4214b1cc21dmr2318855e9.3.1717516568484; Tue, 04 Jun 2024 08:56:08 -0700 (PDT) Received: from google.com (230.213.79.34.bc.googleusercontent.com. [34.79.213.230]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd04d9364sm11958910f8f.53.2024.06.04.08.56.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jun 2024 08:56:08 -0700 (PDT) Date: Tue, 4 Jun 2024 15:56:04 +0000 From: Mostafa Saleh To: Jason Gunthorpe Cc: iommu@lists.linux.dev, Joerg Roedel , linux-arm-kernel@lists.infradead.org, Robin Murphy , Will Deacon , Michael Shavit , Nicolin Chen , patches@lists.linux.dev, Ryan Roberts Subject: Re: [PATCH 2/7] iommu/arm-smmu-v3: Do not zero the strtab twice Message-ID: References: <0-v1-1b720dce51d1+4f44-smmuv3_tidy_jgg@nvidia.com> <2-v1-1b720dce51d1+4f44-smmuv3_tidy_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2-v1-1b720dce51d1+4f44-smmuv3_tidy_jgg@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240604_085610_287991_277E79C2 X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSmFzb24sCgpPbiBNb24sIEp1biAwMywgMjAyNCBhdCAwNzozMToyOFBNIC0wMzAwLCBKYXNv biBHdW50aG9ycGUgd3JvdGU6Cj4gZG1hbV9hbGxvY19jb2hlcmVudCgpIGFscmVhZHkgcmV0dXJu cyB6ZXJvJ2QgbWVtb3J5IHNvIGNmZy0+c3RydGFiLmwxX2Rlc2MKPiAodGhlIGxpc3Qgb2YgRE1B IGFkZHJlc3NlcyBmb3IgdGhlIEwyIGVudHJpZXMpIGlzIGFscmVhZHkgemVybydkLgo+IAo+IGFy bV9zbW11X2luaXRfbDFfc3RydGFiKCkgZ29lcyB0aHJvdWdoIGFuZCBjYWxscwo+IGFybV9zbW11 X3dyaXRlX3N0cnRhYl9sMV9kZXNjKCkgb24gdGhlIG5ld2x5IGFsbG9jYXRlZCAoYW5kIHplcm8n ZCkgc3RydWN0Cj4gYXJtX3NtbXVfc3RydGFiX2wxX2Rlc2MsIHdoaWNoIGVuZHMgdXAgY29tcHV0 aW5nICd2YWwgPSAwJyBhbmQgemVyb2luZyBpdAo+IGFnYWluLgo+IAo+IFJlbW92ZSBhcm1fc21t dV9pbml0X2wxX3N0cnRhYigpIGFuZCBqdXN0IGNhbGwgZGV2bV9rY2FsbG9jKCkgZnJvbQo+IGFy bV9zbW11X2luaXRfc3RydGFiXzJsdmwgdG8gYWxsb2NhdGUgdGhlIGNvbXBhbmlvbiBzdHJ1Y3Qu Cj4gCj4gU2lnbmVkLW9mZi1ieTogSmFzb24gR3VudGhvcnBlIDxqZ2dAbnZpZGlhLmNvbT4KCkxv b2tpbmcgYXQgdGhlIGNvZGUgZm9yIGRtYW1fYWxsb2NfY29oZXJlbnQoYmFzaWNhbGx5IGRtYV9h bGxvY19jb2hlcmVudCkKSSBzZWUgdGhhdCB0aGUgbWVtb3J5IGlzIHplcm9lZCBmb3IgYm90aCBE TUEgZGlyZWN0IGFuZCBJT01NVSwgaG93ZXZlcgpJIGRvbuKAmXQgc2VlIHRoYXQgZG9jdW1lbnRl ZCAoaW4gRE1BLUFQSS50eHQpLgoKQXNzdW1pbmcgdGhhdOKAmXMgZ3VhcmFudGVlZCB0byBiZSB6 ZXJvZWQgKG1heWJlIHdlIHNob3VsZCB1cGRhdGUgdGhlIGRvY3MKaWYgSSBhbSBub3QgbWlzc2lu ZyBzb21ldGhpbmcpClJldmlld2VkLWJ5OiBNb3N0YWZhIFNhbGVoIDxzbW9zdGFmYUBnb29nbGUu Y29tPgoKPiAtLS0KPiAgZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMu YyB8IDI3ICsrKysrKystLS0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOSBpbnNlcnRp b25zKCspLCAxOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9h cm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMuYyBiL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11 LXYzL2FybS1zbW11LXYzLmMKPiBpbmRleCA2YjRmMWE2NjQyODhkYi4uZDI3ZGQwNjAwYmYxZGYg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9pb21tdS9hcm0vYXJtLXNtbXUtdjMvYXJtLXNtbXUtdjMu Ywo+ICsrKyBiL2RyaXZlcnMvaW9tbXUvYXJtL2FybS1zbW11LXYzL2FybS1zbW11LXYzLmMKPiBA QCAtMzIyMCwyMyArMzIyMCw2IEBAIHN0YXRpYyBpbnQgYXJtX3NtbXVfaW5pdF9xdWV1ZXMoc3Ry dWN0IGFybV9zbW11X2RldmljZSAqc21tdSkKPiAgCQkJCSAgICAgICBQUklRX0VOVF9EV09SRFMs ICJwcmlxIik7Cj4gIH0KPiAgCj4gLXN0YXRpYyBpbnQgYXJtX3NtbXVfaW5pdF9sMV9zdHJ0YWIo c3RydWN0IGFybV9zbW11X2RldmljZSAqc21tdSkKPiAtewo+IC0JdW5zaWduZWQgaW50IGk7Cj4g LQlzdHJ1Y3QgYXJtX3NtbXVfc3RydGFiX2NmZyAqY2ZnID0gJnNtbXUtPnN0cnRhYl9jZmc7Cj4g LQo+IC0JY2ZnLT5sMV9kZXNjID0gZGV2bV9rY2FsbG9jKHNtbXUtPmRldiwgY2ZnLT5udW1fbDFf ZW50cywKPiAtCQkJCSAgICBzaXplb2YoKmNmZy0+bDFfZGVzYyksIEdGUF9LRVJORUwpOwo+IC0J aWYgKCFjZmctPmwxX2Rlc2MpCj4gLQkJcmV0dXJuIC1FTk9NRU07Cj4gLQo+IC0JZm9yIChpID0g MDsgaSA8IGNmZy0+bnVtX2wxX2VudHM7ICsraSkKPiAtCQlhcm1fc21tdV93cml0ZV9zdHJ0YWJf bDFfZGVzYygKPiAtCQkJJnNtbXUtPnN0cnRhYl9jZmcuc3RydGFiLmwxX2Rlc2NbaV0sICZjZmct PmwxX2Rlc2NbaV0pOwo+IC0KPiAtCXJldHVybiAwOwo+IC19Cj4gLQo+ICBzdGF0aWMgaW50IGFy bV9zbW11X2luaXRfc3RydGFiXzJsdmwoc3RydWN0IGFybV9zbW11X2RldmljZSAqc21tdSkKPiAg ewo+ICAJdm9pZCAqc3RydGFiOwo+IEBAIC0zMjcyLDcgKzMyNTUsMTUgQEAgc3RhdGljIGludCBh cm1fc21tdV9pbml0X3N0cnRhYl8ybHZsKHN0cnVjdCBhcm1fc21tdV9kZXZpY2UgKnNtbXUpCj4g IAlyZWcgfD0gRklFTERfUFJFUChTVFJUQUJfQkFTRV9DRkdfU1BMSVQsIFNUUlRBQl9TUExJVCk7 Cj4gIAljZmctPnN0cnRhYl9iYXNlX2NmZyA9IHJlZzsKPiAgCj4gLQlyZXR1cm4gYXJtX3NtbXVf aW5pdF9sMV9zdHJ0YWIoc21tdSk7Cj4gKwljZmctPmwxX2Rlc2MgPSBkZXZtX2tjYWxsb2Moc21t dS0+ZGV2LCBjZmctPm51bV9sMV9lbnRzLAo+ICsJCQkJICAgIHNpemVvZigqY2ZnLT5sMV9kZXNj KSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIWNmZy0+bDFfZGVzYykgewo+ICsJCWRldl9lcnIoc21t dS0+ZGV2LAo+ICsJCQkiZmFpbGVkIHRvIGFsbG9jYXRlIGwxIHN0cmVhbSB0YWJsZSAoJXp1IGJ5 dGVzKVxuIiwKPiArCQkJY2ZnLT5udW1fbDFfZW50cyAqIHNpemVvZigqY2ZnLT5sMV9kZXNjKSk7 Cj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4gKwl9Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICAKPiAgc3Rh dGljIGludCBhcm1fc21tdV9pbml0X3N0cnRhYl9saW5lYXIoc3RydWN0IGFybV9zbW11X2Rldmlj ZSAqc21tdSkKPiAtLSAKPiAyLjQ1LjIKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK