From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDEF88F6B for ; Mon, 27 May 2024 04:36:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716784569; cv=none; b=k65yp4SQ6Tq7momFxLzcmBITeK/IfRYrHgoBPXEnH2YUrz/YXynspnsCYEGZIBfIoLysP/G4JOIrO6nslZMj5qYWa+yiy2VzTHlKDS9FzvvH6kFnA3Dgc5+yh1QvOG+U3aoHViReIZWI2uApR1Fl8EE0oW/HDZ4BvNcdCXxDK6w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716784569; c=relaxed/simple; bh=xrShOrBMudNx1lIclZjti31jJIj1JbkTGrXCdkVq56E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DuyGcZ56Xdu1QNCk/iJtGjBCFQNImAredoSP+5NBC2TmSzrhPeEUH30L/+mAGORnXVOr5Z91qXhCx8n06thGXtOixI/us/X7XxRhKmouBkMQmkxE8N5QBx1GW/uQhgPHHjJYkeD+n7aTVBofH8IDPX4QVpG+X9/OxdSpmz8RIPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=bNp+m8Jd; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="bNp+m8Jd" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1f44b5d0c50so17932395ad.2 for ; Sun, 26 May 2024 21:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1716784567; x=1717389367; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GCL45r5HwUdhMGMoKs1ELoA50Buz5dFrdewkzzL6SwI=; b=bNp+m8JdcHP9+uIKotaS/Y1wPysYaYqIStkY7DdkFZpZo78iUQZCQohEEgXMfyz/HF EOjBkxxrom94CNZAk5M0LSL5wzMWnGkgs/Cif2RVuZbqYBMzWe31XWTJKYKYmsdhrUOe VNEteSuIjrvKQmHb0f+QgiLTVITTdJ7vuQ2r5v4Yha41wcoQ/qFnLw9Muwcg1mKF9+0C 3TEQM5igw6A6IskQ09mj2fAMK87OHRff4jwDvBUyMHNblLMKjyhi9lpZ3ej26loEfUIi 7lexlQRPyTQjGJ0CITeQl1CI91ejsslIirGfn1NAzS/KY/uPtBttKM67ATLjl5VDSthJ NMWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716784567; x=1717389367; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GCL45r5HwUdhMGMoKs1ELoA50Buz5dFrdewkzzL6SwI=; b=ayS0ofCNrJ5U5QCVvO8a+8Z9pTf9Bz0iPuD0CV5U685Ou+8r804Gmlms3LJYhBUxqB rSj8csnbVd5qlSpWO3ZC+KSF/9qZx7RZiegrUWpRBkx6+8pvbQmpHCyjb45OPHMl4o7T 7Lt6JNsPZphT5cSTb/P2qNll0yinTBLLBVTXU07GYH0SbDFZG/JJkgmW7hQ86IET6P1Y XbkkHp77i66gGYqRs6iTSqRBFCHbYQIXt8O6rKH1QoMy9Z0qGgk0E9TMg5ywxbtti38J +Nfy+cIpUK4ov6FEitptWBcNWq5OZxhTQG3lBJWj86VbaTzDj5Isaz3sfnSH9H+C43/y fz4g== X-Forwarded-Encrypted: i=1; AJvYcCXfc20mfYgxOS23t5S775yTqcmGwAY2vS2uwMjsLlhhGBngUVHo/Dlf52VI9mtkJgqOvJKlqJQ977OAOWIRX6ECRoffG+O7NtO3RuWf X-Gm-Message-State: AOJu0YxOUCqOG4UQFy8hzNWecWfOBXcWp9TBrUxrR2XNd8V2FReObfyj VZ36sH4PAb0hUfYdhRkHnL5G/skZF8ScAD31SiLY4Q7RfBxv4euUxnjKuB3yVEo= X-Google-Smtp-Source: AGHT+IH2qTAk+H4YWdMT+3HDQ47VPDZxZ9rT9jbAlx84jUV+F91w+En1i4ZeI520OwORxw1JjKsITQ== X-Received: by 2002:a17:903:2306:b0:1f4:a77a:3bb9 with SMTP id d9443c01a7336-1f4a77a3ea0mr9409085ad.64.1716784566971; Sun, 26 May 2024 21:36:06 -0700 (PDT) Received: from sunil-laptop ([106.51.188.31]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c968516sm50975975ad.179.2024.05.26.21.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 21:36:06 -0700 (PDT) Date: Mon, 27 May 2024 10:05:54 +0530 From: Sunil V L To: Bjorn Helgaas Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, acpica-devel@lists.linux.dev, Catalin Marinas , Will Deacon , Paul Walmsley , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Greg Kroah-Hartman , Jiri Slaby , Robert Moore , Conor Dooley , Andrew Jones , Andy Shevchenko , Marc Zyngier , Atish Kumar Patra , Andrei Warkentin , Haibo1 Xu , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v5 07/17] ACPI: bus: Add RINTC IRQ model for RISC-V Message-ID: References: <20240501121742.1215792-8-sunilvl@ventanamicro.com> <20240523215903.GA138985@bhelgaas> Precedence: bulk X-Mailing-List: acpica-devel@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240523215903.GA138985@bhelgaas> On Thu, May 23, 2024 at 04:59:03PM -0500, Bjorn Helgaas wrote: > On Wed, May 01, 2024 at 05:47:32PM +0530, Sunil V L wrote: > > Add the IRQ model for RISC-V INTC so that acpi_set_irq_model can use this > > for RISC-V. > > > > Signed-off-by: Sunil V L > > --- > > drivers/acpi/bus.c | 3 +++ > > include/linux/acpi.h | 1 + > > 2 files changed, 4 insertions(+) > > > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > index 17ee483c3bf4..6739db258a95 100644 > > --- a/drivers/acpi/bus.c > > +++ b/drivers/acpi/bus.c > > @@ -1190,6 +1190,9 @@ static int __init acpi_bus_init_irq(void) > > case ACPI_IRQ_MODEL_LPIC: > > message = "LPIC"; > > break; > > + case ACPI_IRQ_MODEL_RINTC: > > + message = "RINTC"; > > + break; > > default: > > pr_info("Unknown interrupt routing model\n"); > > return -ENODEV; > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > > index 846a4001b5e0..c1a01fd02873 100644 > > --- a/include/linux/acpi.h > > +++ b/include/linux/acpi.h > > @@ -107,6 +107,7 @@ enum acpi_irq_model_id { > > ACPI_IRQ_MODEL_PLATFORM, > > ACPI_IRQ_MODEL_GIC, > > ACPI_IRQ_MODEL_LPIC, > > + ACPI_IRQ_MODEL_RINTC, > > Is the ACPI_IRQ_MODEL_RINTC value documented somewhere? Maybe an ECR > for the ACPI spec? > > acpi_bus_init_irq() is going to pass ACPI_IRQ_MODEL_RINTC to _PIC, and > ACPI r6.5, sec 5.8.1 only mentions the ACPI_IRQ_MODEL_PIC, > ACPI_IRQ_MODEL_IOAPIC, and ACPI_IRQ_MODEL_IOSAPIC values. > > Even the existing ACPI_IRQ_MODEL_PLATFORM, ACPI_IRQ_MODEL_GIC, and > ACPI_IRQ_MODEL_LPIC values aren't mentioned in ACPI r6.5. > Yeah, I also noticed it. I don't know the history behind this. Rafael or someone else might have better knowledge. IMO, it is better to update ACPI spec _PIC with all these values. If I don't see any objections, I will raise an ECR to update the spec. Thanks, Sunl From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2ADEC25B79 for ; Mon, 27 May 2024 04:36:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=C3XkVTeiiMiq9nLfNB5o/yVrOuMzoRfz+H72JaeWbNY=; b=t6LZLkoa6y1SM3 qZ+lzry2HtDaN6tthNMxFutvmZcTAZz3M6PzrSHOhF6Xd2/l+s5gZ8Hlthdy4e+anlTTTsUceP58b cPtYyIz5Pz359S6nDoulQmD6WP8TbpOlwC1jdkMs13qSS9yS9Q8BtNXHOODh6AHmN9C/CZZrNasG/ BopYyqtvVSQpyGAJPRAUyh2GVqiuaV9kGi5FLLQ7jp9kHuHGO0VfvV2ESnzy2uP1zglZwIGa9Oz1E rfO9b48jzyHrQSr/mFRCWXXWbItXb9dT5ashPyOCKZ8kmceN5TvOMyaaMVwohpjDkMSzWOEZMSWN5 M5ZJHhZjVK0iizbfmYVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBS5m-0000000DlDg-3pdi; Mon, 27 May 2024 04:36:14 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBS5i-0000000DlCP-2Vag for linux-riscv@lists.infradead.org; Mon, 27 May 2024 04:36:13 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1f4a52b9589so2682465ad.3 for ; Sun, 26 May 2024 21:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1716784567; x=1717389367; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GCL45r5HwUdhMGMoKs1ELoA50Buz5dFrdewkzzL6SwI=; b=jIU2ap7DsrDiHRl9gxwipRwQ4vo7Ngfhy5qrpx0n7CKKVxlKa9eVk4B/9F5FbbR8at VFpBV2Y4VjC016uVVbDE13YAQqkqQ40PWFogoc5I3QkdtexlGINDHscZfzCOa2xdFCF0 kJFMpeUBGLO6b4dD7ee/ob8fveMPa/Hty8rBI6zXDTQ210pzKQs8/wx4rRT5wSoTFdRn 4Fcb2KaoImHJVSbSOlihHI7tBPvOrAdOEnrWNbZGSz7Zfh5ilnoYGb5X4YTMRkyptRSr fbH5k6bMhdgCdUhwnHyIdg2QtJikfkd/OSyqI4HWkNU7WsSCoDsVBVDN5V2LccQD/PK5 9VgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716784567; x=1717389367; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GCL45r5HwUdhMGMoKs1ELoA50Buz5dFrdewkzzL6SwI=; b=JOxFQClJbmBEDRvXFDg0m5nDjzalayQqss0Ras7G7552GqS3En5N/qxXafSQ+ahj1g mzgwBP4nImIX4JElk5io2n32H9sPzn/ciybNqHW06V6pQKGAFtHcemABpTMHXUZzOEpg LhoDBZIgiZMjTJFNDCKWW6FmeszwnA+k7jhvBB0OOmvfBGSuyx/EDTxovIpNxQVO0Wdj VnDFSJXAgC75jHVeS177KW+fX4OWmpaqDC05qaTinzdCxeKq0VWHEXKFYuH+70pNpGrY aLywBkADpjKPaQFwUL9H1U5ochKTxGzgvnA5EPOIJKEs3waKwXxLLgfwRBhkoVV0qqGc WBvw== X-Forwarded-Encrypted: i=1; AJvYcCU5GYFbWMjqUhWmDQqcTJ11uMKINA7EhT5Kwl8h2oYS1ATYTAbbc7gWk4HqhOBDvM2iDjjXfmmwK4SjWjY+97Jh/fSMDvaH4YoHin6GDzyG X-Gm-Message-State: AOJu0YwLQVfvhHV8hoIyOB+76zoYvBodjogWzN2LOfmlVwuZeQgnpXFR dr8aVJfP0jvT5ikihhF6/TJNSPuzCJgqQVUI9Nq46KdbgBDaRr3yq7jS+WKLDds= X-Google-Smtp-Source: AGHT+IH2qTAk+H4YWdMT+3HDQ47VPDZxZ9rT9jbAlx84jUV+F91w+En1i4ZeI520OwORxw1JjKsITQ== X-Received: by 2002:a17:903:2306:b0:1f4:a77a:3bb9 with SMTP id d9443c01a7336-1f4a77a3ea0mr9409085ad.64.1716784566971; Sun, 26 May 2024 21:36:06 -0700 (PDT) Received: from sunil-laptop ([106.51.188.31]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c968516sm50975975ad.179.2024.05.26.21.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 21:36:06 -0700 (PDT) Date: Mon, 27 May 2024 10:05:54 +0530 From: Sunil V L To: Bjorn Helgaas Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, acpica-devel@lists.linux.dev, Catalin Marinas , Will Deacon , Paul Walmsley , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Greg Kroah-Hartman , Jiri Slaby , Robert Moore , Conor Dooley , Andrew Jones , Andy Shevchenko , Marc Zyngier , Atish Kumar Patra , Andrei Warkentin , Haibo1 Xu , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v5 07/17] ACPI: bus: Add RINTC IRQ model for RISC-V Message-ID: References: <20240501121742.1215792-8-sunilvl@ventanamicro.com> <20240523215903.GA138985@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240523215903.GA138985@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240526_213610_669851_D31126A1 X-CRM114-Status: GOOD ( 21.40 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Thu, May 23, 2024 at 04:59:03PM -0500, Bjorn Helgaas wrote: > On Wed, May 01, 2024 at 05:47:32PM +0530, Sunil V L wrote: > > Add the IRQ model for RISC-V INTC so that acpi_set_irq_model can use this > > for RISC-V. > > > > Signed-off-by: Sunil V L > > --- > > drivers/acpi/bus.c | 3 +++ > > include/linux/acpi.h | 1 + > > 2 files changed, 4 insertions(+) > > > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > index 17ee483c3bf4..6739db258a95 100644 > > --- a/drivers/acpi/bus.c > > +++ b/drivers/acpi/bus.c > > @@ -1190,6 +1190,9 @@ static int __init acpi_bus_init_irq(void) > > case ACPI_IRQ_MODEL_LPIC: > > message = "LPIC"; > > break; > > + case ACPI_IRQ_MODEL_RINTC: > > + message = "RINTC"; > > + break; > > default: > > pr_info("Unknown interrupt routing model\n"); > > return -ENODEV; > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > > index 846a4001b5e0..c1a01fd02873 100644 > > --- a/include/linux/acpi.h > > +++ b/include/linux/acpi.h > > @@ -107,6 +107,7 @@ enum acpi_irq_model_id { > > ACPI_IRQ_MODEL_PLATFORM, > > ACPI_IRQ_MODEL_GIC, > > ACPI_IRQ_MODEL_LPIC, > > + ACPI_IRQ_MODEL_RINTC, > > Is the ACPI_IRQ_MODEL_RINTC value documented somewhere? Maybe an ECR > for the ACPI spec? > > acpi_bus_init_irq() is going to pass ACPI_IRQ_MODEL_RINTC to _PIC, and > ACPI r6.5, sec 5.8.1 only mentions the ACPI_IRQ_MODEL_PIC, > ACPI_IRQ_MODEL_IOAPIC, and ACPI_IRQ_MODEL_IOSAPIC values. > > Even the existing ACPI_IRQ_MODEL_PLATFORM, ACPI_IRQ_MODEL_GIC, and > ACPI_IRQ_MODEL_LPIC values aren't mentioned in ACPI r6.5. > Yeah, I also noticed it. I don't know the history behind this. Rafael or someone else might have better knowledge. IMO, it is better to update ACPI spec _PIC with all these values. If I don't see any objections, I will raise an ECR to update the spec. Thanks, Sunl _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6586BC25B74 for ; Mon, 27 May 2024 04:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sqqE1lu43y2OQmBVygSOoU+9ipx4xe4+OcNlKudL8sg=; b=3beCloaOJ3wvrb /CuHOkN4eOfHOGiBcyCLHvojp6VK3CBmVtt4MEr6D/EjUX5nbZ0v79p5HdM34KlzgnwvF6oVyATC4 ncM06+7pBHeCNWOFgKYOWJ0XDTTirG3GU9c/Q8BMZO+9iqrV5K6aEqEG5yI5Bq3CUG7j81BX1BmKL dc0/WbILroo9yEyTKgn21VhawJY6tqiE5oRhfaWW53TtCPZJPeFKwq4Idk9CAt1meeTh3NKPZ8zsl 2X7p+/cAxxaf0nkB5bf0+JcYMxGLuEv4f/WzbvZ4ZoO27I55QrHx3pryF/JqDc+d0sHflMD/78cm3 QYe2v7+hYYTmSYkBfsbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBS5m-0000000DlDP-0dDb; Mon, 27 May 2024 04:36:14 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBS5i-0000000DlCQ-3VcG for linux-arm-kernel@lists.infradead.org; Mon, 27 May 2024 04:36:13 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1f44b5d0c50so17932415ad.2 for ; Sun, 26 May 2024 21:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1716784567; x=1717389367; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GCL45r5HwUdhMGMoKs1ELoA50Buz5dFrdewkzzL6SwI=; b=jIU2ap7DsrDiHRl9gxwipRwQ4vo7Ngfhy5qrpx0n7CKKVxlKa9eVk4B/9F5FbbR8at VFpBV2Y4VjC016uVVbDE13YAQqkqQ40PWFogoc5I3QkdtexlGINDHscZfzCOa2xdFCF0 kJFMpeUBGLO6b4dD7ee/ob8fveMPa/Hty8rBI6zXDTQ210pzKQs8/wx4rRT5wSoTFdRn 4Fcb2KaoImHJVSbSOlihHI7tBPvOrAdOEnrWNbZGSz7Zfh5ilnoYGb5X4YTMRkyptRSr fbH5k6bMhdgCdUhwnHyIdg2QtJikfkd/OSyqI4HWkNU7WsSCoDsVBVDN5V2LccQD/PK5 9VgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716784567; x=1717389367; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GCL45r5HwUdhMGMoKs1ELoA50Buz5dFrdewkzzL6SwI=; b=IWvdqngmB7l4qldyR3Fq3kjY1gfFG0Iqsq+PDdFxt+uK95RCaUsypVdYGU3iVMFJ9E aiHNXws4YgZ9LOwlVph2ucCbkV6e3KK/XiLRMDc2Az6AbgWuIMoPf1CHml1rIWGoOFCh j95n5CKXxSwHaObnAvvf4ycJ4e4Z1XwCNgEuIoP4Q3hLw745tfoSkpm5n/8FtTNxmy3x GTip0UyLYtCtoIpn/8khhNb/YEyitcY5PkEer0M1vRaHhAqocroTdhT0v6makh3zSvOc HzalHhh639NrV1He8XYZN0dywI5RUepHqZwroOrZ9kmoCQxj8yD0hJ31gHqkmxrB3GeQ W6dA== X-Gm-Message-State: AOJu0YyHAdyIootlUMi680R6HksCv4rrZVGfDh1NQgdbgimyJcO7S7vM ZpCBhuZPC9ILBZBH6PTtBqaq1+FcSu7dto9zMh0f9FJMtpxz0M0knbcqO5nNvJQ= X-Google-Smtp-Source: AGHT+IH2qTAk+H4YWdMT+3HDQ47VPDZxZ9rT9jbAlx84jUV+F91w+En1i4ZeI520OwORxw1JjKsITQ== X-Received: by 2002:a17:903:2306:b0:1f4:a77a:3bb9 with SMTP id d9443c01a7336-1f4a77a3ea0mr9409085ad.64.1716784566971; Sun, 26 May 2024 21:36:06 -0700 (PDT) Received: from sunil-laptop ([106.51.188.31]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f44c968516sm50975975ad.179.2024.05.26.21.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 May 2024 21:36:06 -0700 (PDT) Date: Mon, 27 May 2024 10:05:54 +0530 From: Sunil V L To: Bjorn Helgaas Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-serial@vger.kernel.org, acpica-devel@lists.linux.dev, Catalin Marinas , Will Deacon , Paul Walmsley , Albert Ou , "Rafael J . Wysocki" , Len Brown , Bjorn Helgaas , Anup Patel , Thomas Gleixner , Samuel Holland , Greg Kroah-Hartman , Jiri Slaby , Robert Moore , Conor Dooley , Andrew Jones , Andy Shevchenko , Marc Zyngier , Atish Kumar Patra , Andrei Warkentin , Haibo1 Xu , =?utf-8?B?QmrDtnJuIFTDtnBlbA==?= Subject: Re: [PATCH v5 07/17] ACPI: bus: Add RINTC IRQ model for RISC-V Message-ID: References: <20240501121742.1215792-8-sunilvl@ventanamicro.com> <20240523215903.GA138985@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240523215903.GA138985@bhelgaas> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240526_213610_924371_7090711B X-CRM114-Status: GOOD ( 22.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 23, 2024 at 04:59:03PM -0500, Bjorn Helgaas wrote: > On Wed, May 01, 2024 at 05:47:32PM +0530, Sunil V L wrote: > > Add the IRQ model for RISC-V INTC so that acpi_set_irq_model can use this > > for RISC-V. > > > > Signed-off-by: Sunil V L > > --- > > drivers/acpi/bus.c | 3 +++ > > include/linux/acpi.h | 1 + > > 2 files changed, 4 insertions(+) > > > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > index 17ee483c3bf4..6739db258a95 100644 > > --- a/drivers/acpi/bus.c > > +++ b/drivers/acpi/bus.c > > @@ -1190,6 +1190,9 @@ static int __init acpi_bus_init_irq(void) > > case ACPI_IRQ_MODEL_LPIC: > > message = "LPIC"; > > break; > > + case ACPI_IRQ_MODEL_RINTC: > > + message = "RINTC"; > > + break; > > default: > > pr_info("Unknown interrupt routing model\n"); > > return -ENODEV; > > diff --git a/include/linux/acpi.h b/include/linux/acpi.h > > index 846a4001b5e0..c1a01fd02873 100644 > > --- a/include/linux/acpi.h > > +++ b/include/linux/acpi.h > > @@ -107,6 +107,7 @@ enum acpi_irq_model_id { > > ACPI_IRQ_MODEL_PLATFORM, > > ACPI_IRQ_MODEL_GIC, > > ACPI_IRQ_MODEL_LPIC, > > + ACPI_IRQ_MODEL_RINTC, > > Is the ACPI_IRQ_MODEL_RINTC value documented somewhere? Maybe an ECR > for the ACPI spec? > > acpi_bus_init_irq() is going to pass ACPI_IRQ_MODEL_RINTC to _PIC, and > ACPI r6.5, sec 5.8.1 only mentions the ACPI_IRQ_MODEL_PIC, > ACPI_IRQ_MODEL_IOAPIC, and ACPI_IRQ_MODEL_IOSAPIC values. > > Even the existing ACPI_IRQ_MODEL_PLATFORM, ACPI_IRQ_MODEL_GIC, and > ACPI_IRQ_MODEL_LPIC values aren't mentioned in ACPI r6.5. > Yeah, I also noticed it. I don't know the history behind this. Rafael or someone else might have better knowledge. IMO, it is better to update ACPI spec _PIC with all these values. If I don't see any objections, I will raise an ECR to update the spec. Thanks, Sunl _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel