From: Christoph Hellwig <hch@infradead.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Guanbing Huang <albanhuang@outlook.com>,
Guanbing Huang <albanhuang@tencent.com>,
Woody Suwalski <terraluna977@gmail.com>
Subject: Re: [PATCH v1 1/1] PNP: Export pnp_bus_type for modules
Date: Mon, 27 May 2024 21:58:41 -0700 [thread overview]
Message-ID: <ZlVkgf_XCZcZd388@infradead.org> (raw)
In-Reply-To: <20240527202424.1430103-1-andy.shevchenko@gmail.com>
On Mon, May 27, 2024 at 11:24:24PM +0300, Andy Shevchenko wrote:
> Since we have dev_is_pnp() macro that utilises the address of pnp_bus_type
> variable, the users, which can be compiled as modules, will be failed to
> build. Export the variable to the modules to prevent build breakage.
NAK. Please move dev_is_pnp out of line and export it (as
EXPORT_SYMBOL_GPL), please. bus types should be private unless we have
really good reasons for them not to be private.
next prev parent reply other threads:[~2024-05-28 4:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 20:24 [PATCH v1 1/1] PNP: Export pnp_bus_type for modules Andy Shevchenko
2024-05-27 22:20 ` Woody Suwalski
2024-05-28 4:58 ` Christoph Hellwig [this message]
2024-05-28 7:10 ` Andy Shevchenko
2024-05-28 7:12 ` Andy Shevchenko
2024-05-28 7:14 ` Christoph Hellwig
2024-05-28 9:42 ` Rafael J. Wysocki
2024-05-28 9:52 ` Andy Shevchenko
2024-05-28 9:58 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlVkgf_XCZcZd388@infradead.org \
--to=hch@infradead.org \
--cc=albanhuang@outlook.com \
--cc=albanhuang@tencent.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=terraluna977@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.