From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) by smtp.lore.kernel.org (Postfix) with ESMTP id 008A5C25B78 for ; Tue, 28 May 2024 05:51:43 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uR1xaOLu; dkim=fail reason="signature verification failed" header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3HUchnWb; dkim=fail reason="signature verification failed" (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uR1xaOLu; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3HUchnWb; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VpLxM3Z2yz79jM for ; Tue, 28 May 2024 15:41:59 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uR1xaOLu; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3HUchnWb; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=uR1xaOLu; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=3HUchnWb; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=suse.de (client-ip=2a07:de40:b251:101:10:150:64:1; helo=smtp-out1.suse.de; envelope-from=osalvador@suse.de; receiver=lists.ozlabs.org) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VpLwY0yFsz3vjT for ; Tue, 28 May 2024 15:41:16 +1000 (AEST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4D93921FE5; Tue, 28 May 2024 05:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716874870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=uR1xaOLuXJgO8F8luIHAiNPK/3HsTsZEkAuEdurxgU+uZkDfH5eamxVBPnLxSktxjLhp4b 6EtlDxr/L3apbAbUHFM6/Y8mrKutJWTUc5x/iwRhYTgBT7A/s6VJ8rWlWsmEcbWNu7PQUu sRNOuGDBwZaVY7Oz/1onnvHHRqfh4TM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716874870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=3HUchnWb1qnsO5VRZyCjhJYFR1JJZKtwmuj891qHdYQ8GM3LDJGZKJj2LS83aK0EZe2TKo fFjscNHWXFVgaFDQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uR1xaOLu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3HUchnWb DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716874870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=uR1xaOLuXJgO8F8luIHAiNPK/3HsTsZEkAuEdurxgU+uZkDfH5eamxVBPnLxSktxjLhp4b 6EtlDxr/L3apbAbUHFM6/Y8mrKutJWTUc5x/iwRhYTgBT7A/s6VJ8rWlWsmEcbWNu7PQUu sRNOuGDBwZaVY7Oz/1onnvHHRqfh4TM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716874870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=3HUchnWb1qnsO5VRZyCjhJYFR1JJZKtwmuj891qHdYQ8GM3LDJGZKJj2LS83aK0EZe2TKo fFjscNHWXFVgaFDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C316013A55; Tue, 28 May 2024 05:41:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rjv6LHVuVWYIdwAAD6G6ig (envelope-from ); Tue, 28 May 2024 05:41:09 +0000 Date: Tue, 28 May 2024 07:41:08 +0200 From: Oscar Salvador To: Christophe Leroy Subject: Re: [RFC PATCH v4 03/16] mm: Provide mm_struct and address to huge_ptep_get() Message-ID: References: <941ae68c7813cafc7aee3f34131f895fb7599636.1716815901.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <941ae68c7813cafc7aee3f34131f895fb7599636.1716815901.git.christophe.leroy@csgroup.eu> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 4D93921FE5 X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-6.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; DWL_DNSWL_MED(-2.00)[suse.de:dkim]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; MISSING_XM_UA(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[linux-foundation.org,nvidia.com,redhat.com,ellerman.id.au,gmail.com,vger.kernel.org,kvack.org,lists.ozlabs.org]; RCPT_COUNT_SEVEN(0.00)[9]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Nicholas Piggin , linux-mm@kvack.org, Peter Xu , Jason Gunthorpe , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, May 27, 2024 at 03:30:01PM +0200, Christophe Leroy wrote: > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -547,7 +547,7 @@ static int gup_hugepte(struct vm_area_struct *vma, pte_t *ptep, unsigned long sz > if (pte_end < end) > end = pte_end; > > - pte = huge_ptep_get(ptep); > + pte = huge_ptep_get(vma->mm, addr, ptep); I looked again and I stumbled upon this. It should have been "vma->vm_mm". -- Oscar Salvador SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABC96C25B78 for ; Tue, 28 May 2024 05:41:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09D286B0082; Tue, 28 May 2024 01:41:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04D9B6B0083; Tue, 28 May 2024 01:41:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57786B0088; Tue, 28 May 2024 01:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C1B186B0082 for ; Tue, 28 May 2024 01:41:14 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 71B26A02C5 for ; Tue, 28 May 2024 05:41:14 +0000 (UTC) X-FDA: 82166706468.20.20BEA26 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf22.hostedemail.com (Postfix) with ESMTP id 39EFEC000E for ; Tue, 28 May 2024 05:41:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uR1xaOLu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3HUchnWb; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uR1xaOLu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3HUchnWb; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716874872; a=rsa-sha256; cv=none; b=du09lKGCwDnngRlSa4dZ/qdPbeJhJFGO2vwVp6jXUy0qnXWvrfkB/BrGEt447jf+Jf2pFf 4edbP9fO5ZedRs7Z4B4RKMs3OH3D6eVwBW1OP3Fs6v/wtQyYTE/MdcdhOfYpgHrlbs/EcJ YwOgNM8SR5FD5tzOPSuZZLhYRwTtB4U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uR1xaOLu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3HUchnWb; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=uR1xaOLu; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3HUchnWb; spf=pass (imf22.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716874872; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=UbXw53DqNwak3THNFXTU+cXu206xiO2YxUNjMnEF5iztjY9uPuKik2IDMgdCIw7Jccg51u 8les5iUoEYhJT7zbNsUq5IaDU707vULbPldVO58m2JdZ2ykMdAPIfXE0ovLX4kyPZM9KLc pe5ItsD7jMITEdl065BP0QcHERjpHbg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4D93921FE5; Tue, 28 May 2024 05:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716874870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=uR1xaOLuXJgO8F8luIHAiNPK/3HsTsZEkAuEdurxgU+uZkDfH5eamxVBPnLxSktxjLhp4b 6EtlDxr/L3apbAbUHFM6/Y8mrKutJWTUc5x/iwRhYTgBT7A/s6VJ8rWlWsmEcbWNu7PQUu sRNOuGDBwZaVY7Oz/1onnvHHRqfh4TM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716874870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=3HUchnWb1qnsO5VRZyCjhJYFR1JJZKtwmuj891qHdYQ8GM3LDJGZKJj2LS83aK0EZe2TKo fFjscNHWXFVgaFDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1716874870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=uR1xaOLuXJgO8F8luIHAiNPK/3HsTsZEkAuEdurxgU+uZkDfH5eamxVBPnLxSktxjLhp4b 6EtlDxr/L3apbAbUHFM6/Y8mrKutJWTUc5x/iwRhYTgBT7A/s6VJ8rWlWsmEcbWNu7PQUu sRNOuGDBwZaVY7Oz/1onnvHHRqfh4TM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1716874870; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HvLg3YcfOytUXK8s+9klAigf80meSg65jI1M6X+di9Y=; b=3HUchnWb1qnsO5VRZyCjhJYFR1JJZKtwmuj891qHdYQ8GM3LDJGZKJj2LS83aK0EZe2TKo fFjscNHWXFVgaFDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C316013A55; Tue, 28 May 2024 05:41:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id rjv6LHVuVWYIdwAAD6G6ig (envelope-from ); Tue, 28 May 2024 05:41:09 +0000 Date: Tue, 28 May 2024 07:41:08 +0200 From: Oscar Salvador To: Christophe Leroy Cc: Andrew Morton , Jason Gunthorpe , Peter Xu , Michael Ellerman , Nicholas Piggin , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [RFC PATCH v4 03/16] mm: Provide mm_struct and address to huge_ptep_get() Message-ID: References: <941ae68c7813cafc7aee3f34131f895fb7599636.1716815901.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <941ae68c7813cafc7aee3f34131f895fb7599636.1716815901.git.christophe.leroy@csgroup.eu> X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 39EFEC000E X-Stat-Signature: bokoyegyqjb8kyna9egjc16ya8k9unpi X-HE-Tag: 1716874871-521856 X-HE-Meta: U2FsdGVkX19wiXPEGXgjlH7nhEDgPztnq8gaWgClN25n/zmhBudTYt5tAB/7oODRuY+W5w22yMkeJOXyCv83KPGhMo3oo8P9vVw5tg3klYHrIePdhdGB+MCEgNEjmo1snYF1jMpt8rk3wL33JaCMpPXmK2Z8KazpJou9VGdp3LHOELF+0UTqNNwDS8FQmLSSwNuu+7neWuHAwlmQz8plC5KYruFRQYbBWs9EJ/D68qAwSvOxHY8WRDjlazzC7/xuH5VyEKoK+YmrOTM+Q3w+y158htJLXZkyydWbhDfjW65+dZxuyVGd8ryb4Ds0LUx1tbepSxCR4ytrsfqK3nsT0GNRSSwHabBpGDf1w+uLEJd+68jio504vyLRvC8wFkg2L12hVM3Jpqh7vzhYe24PBwuoMkQooFOaHo4X7qs4yPNavV3yKPt76wXfpzKlLj5jBVA3ZQn/HBmMp87ExvETsWZqDU0/BTVqfBohSpQsD1VPjl36Sd1G1PQEuCX+VdZNQ3j5QX3HhPpFAMDsfp3KUaavvXXMgYhGrakFhV8dhdIDAU453LooXzGM6U+Hjwex3kqxvoUp0UjbOylKE/fe5R8YDAfbRBhWainGaMUggl/sQQz+EQA+I9/lLKv5giAm0I87SowKpzzZcB7bp48SDLlb0f2Y/An9YBQctrTObR2L1X1Vae8LSwXy+h67emzd9BWsRcb47TZ4AsVlfX5vHbQcCKxS6nsTwkzl+u/law6gHvnM2u23ZmAg6G1sg98TpiuAINcP/DsYZC1U7E1m9TPKR0NgsovLr06LqKpXKR2K89eX6zMF1Pz9rztBVq2BDWkfdSBUEWfsVbAAO/cZFdb4ycZQPpglO/cSoeBg2vUlWVVb09KVHsTeOn8AmxvS8IjqRwO2Jgo9rVk7xo16VkpPGrS/ms6UMGgvZbZpIVG1HSeMj468nD+ELmK15QFRDE00ZSscUbLjom/HnVv zO8OMaIB cksyj4viaYLYExXvWb/jJKLtDFhpzeW77S2g0uuBk9Mif7z6ktK7h3c9UE4hWG8GehJO4AQVbNJK5/7EVZ+xu0WRjlMXnl/hpiyDMgzFQHZh5W1acsMeOK6cGJ21ClPzIkn5rzLb12K0+vd/ccUk9Zg+yTFvrf+u5JHdvljRmAhO5J0iqrKUJQ5As0pfGi7POVibsHEPBIZSPJfG3LFEmhOvJr3+cztK8yklrqbwd9GbwCCA9lrj1bgX+KjEciL3VHbaY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000065, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, May 27, 2024 at 03:30:01PM +0200, Christophe Leroy wrote: > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -547,7 +547,7 @@ static int gup_hugepte(struct vm_area_struct *vma, pte_t *ptep, unsigned long sz > if (pte_end < end) > end = pte_end; > > - pte = huge_ptep_get(ptep); > + pte = huge_ptep_get(vma->mm, addr, ptep); I looked again and I stumbled upon this. It should have been "vma->vm_mm". -- Oscar Salvador SUSE Labs