From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC net-next 1/3] net: stmmac: Prevent RGSMIIIS IRQs flood
Date: Tue, 28 May 2024 11:24:30 +0100 [thread overview]
Message-ID: <ZlWw3hJdOARzdl2S@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240524210304.9164-1-fancer.lancer@gmail.com>
On Sat, May 25, 2024 at 12:02:57AM +0300, Serge Semin wrote:
> Without reading the GMAC_RGSMIIIS/MAC_PHYIF_Control_Status the IRQ line
> won't be de-asserted causing interrupt handler executed over and over. As
> a quick-fix let's just dummy-read the CSR for now.
>
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
I think it would make sense to merge these into the patches that do the
conversion to avoid a git bisect hitting on a patch that causes an
interrupt storm. Any objection?
(I'm now converting these two in separate patches, so would need to
split this patch...)
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC net-next 1/3] net: stmmac: Prevent RGSMIIIS IRQs flood
Date: Tue, 28 May 2024 11:24:30 +0100 [thread overview]
Message-ID: <ZlWw3hJdOARzdl2S@shell.armlinux.org.uk> (raw)
In-Reply-To: <20240524210304.9164-1-fancer.lancer@gmail.com>
On Sat, May 25, 2024 at 12:02:57AM +0300, Serge Semin wrote:
> Without reading the GMAC_RGSMIIIS/MAC_PHYIF_Control_Status the IRQ line
> won't be de-asserted causing interrupt handler executed over and over. As
> a quick-fix let's just dummy-read the CSR for now.
>
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
I think it would make sense to merge these into the patches that do the
conversion to avoid a git bisect hitting on a patch that causes an
interrupt storm. Any objection?
(I'm now converting these two in separate patches, so would need to
split this patch...)
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-28 10:24 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-12 16:28 [PATCH RFC 0/6] net: stmmac: convert stmmac "pcs" to phylink Russell King (Oracle)
2024-05-12 16:28 ` Russell King (Oracle)
2024-05-12 16:28 ` [PATCH RFC net-next 1/6] net: stmmac: convert sgmii/rgmii " Russell King (Oracle)
2024-05-12 16:28 ` Russell King (Oracle)
2024-05-12 16:29 ` [PATCH RFC net-next 2/6] net: stmmac: remove pcs_ctrl_ane() method and associated code Russell King (Oracle)
2024-05-12 16:29 ` Russell King (Oracle)
2024-05-13 4:13 ` kernel test robot
2024-05-13 5:15 ` kernel test robot
2024-05-25 4:13 ` kernel test robot
2024-05-25 4:24 ` kernel test robot
2024-05-12 16:29 ` [PATCH RFC net-next 3/6] net: stmmac: remove pcs_rane() method Russell King (Oracle)
2024-05-12 16:29 ` Russell King (Oracle)
2024-05-12 16:29 ` [PATCH RFC net-next 4/6] net: stmmac: remove calls to stmmac_pcs_get_adv_lp() Russell King (Oracle)
2024-05-12 16:29 ` Russell King (Oracle)
2024-05-12 16:29 ` [PATCH RFC net-next 5/6] net: stmmac: remove pcs_get_adv_lp() method and associated code Russell King (Oracle)
2024-05-12 16:29 ` Russell King (Oracle)
2024-05-12 16:29 ` [PATCH RFC net-next 6/6] net: stmmac: remove old pcs interrupt functions Russell King (Oracle)
2024-05-12 16:29 ` Russell King (Oracle)
2024-05-13 23:04 ` [PATCH RFC 0/6] net: stmmac: convert stmmac "pcs" to phylink Serge Semin
2024-05-13 23:04 ` Serge Semin
2024-05-13 23:21 ` Russell King (Oracle)
2024-05-13 23:21 ` Russell King (Oracle)
2024-05-13 23:53 ` Serge Semin
2024-05-13 23:53 ` Serge Semin
2024-05-24 23:54 ` Serge Semin
2024-05-24 23:54 ` Serge Semin
2024-05-24 21:02 ` [PATCH RFC net-next 1/3] net: stmmac: Prevent RGSMIIIS IRQs flood Serge Semin
2024-05-24 21:02 ` Serge Semin
2024-05-24 21:02 ` [PATCH RFC net-next 2/3] net: stmmac: Activate Inband/PCS flag based on the selected iface Serge Semin
2024-05-24 21:02 ` Serge Semin
2024-05-26 16:49 ` Russell King (Oracle)
2024-05-26 16:49 ` Russell King (Oracle)
2024-05-26 18:00 ` Russell King (Oracle)
2024-05-26 18:00 ` Russell King (Oracle)
2024-05-28 13:19 ` Serge Semin
2024-05-28 13:19 ` Serge Semin
2024-05-28 14:13 ` Russell King (Oracle)
2024-05-28 14:13 ` Russell King (Oracle)
2024-05-28 16:21 ` Russell King (Oracle)
2024-05-28 16:21 ` Russell King (Oracle)
2024-05-31 19:11 ` Serge Semin
2024-05-31 19:11 ` Serge Semin
2024-05-31 17:13 ` Serge Semin
2024-05-31 17:13 ` Serge Semin
2024-05-31 19:30 ` Russell King (Oracle)
2024-05-31 19:30 ` Russell King (Oracle)
2024-06-02 23:25 ` Serge Semin
2024-06-02 23:25 ` Serge Semin
2024-05-26 21:57 ` Serge Semin
2024-05-26 21:57 ` Serge Semin
2024-05-28 10:21 ` Russell King (Oracle)
2024-05-28 10:21 ` Russell King (Oracle)
2024-05-28 12:22 ` Serge Semin
2024-05-28 12:22 ` Serge Semin
2024-05-24 21:02 ` [PATCH RFC net-next 3/3] net: stmmac: Drop TBI/RTBI PCS flags Serge Semin
2024-05-24 21:02 ` Serge Semin
2024-05-28 10:23 ` Russell King (Oracle)
2024-05-28 10:23 ` Russell King (Oracle)
2024-05-28 12:23 ` Serge Semin
2024-05-28 12:23 ` Serge Semin
2024-05-28 10:24 ` Russell King (Oracle) [this message]
2024-05-28 10:24 ` [PATCH RFC net-next 1/3] net: stmmac: Prevent RGSMIIIS IRQs flood Russell King (Oracle)
2024-05-28 12:20 ` Serge Semin
2024-05-28 12:20 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZlWw3hJdOARzdl2S@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexandre.torgue@foss.st.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=hawk@kernel.org \
--cc=joabreu@synopsys.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.