From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12CD616F291 for ; Tue, 28 May 2024 18:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716922465; cv=none; b=CBhTG4Z3xyd0CmkpiTGDRRkRA/eRFpicjFLVJ4V+VloGw4/p2dBmhkxUJVEGlpUmHHEJ0kiKYSJEuVChPpmfrvo0BpU1fSdwnDvPSZX6ARs40UTmmpz58VC10bjm3HKq4Qf0s467qreRMdN9b0onZFjf3/lOm3hkP7qDl7HloK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716922465; c=relaxed/simple; bh=XjKB9lMK3weOkRqQznxEfeDYvHTiHYFA26fDuZyRHLU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Qv29BCIttS3YqKaYnFYRbGIkTkbed54eML1CFG+nquySZ2XASUMJTaRn5UCewCLMX/RnmeRlcl4etj/+Yt2EZ42NbO84HKKliT7NQYOa9btPqOBuXdRDZWtxK10kWlbjbOzn9mumXeuDxf+XmdiypvQS61XHC894Z2VfdX0axiY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uRbUt9YL; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uRbUt9YL" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-6819735bfc4so1150909a12.2 for ; Tue, 28 May 2024 11:54:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716922463; x=1717527263; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vF5iO2/CLnl6BCwM18Rm/a6cGRlrHRV+x/d0GOpSVW4=; b=uRbUt9YLagloMhdkm6dV0Vo6AtTRPxZf1nnGH5X/3zaoB24JeN81XVTFgLsiosh/Qk oaW0RwTL/V5gqimd7kyZCzU8OkpMtWvrjGXJ5kZ/SuYYRsDIkrSG+1y2rwlJyYgLt/8j hbBpH6ZO51eDqhvmu6x1/WWTywgr6Wnow+fXKxDWr3xU+CxwSeT4Q7NuOV1arE1XJpAO Nq+HwwTdSwt6aTZSp6w6WwY7bsc95Q9FhunT81zxiI7LBqLhD16BtKbnnuhBTbXJZADO UliZHn33A64tqZcLht6EfoIAeYjjE4b+iLizaW3IvpkOY7MLRwz7Iws23dxJIaLWS2nR 1MfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716922463; x=1717527263; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vF5iO2/CLnl6BCwM18Rm/a6cGRlrHRV+x/d0GOpSVW4=; b=rySGaAb2IBLMOG0/jnRFpah/7fz6O+vjdxDmfeFXQEqWfaA8Bt1A+nHQK0bSjDXu1v X3adS1F2XGT49EMHWsrnVxwiZ+0ndcL76Z5F/pjWtTCZyfYWIilbeAPy7Dn93xiTgR6n Q2vo/fbXv0GI0nhhVv94WMBisqseBVWvkfx7JMybRDnGPCJPAnNezgORKEybFSghVdED gN/QHsNXQh2KtviRUclMeVCSWmih1AwmIONNuisx0QwKm0Y+pA7h4BLXzItmObuBZhDw rp5tx7ZSwdxvvmeqTxCHdgYx2LcRy2b6LL+VC5lXrmPzSPdQqUVg9Dm5BwVseOqqkuvk lV9Q== X-Forwarded-Encrypted: i=1; AJvYcCU9ymKsWkfI9P4nM1jbGpn77VY+07p3+gtAoVF3h5/l1rySiIVu5dHLrLypMSlfHOa7ASGkV4p3N+kWGHpvLuBSWfE6 X-Gm-Message-State: AOJu0YwplZPpCj4k/gQLMLjp3Vv7XDBtV13rVAm1oXe3/W/Kw/5lEHne PAjt6AEPaAulPX3ii1Dgl6s2aXAHYr3oOe7hQdXfaUwK2Y45ZdVHvJPia6hx8bLLlJ8TPYvXieb miA== X-Google-Smtp-Source: AGHT+IHZ8xHJVep2OJ2nfEnf3wxs4HlLEBkQLwwY9dzNuA2RoPiVORZFKSEwyGSnVgAX+c5WpSrZJsRNY3g= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:778c:0:b0:65c:2c22:111 with SMTP id 41be03b00d2f7-681ad64b81dmr36484a12.8.1716922463270; Tue, 28 May 2024 11:54:23 -0700 (PDT) Date: Tue, 28 May 2024 11:54:21 -0700 In-Reply-To: <7ed7f3b7-4970-4723-8969-6452aed41b01@linux.intel.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240517173926.965351-1-seanjc@google.com> <20240517173926.965351-21-seanjc@google.com> <7ed7f3b7-4970-4723-8969-6452aed41b01@linux.intel.com> Message-ID: Subject: Re: [PATCH v2 20/49] KVM: x86: Rename kvm_cpu_cap_mask() to kvm_cpu_cap_init() From: Sean Christopherson To: Binbin Wu Cc: Paolo Bonzini , Vitaly Kuznetsov , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Hou Wenlong , Kechen Lu , Oliver Upton , Maxim Levitsky , Yang Weijiang , Robert Hoo Content-Type: text/plain; charset="us-ascii" On Wed, May 22, 2024, Binbin Wu wrote: > On 5/18/2024 1:38 AM, Sean Christopherson wrote: > > Rename kvm_cpu_cap_mask() to kvm_cpu_cap_init() in anticipation of merging > > it with kvm_cpu_cap_init_kvm_defined(), and in anticipation of _setting_ > > bits in the helper (a future commit will play macro games to set emulated > > feature flags via kvm_cpu_cap_init()). > > > > No functional change intended. > > > > Signed-off-by: Sean Christopherson > > --- > > arch/x86/kvm/cpuid.c | 36 ++++++++++++++++++------------------ > > 1 file changed, 18 insertions(+), 18 deletions(-) > > > > diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c > > index a802c09b50ab..5a4d6138c4f1 100644 > > --- a/arch/x86/kvm/cpuid.c > > +++ b/arch/x86/kvm/cpuid.c > > @@ -74,7 +74,7 @@ u32 xstate_required_size(u64 xstate_bv, bool compacted) > > * Raw Feature - For features that KVM supports based purely on raw host CPUID, > > * i.e. that KVM virtualizes even if the host kernel doesn't use the feature. > > * Simply force set the feature in KVM's capabilities, raw CPUID support will > > - * be factored in by kvm_cpu_cap_mask(). > > + * be factored in by __kvm_cpu_cap_mask(). > > kvm_cpu_cap_init()? Drat, yes. IIRC, I tried to get clever to avoid having to update this comment a second time, but then I ended up removing __kvm_cpu_cap_mask() entirely.