From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 28 May 2024 12:16:11 -0700 Subject: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() In-Reply-To: References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, May 24, 2024, Kai Huang wrote: > > @@ -1548,6 +1548,9 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > struct vcpu_svm *svm = to_svm(vcpu); > > struct svm_cpu_data *sd = per_cpu_ptr(&svm_data, cpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > [...] > > > @@ -1517,6 +1517,9 @@ void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > { > > struct vcpu_vmx *vmx = to_vmx(vcpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > Nit: Perhaps we need a kvm_x86_ops::shrink_ple_window()? :-) Heh, that duplicate code annoys me too. The problem is the "old" window value comes from the VMCS/VMCB, so either we'd end up with multiple kvm_x86_ops, or we'd only be able to consolidate the scheduled_out + kvm_pause_in_guest() code, which isn't all that interesting. Aha! Actually, VMX already open codes the functionality provided by VCPU_EXREG_*, e.g. has vmx->ple_window_dirty. If we add VCPU_EXREG_PLE_WINDOW, then the info get be made available to common x86 code without having to add new hooks. And that would also allow moving the guts of handle_pause()/pause_interception() to common code, i.e. will also allow deduplicating the "grow" side of things. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f202.google.com (mail-yw1-f202.google.com [209.85.128.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C678174EFE for ; Tue, 28 May 2024 19:16:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716923775; cv=none; b=QU2TpRygUq+3RRNYuO3jT/1WZp+VhZQ8zZdy2iLluhAx22ejmTwjeEuZGdq5cYbFM+SRtJLWQeKQBdFU6LibkexCG3omzD/aNMkvgG44ZdnVZMpxfecV9+QfzlS2/9RcaWeP+HgHCdBYSHmIzFd/Bp0jcCKOTH6OdpwYIWj1UIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716923775; c=relaxed/simple; bh=ag7+h70RDNCub6CI9FhMvv9doD/tLeJlJWjTiOiUnAE=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Mzn8QAst0DgPIr0YSMwqqGnbp4dt8rcNGDKS/4ScrraPq4OIv/jgjQmVGfZhD6WoBXrGs1lpjrnZoqUlb2o6CKM6mlGw/vqoL5ptUZhR0tSPLTHJtgJMgCTdmcp1mUFtLrUUtO+LEoJtoid/eSzkb1pchclPHM3DpaYKn6XUjBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gG9tTlJE; arc=none smtp.client-ip=209.85.128.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gG9tTlJE" Received: by mail-yw1-f202.google.com with SMTP id 00721157ae682-62a0841402aso18849967b3.2 for ; Tue, 28 May 2024 12:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716923773; x=1717528573; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=aN1FoCckBsPH3nlr2F+fxU8+3rgvDDBf83ZZTupmDzY=; b=gG9tTlJErS+oT2HDHWYgold3kB/o6Y+H+3tA/Vo8X2ZYgopcNs2QWDw0PTzLlRa1pK u9NUIZ3IRKqjFliwRkJTEDJYOaZgve1G44nwbM8DvHNe6Mi/1t+vmXr9ra+9l11YNOpR nzCXq8J+cs1BHPVE2kUWAuC3Prsu5DhOTOjAHJHKnjflLaLD7NLzJROC+tZRf8YAAB2k DlG/TXGQWSkqRCwjZM9vdZ0Nb8P6P4jQcuf4AJWDOPT9sljZIXmwNONmEDUs98gJ/y9s BPhlTO3x7pzU9VOKH+gvUXyq4JOxEN96Trr+FHmpmYOL8dAKeVJ/0OmK1Qz5qd8NYe0N RZkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716923773; x=1717528573; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aN1FoCckBsPH3nlr2F+fxU8+3rgvDDBf83ZZTupmDzY=; b=XuHRF1Ap1TgYOGPdAL4Ugn+uil0xGx8tV7BhT2J16rgdxfpBYPfNiV0feqDOmPRgm7 QKN2Io/KPL/goA4XSEt+hu0tJjVeQePW9BzPEV4TBEFL6cCZTWs/v9alB3bsqkUclzEK cdBauufn2PS0qTj3OtSwFf2RcQ+NUDxJn3Xi7aC0lHA4i7EjbtOtOAfE2QJTnsytUVju yfncPv8YY3ISqJj+NEdFWvBuBUPgcctj8aPZjj+yVJuH1EdEw34PcsHecc3hyQgleWnA 72LkbMwM/LRYSO8SIjK6GD02a0W+o3NPfQLTHX/AqRhGSd3HAcF5h6JKlYiyd1n1+AXY S+IA== X-Forwarded-Encrypted: i=1; AJvYcCUjYbnRGQNGZDHJ9TpxRQp3LKd7dt2HO5rt+R2P5Hv3346zyAfHakVt81gV1CeZ3u40lqe+a4xfjBGcBcppFijk2vgIF4mW X-Gm-Message-State: AOJu0Yz1l4pqq728Y3vTpgPwcB9rJiYuyTi12DeliefPFq2QViabF8fB 2E1ugEUYRviSUevxEr+hWXSVWqv1atO92Zl+8Csy/IGqEAigM6xiof5bxo2uO4tVuyPwZvfJlic Nkw== X-Google-Smtp-Source: AGHT+IEYffSoUdZ4cg7KX8v+KoP4uvokISlIeu5qUtxtXAQ85EyWGJZei7jVgr6jZvnufr8gfWsoMUgR1K8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10c3:b0:df7:943d:f935 with SMTP id 3f1490d57ef6-df7943e55a0mr788014276.2.1716923773190; Tue, 28 May 2024 12:16:13 -0700 (PDT) Date: Tue, 28 May 2024 12:16:11 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> Message-ID: Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() From: Sean Christopherson To: Kai Huang Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Fri, May 24, 2024, Kai Huang wrote: > > @@ -1548,6 +1548,9 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > struct vcpu_svm *svm = to_svm(vcpu); > > struct svm_cpu_data *sd = per_cpu_ptr(&svm_data, cpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > [...] > > > @@ -1517,6 +1517,9 @@ void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > { > > struct vcpu_vmx *vmx = to_vmx(vcpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > Nit: Perhaps we need a kvm_x86_ops::shrink_ple_window()? :-) Heh, that duplicate code annoys me too. The problem is the "old" window value comes from the VMCS/VMCB, so either we'd end up with multiple kvm_x86_ops, or we'd only be able to consolidate the scheduled_out + kvm_pause_in_guest() code, which isn't all that interesting. Aha! Actually, VMX already open codes the functionality provided by VCPU_EXREG_*, e.g. has vmx->ple_window_dirty. If we add VCPU_EXREG_PLE_WINDOW, then the info get be made available to common x86 code without having to add new hooks. And that would also allow moving the guts of handle_pause()/pause_interception() to common code, i.e. will also allow deduplicating the "grow" side of things. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64EB8C25B7C for ; Tue, 28 May 2024 19:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=BTu3Uzs7cmyJ7w3uiOhNmKxNR9a2MxUwjSYuzx8DLN0=; b=qrd7KIPiQN3LJ30BZEbZIUdP5u SWHJEfqOOw10SYfHYuwyrwjKNzB+e+0nzBtJejf1S2Lb9JG6m2Vf1doiFsGbxz2cDysOMLiaSvcTI fpWFWDDFkP717r0LTlnd0X8638qZcyJ6YvYUoahCRg0jhJXym9aYqnoSQFGm9MPMiTfBnqnXDkDdE daRy53gTxG5Zcwcw7r+Yl9CK7G8Zeiyli6bdFHP5hPSbA/3K2cZw3IyYf+eVfi/XiJvnmHY0AmR0f +5qrR0t533DV+EAvNrASZeJeZt4SpgGn7vT8Ywm0WRaIjPLmRNn2psR5Barm3yDmDgrRnPVzOJ5qP mJPMorHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sC2J1-00000001n1F-090k; Tue, 28 May 2024 19:16:19 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sC2Iy-00000001my4-06iQ for linux-riscv@lists.infradead.org; Tue, 28 May 2024 19:16:17 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-62777fe7b86so16952387b3.1 for ; Tue, 28 May 2024 12:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716923773; x=1717528573; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=aN1FoCckBsPH3nlr2F+fxU8+3rgvDDBf83ZZTupmDzY=; b=4q8gr4cbJIuH59Eol9cXvLj0/T2KFUv+r5itMAIp/7A40gRZSO8kCKUbEouZlildrA SgNPfOd65omjZnAKBSKYGkN00ZK+TMvPyWwJZxcKc1kB1H8rc3cM/x6FXP2W4D93Sk2d dBOnDuGlvduIAlCFIaBL3Mpp9rcU2/cyXEA1MzDVkzcoh5J+gNXyOJmcAi6DU+qtGdeQ zgoBmCIGJrQiQMYH0PAUcuS1+s/ObGoZ8UoGAVoLbOBdb0bRgfk8i7LfUbQ/Nkpm90f/ DTb+v3oINlCqian8fLOEfmer5NzMpzr3zGqACvkSbiuD9PmcUACSeEhxz4YSgN+iGFDj cluw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716923773; x=1717528573; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aN1FoCckBsPH3nlr2F+fxU8+3rgvDDBf83ZZTupmDzY=; b=qBq+LHeCjeXAYukNJF2XS/vmZzpjxh9PqQnJWWQGzsunlgzFsXKkKgVn1WOI9q1Z3a qEKSgpgVXzpD7QfVi7DHsBDCmuIpflqOhq/15k7g0YkYuyBkRFb9/H7IpjwwOdmUaW6z ZoyiPsSMrtUHP3PJIiM72vmpkeWzBIshXdxq1lIkS7YfJ2sIVzSa5dAjYYOjXxfItTQl Ml7WbXe7+aJWZkfSjZgZT3RLJhHUVAvy/WTdGMRWz9C/AJeYvKpAKAOjsP9W9GqR5P8K eboLPB1R7zf57E8LPwZo9K5cwBW9Q6JHyK+vzVT2bZ4X1U0j4b4Q5zbgPTKoVpdcDorR 2W+Q== X-Forwarded-Encrypted: i=1; AJvYcCViBH+ZQ1AxvJjLRZ8ZMoMVI/6/5FxbukTJ7icqmGDwx8eqPf0gD/xoOFjjsFIdTOkPZus++JYou+hTmuSzWaLAT6ZNSCQVdIkZvbzVXBWq X-Gm-Message-State: AOJu0YzxJU4TJLv9VQty5dXo/kDQkZG+cepXF/4SeMpQ7kqL4QqMmvfX T+6c0UwvHBc33hAnFVasHnfw45AfRBym0AbCWOm1XyYMwGWTGVk/K8rLKNMsV95lesDyL05sQJm dzA== X-Google-Smtp-Source: AGHT+IEYffSoUdZ4cg7KX8v+KoP4uvokISlIeu5qUtxtXAQ85EyWGJZei7jVgr6jZvnufr8gfWsoMUgR1K8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10c3:b0:df7:943d:f935 with SMTP id 3f1490d57ef6-df7943e55a0mr788014276.2.1716923773190; Tue, 28 May 2024 12:16:13 -0700 (PDT) Date: Tue, 28 May 2024 12:16:11 -0700 In-Reply-To: Mime-Version: 1.0 References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> Message-ID: Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() From: Sean Christopherson To: Kai Huang Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_121616_095570_0C1C376D X-CRM114-Status: GOOD ( 11.38 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, May 24, 2024, Kai Huang wrote: > > @@ -1548,6 +1548,9 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > struct vcpu_svm *svm = to_svm(vcpu); > > struct svm_cpu_data *sd = per_cpu_ptr(&svm_data, cpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > [...] > > > @@ -1517,6 +1517,9 @@ void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > { > > struct vcpu_vmx *vmx = to_vmx(vcpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > Nit: Perhaps we need a kvm_x86_ops::shrink_ple_window()? :-) Heh, that duplicate code annoys me too. The problem is the "old" window value comes from the VMCS/VMCB, so either we'd end up with multiple kvm_x86_ops, or we'd only be able to consolidate the scheduled_out + kvm_pause_in_guest() code, which isn't all that interesting. Aha! Actually, VMX already open codes the functionality provided by VCPU_EXREG_*, e.g. has vmx->ple_window_dirty. If we add VCPU_EXREG_PLE_WINDOW, then the info get be made available to common x86 code without having to add new hooks. And that would also allow moving the guts of handle_pause()/pause_interception() to common code, i.e. will also allow deduplicating the "grow" side of things. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA7EC25B78 for ; Tue, 28 May 2024 19:26:47 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=AKQlHxLL; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vpj1s30KPz79xS for ; Wed, 29 May 2024 05:17:05 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=AKQlHxLL; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::b4a; helo=mail-yb1-xb4a.google.com; envelope-from=3fs1wzgykdgoamivrkowwotm.kwutqvcfxxk-lmdtqaba.whtija.wzo@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Vpj120p8Tz78kx for ; Wed, 29 May 2024 05:16:20 +1000 (AEST) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-df771bdee6bso1938258276.3 for ; Tue, 28 May 2024 12:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716923773; x=1717528573; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=aN1FoCckBsPH3nlr2F+fxU8+3rgvDDBf83ZZTupmDzY=; b=AKQlHxLLHHSP/1M1B1O7A3VgoccKAHguQKmoDLiZyFP/Y1QZRBc0ttvIx+fOWd2IdA TRxSkI1ntOnK4lQZNOXjsttASzWM8nNsLOAdeq+Fd+8sYn5Y4HSIEyQEtmyc/gAnLbu8 tOWHUcG2DjvziGfd4p+QEXbBuuvWbckr5aSe5EqORE8E86tHtzPOIknAj2RLQ+r4oPYc ticHtCW3hGe/fSGeIUwUdS+zfAYGmtwvhoAtbZJHJjJMmrn2CaaGDwKzKftzf6MWAkdh CeqjjFH9/82oRE1TYnHv684Z6YixAW5R+6dtUPbqyT/4nHbqrxBlQaarBv416LqGoe3h iR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716923773; x=1717528573; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aN1FoCckBsPH3nlr2F+fxU8+3rgvDDBf83ZZTupmDzY=; b=gRTiKK8j6upUKPok9eP5w5jRb9aUaJwlQTXHV/D1aHqHOcPRjW3/1a/uM+DVJfuUKj Us34XnwRq+LfaTwGij0VQTxX8XofRkCkV0lqv/ODargxYhbws/oHt24bLCc9QBRunSjW Dqm0DEDsAIeF7t4erSu6IzRJyBUS8SXbNKRaKi5YhiUEe8isoxdqj8B1AM/p0fylb6gg yvJfZ0kjFDmeaDoZZkIjM7lNurKmUqtKt9kI0MILIuaEkRy09RN0hjBIFgyCxAJZbwvC sBZexjchLaG9636PByP4QIfEhl5GT6QyoXL3CJtvJpoz6aN2vUjSv2iellKuJj43WBtm mAKA== X-Forwarded-Encrypted: i=1; AJvYcCX9uq9HoufrefkRcLBtKuMCMzUVNqaPmQrlTnSNkWMLuKyI/DQ4ahi/pP98BUiVd75n24HEiAtAGrPLrIFkAFMjNmtTsNpcgEkxOoqzbw== X-Gm-Message-State: AOJu0YyUuvfuAS/n3Zj46/W/5kcmkFEmly7UQAbt9Msv3EhrbN266B4J OkoVlEoGNhxb71CG/koFAEvLilBBooOwfr7TKdvGERmN6Ln1E76RPac0/uw2jhdoaxqTktZ1ouq k5Q== X-Google-Smtp-Source: AGHT+IEYffSoUdZ4cg7KX8v+KoP4uvokISlIeu5qUtxtXAQ85EyWGJZei7jVgr6jZvnufr8gfWsoMUgR1K8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10c3:b0:df7:943d:f935 with SMTP id 3f1490d57ef6-df7943e55a0mr788014276.2.1716923773190; Tue, 28 May 2024 12:16:13 -0700 (PDT) Date: Tue, 28 May 2024 12:16:11 -0700 In-Reply-To: Mime-Version: 1.0 References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> Message-ID: Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() From: Sean Christopherson To: Kai Huang Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Claudio Imbrenda , Marc Zyngier , Janosch Frank , Huacai Chen , Christian Borntraeger , Albert Ou , Bibo Mao , loongarch@lists.linux.dev, Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, Oliver Upton , Palmer Dabbelt , kvm-riscv@lists.infradead.org, Anup Patel , Paolo Bonzini , Tianrui Zhao , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, May 24, 2024, Kai Huang wrote: > > @@ -1548,6 +1548,9 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > struct vcpu_svm *svm = to_svm(vcpu); > > struct svm_cpu_data *sd = per_cpu_ptr(&svm_data, cpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > [...] > > > @@ -1517,6 +1517,9 @@ void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > { > > struct vcpu_vmx *vmx = to_vmx(vcpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > Nit: Perhaps we need a kvm_x86_ops::shrink_ple_window()? :-) Heh, that duplicate code annoys me too. The problem is the "old" window value comes from the VMCS/VMCB, so either we'd end up with multiple kvm_x86_ops, or we'd only be able to consolidate the scheduled_out + kvm_pause_in_guest() code, which isn't all that interesting. Aha! Actually, VMX already open codes the functionality provided by VCPU_EXREG_*, e.g. has vmx->ple_window_dirty. If we add VCPU_EXREG_PLE_WINDOW, then the info get be made available to common x86 code without having to add new hooks. And that would also allow moving the guts of handle_pause()/pause_interception() to common code, i.e. will also allow deduplicating the "grow" side of things. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4470C25B78 for ; Tue, 28 May 2024 19:16:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4gL9cSj+3Om11tCyv0XM/o+ULkWzzLGAXErfsSfnitQ=; b=pw+fiNPrr1orcfB+xz9ATVOWQn ByzyrrWmnJHvjik/02S14ajnBeZr5yVVeE7QDB5PxbaS52gta7BRFcyd+uYjqbPiCHNr56CN6DcXX 7IyDmHxv6fr3ftEdYiyDiC8dtEdm4Dh9mo9NhBk5UmY1LfQND02MAtfcDaMgIWj8+MhGjNZ+pTqAQ /ngbPCDpWX8bMIPKmqqINJJt8epx8EF1t+Ioz1Sk6qLy7KR5Qm39sWWtgrAMAdvqzf6Ht2gRobKAo 39AIjay+9Yj8zsI8XiN+JtCOdmFLUF6RNb0ia5+GlVZmgKx4+mvdlBAjNOPBBrj9+okTEDQKrMga+ aRZIXLwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sC2J1-00000001n1U-3kgb; Tue, 28 May 2024 19:16:19 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sC2Iy-00000001my2-04Dq for linux-arm-kernel@lists.infradead.org; Tue, 28 May 2024 19:16:17 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-df789a425d3so1931619276.2 for ; Tue, 28 May 2024 12:16:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716923773; x=1717528573; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=aN1FoCckBsPH3nlr2F+fxU8+3rgvDDBf83ZZTupmDzY=; b=4q8gr4cbJIuH59Eol9cXvLj0/T2KFUv+r5itMAIp/7A40gRZSO8kCKUbEouZlildrA SgNPfOd65omjZnAKBSKYGkN00ZK+TMvPyWwJZxcKc1kB1H8rc3cM/x6FXP2W4D93Sk2d dBOnDuGlvduIAlCFIaBL3Mpp9rcU2/cyXEA1MzDVkzcoh5J+gNXyOJmcAi6DU+qtGdeQ zgoBmCIGJrQiQMYH0PAUcuS1+s/ObGoZ8UoGAVoLbOBdb0bRgfk8i7LfUbQ/Nkpm90f/ DTb+v3oINlCqian8fLOEfmer5NzMpzr3zGqACvkSbiuD9PmcUACSeEhxz4YSgN+iGFDj cluw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716923773; x=1717528573; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aN1FoCckBsPH3nlr2F+fxU8+3rgvDDBf83ZZTupmDzY=; b=sQYI/HKstDtcDU7tyhdxBT70wq57C6fScui4URFcKwFiF/ZD9frCP8LmFZcw308vJi JG4FzWh0CVe5VDFDYhEErp/9yTrE+d2prRysd+JSvnTMlZjGI18fz1sQJa0+KABuVdXE yn7WrKnONQf9ERw1e9O+ypKd0BI2xMh42s/TK1ic2CxAcUpiNzcavppcSxxEjB9+jRBN cdjEdsnvNg9enx9vXMm18/h481xi1uRc9nvxjq3LB/9s9Rf1pck2JOdPNbV2pg90IMtQ dCUKyseTqLEIt1sU8ixU71LWjgvwc077t8yDfsTdUS3SWrjp0GnZY00elSzDisb/UbxZ ZyAQ== X-Forwarded-Encrypted: i=1; AJvYcCWuhqg0ZjuQvENVOkQVLSBkdJt2sy5CeeGjT3NgWnfnIfhWqh7FG1iqPkFy+woSe6X61aPu4an5IRKacMMV75BSeNw99OAYwb6wTlZYiTRZdQ+hGWc= X-Gm-Message-State: AOJu0YytNYeXess0C0oC71yM/FcvvNVJwWzOWp4zg/kgzHHmbdW2hThS D36HjWFC56CzQnAUUsJHuF/wPhtvOC+HgoQxErttkGN9RwV3fFQIQr5zbWYt8kD5vwi08BXMF9a 5iA== X-Google-Smtp-Source: AGHT+IEYffSoUdZ4cg7KX8v+KoP4uvokISlIeu5qUtxtXAQ85EyWGJZei7jVgr6jZvnufr8gfWsoMUgR1K8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10c3:b0:df7:943d:f935 with SMTP id 3f1490d57ef6-df7943e55a0mr788014276.2.1716923773190; Tue, 28 May 2024 12:16:13 -0700 (PDT) Date: Tue, 28 May 2024 12:16:11 -0700 In-Reply-To: Mime-Version: 1.0 References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> Message-ID: Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() From: Sean Christopherson To: Kai Huang Cc: Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Paolo Bonzini , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_121616_086993_9C838CBD X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 24, 2024, Kai Huang wrote: > > @@ -1548,6 +1548,9 @@ static void svm_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > struct vcpu_svm *svm = to_svm(vcpu); > > struct svm_cpu_data *sd = per_cpu_ptr(&svm_data, cpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > [...] > > > @@ -1517,6 +1517,9 @@ void vmx_vcpu_load(struct kvm_vcpu *vcpu, int cpu) > > { > > struct vcpu_vmx *vmx = to_vmx(vcpu); > > + if (vcpu->scheduled_out && !kvm_pause_in_guest(vcpu->kvm)) > > + shrink_ple_window(vcpu); > > + > > Nit: Perhaps we need a kvm_x86_ops::shrink_ple_window()? :-) Heh, that duplicate code annoys me too. The problem is the "old" window value comes from the VMCS/VMCB, so either we'd end up with multiple kvm_x86_ops, or we'd only be able to consolidate the scheduled_out + kvm_pause_in_guest() code, which isn't all that interesting. Aha! Actually, VMX already open codes the functionality provided by VCPU_EXREG_*, e.g. has vmx->ple_window_dirty. If we add VCPU_EXREG_PLE_WINDOW, then the info get be made available to common x86 code without having to add new hooks. And that would also allow moving the guts of handle_pause()/pause_interception() to common code, i.e. will also allow deduplicating the "grow" side of things. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel