All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dennis Zhou <dennis@kernel.org>
To: "Christoph Lameter (Ampere)" <cl@linux.com>,
	Alexey Dobriyan <adobriyan@gmail.com>
Cc: tj@kernel.org, linux-mm@kvack.org, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com
Subject: Re: [PATCH] x86/percpu: fix cast in __pcpu_cast_* macros
Date: Tue, 28 May 2024 13:49:36 -0700	[thread overview]
Message-ID: <ZlZDYK-7jVGwUMCy@snowbird> (raw)
In-Reply-To: <81264b6c-fd23-2ee5-52cd-249047e317a7@linux.com>

Hi Alexey,

On Tue, May 28, 2024 at 01:43:27PM -0700, Christoph Lameter (Ampere) wrote:
> On Mon, 27 May 2024, Alexey Dobriyan wrote:
> 
> > 	this_cpu_add(*p, x = 1);
> 
> A side effect in a this_cpu_op? Shudder....
> 

At the end of the day this is Thomas' code, but I can't imagine a
single use case where this is a good idea. Especially with how much fun
percpu macros end up being.

Thanks,
Dennis


  parent reply	other threads:[~2024-05-28 20:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27  5:51 [PATCH] x86/percpu: fix cast in __pcpu_cast_* macros Alexey Dobriyan
     [not found] ` <81264b6c-fd23-2ee5-52cd-249047e317a7@linux.com>
2024-05-28 20:49   ` Dennis Zhou [this message]
2024-05-29  7:54 ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZlZDYK-7jVGwUMCy@snowbird \
    --to=dennis@kernel.org \
    --cc=adobriyan@gmail.com \
    --cc=bp@alien8.de \
    --cc=cl@linux.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-mm@kvack.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.