From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55D36C27C43 for ; Wed, 29 May 2024 11:48:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z85Bw42uncJB8nGMxZNkwrWAgXRqgtV2Y0DTZwbE1OQ=; b=GFwpm9/svc3hPD EKXgdanEuyq61P9qrbGG64aNhao12iUwsebnnrayCVJYkFCeqG93VG437APvLaSGo2c/aYjrBm6qK PpI3gaz1/8TzrDhbENIivlMKAoRNrkmdB0Lwxz1BrawZpL9QgdAhl+7WaK3Q4xuJNIgZS2H4dYavE ijEpqtGuNCtt3jpVI3shMQEyQhxdE8W5V6uFBPfeFWkmmyi6NK+6lmIiTCX/zwXpaqpQXIZ//uJIY zzANDMgfMVogfjMRX9DOhm4KJkM8HvPJxJP3mxaxGQkH8kStcxepU8v7D9kMkfbH4UsQ9ugAdB99W R6mrJjNETSHKa7tPkjEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCHnR-00000003zaP-22BR; Wed, 29 May 2024 11:48:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCHnP-00000003zZg-21XB for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 11:48:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 52932339; Wed, 29 May 2024 04:49:06 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A81B23F792; Wed, 29 May 2024 04:48:40 -0700 (PDT) Date: Wed, 29 May 2024 12:48:37 +0100 From: Cristian Marussi To: Geert Uytterhoeven Cc: Sudeep Holla , Jassi Brar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mailbox: ARM_MHU_V3 should depend on ARM64 Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_044843_588972_F7A67C6C X-CRM114-Status: GOOD ( 25.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBNYXkgMjksIDIwMjQgYXQgMDE6MzY6NDJQTSArMDIwMCwgR2VlcnQgVXl0dGVyaG9l dmVuIHdyb3RlOgo+IEhpIENyaXN0aWFuLAo+IAo+IE9uIFdlZCwgTWF5IDI5LCAyMDI0IGF0IDEy OjEz4oCvUE0gQ3Jpc3RpYW4gTWFydXNzaQo+IDxjcmlzdGlhbi5tYXJ1c3NpQGFybS5jb20+IHdy b3RlOgo+ID4gT24gV2VkLCBNYXkgMjksIDIwMjQgYXQgMDk6MzA6NDVBTSArMDIwMCwgR2VlcnQg VXl0dGVyaG9ldmVuIHdyb3RlOgo+ID4gPiBUaGUgQVJNIE1IVXYzIGNvbnRyb2xsZXIgaXMgb25s eSBwcmVzZW50IG9uIEFSTTY0IFNvQ3MuICBIZW5jZSBhZGQgYQo+ID4gPiBkZXBlbmRlbmN5IG9u IEFSTTY0LCB0byBwcmV2ZW50IGFza2luZyB0aGUgdXNlciBhYm91dCB0aGlzIGRyaXZlciB3aGVu Cj4gPiA+IGNvbmZpZ3VyaW5nIGEga2VybmVsIGZvciBhIGRpZmZlcmVudCBhcmNoaXRlY3R1cmUg dGhhbiBBUk02NC4KPiA+Cj4gPiB0aGUgQVJNNjQgZGVwZW5kZW5jeSB3YXMgZHJvcHBlZCBvbiBw dXJwb3NlIGFmdGVyIGEgZmV3IGl0ZXJhdGlvbnMgb2YKPiA+IHRoaXMgc2VyaWVzIHNpbmNlLCBk ZXNwaXRlIHRoaXMgYmVpbmcgYW4gQVJNIElQLCBpdCBoYXMgcmVhbGx5IG5vIHRlY2huaWNhbAo+ ID4gZGVwZW5kZW5jeSBvbiBBUk0gYXJjaCwgbm90IGV2ZW4gdGhlIHVzdWFsIG9uZSBvbiBBUk0g QU1CQSBidXMsIGJlaW5nIHRoaXMgYQo+ID4gcGxhdGZvcm0gZHJpdmVyLCBzbyBpdCBzZWVtZWQg YW4gdW5lZWRlZCBhcnRpZmljaWFsIHJlc3RyaWN0aW9uIHRvIGltcG9zZS4uLgo+ID4gLi4uaGF2 aW5nIHNhaWQgdGhhdCwgc3VyZWx5IG15IGxpdmUgdGVzdGluZyB3ZXJlIHBlcmZvcm1lZCBvbmx5 IG9uIGFybTY0IG1vZGVscwo+ID4gYXMgb2Ygbm93Lgo+IAo+IEZvciB0aGF0LCB3ZSBoYXZlIENP TVBJTEVfVEVTVD15Lgo+IAo+ID4gU28sIEkgYW0gbm90IHNheWluZyB0aGF0IEkgYW0gYWdhaW5z dCB0aGlzIHByb3Bvc2VkIGZpeCBidXQgd2hhdCBpcyB0aGUKPiA+IGlzc3VlIHRoYXQgaXMgdHJ5 aW5nIHRvIHNvbHZlLCBoYXZlIHlvdSBzZWVuIGFueSBjb21waWxhdGlvbiBlcnJvciA/IG9yCj4g PiBpcyBpdCBqdXN0IHRvIGF2b2lkIHRoZSB1c2VyLXByb21wdGluZyA/Cj4gCj4gSSBkaWQgbm90 IHNlZSBhIGNvbXBpbGUgZXJyb3IgKEkgZGlkbid0IGVuYWJsZSBpdCBvbiBhbnkgbm9uLUFSTQo+ IHBsYXRmb3JtKS4KPiAKPiBCdXQgaXQgaXMgcmF0aGVyIGZ1dGlsZSB0byBhc2sgdGhlIHVzZXIg YWJvdXQgKHRob3VzYW5kcyBvZikgZHJpdmVycwo+IGZvciBoYXJkd2FyZSB0aGF0IGNhbm5vdCBw b3NzaWJseSBiZSBwcmVzZW50IG9uIHRoZSBzeXN0ZW0gaGUgaXMKPiBjb25maWd1cmluZyBhIGtl cm5lbCBmb3IuCgpVbmRlcnN0b29kLCBhcyBvZiBub3cgaXQgaXMgY2VydGFpbmx5IGhpZ2gtdW5s aWtlbHkgdG8gZmluZCBzdWNoIGFuIEFSTQpJUCBvbiBhIG5vbi1BUk0gU29DIGFuZCBJIHN1cHBv c2UgdGhhdCB3ZSBjYW4gYW55d2F5IGRyb3AgdGhpcyBpZiBldmVyIHRoZQpkYXkgd2lsbCBjb21l IHRoYXQgc3VjaCBhIHN5c3RlbSB3aWxsIGFwcGVhci4KCkZpbmUgZm9yIG1lLgoKVGhhbmtzLApD cmlzdGlhbgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ECC7D13DDAE for ; Wed, 29 May 2024 11:48:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716983325; cv=none; b=I5Rvq18TK2Nzj793Uvr5ZIqgomw/HC9GKEIXtT50s3KEzWhrceGlaybIQzeBAezBbaj6OMQqixlIcV5/TJoBB3yiq9bVWlERUVTdSgjlMlJ/y5Cah94yX8WtpAbi8OtPdBtQ6JuVLWDCgSWxBqvr856QRNsyaioSZUu2fnD+dzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716983325; c=relaxed/simple; bh=2mDZUXMSLDBIPCh16+epzZP8Y3IzRgJRHYxvEmw+Z8Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=K6iJMx3NN2jnSWuTKOezn5YWOl41oINmevIRpiAPjIsrKXobZiqfxEKYHUWxoYidG3gBA6xiSYraCLalZyfVhqDAwWgTaMeWW+zkGUsNOJT/Lpja3paILqMe6nsHLGiUzYZcGzYCGrv7395R4pLEyJ7WfJCGOK+jskETXJJjFck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 52932339; Wed, 29 May 2024 04:49:06 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A81B23F792; Wed, 29 May 2024 04:48:40 -0700 (PDT) Date: Wed, 29 May 2024 12:48:37 +0100 From: Cristian Marussi To: Geert Uytterhoeven Cc: Sudeep Holla , Jassi Brar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mailbox: ARM_MHU_V3 should depend on ARM64 Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, May 29, 2024 at 01:36:42PM +0200, Geert Uytterhoeven wrote: > Hi Cristian, > > On Wed, May 29, 2024 at 12:13 PM Cristian Marussi > wrote: > > On Wed, May 29, 2024 at 09:30:45AM +0200, Geert Uytterhoeven wrote: > > > The ARM MHUv3 controller is only present on ARM64 SoCs. Hence add a > > > dependency on ARM64, to prevent asking the user about this driver when > > > configuring a kernel for a different architecture than ARM64. > > > > the ARM64 dependency was dropped on purpose after a few iterations of > > this series since, despite this being an ARM IP, it has really no technical > > dependency on ARM arch, not even the usual one on ARM AMBA bus, being this a > > platform driver, so it seemed an uneeded artificial restriction to impose... > > ...having said that, surely my live testing were performed only on arm64 models > > as of now. > > For that, we have COMPILE_TEST=y. > > > So, I am not saying that I am against this proposed fix but what is the > > issue that is trying to solve, have you seen any compilation error ? or > > is it just to avoid the user-prompting ? > > I did not see a compile error (I didn't enable it on any non-ARM > platform). > > But it is rather futile to ask the user about (thousands of) drivers > for hardware that cannot possibly be present on the system he is > configuring a kernel for. Understood, as of now it is certainly high-unlikely to find such an ARM IP on a non-ARM SoC and I suppose that we can anyway drop this if ever the day will come that such a system will appear. Fine for me. Thanks, Cristian