From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Wed, 29 May 2024 05:54:18 -0700 Subject: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() In-Reply-To: <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, May 29, 2024, Kai Huang wrote: > I am not familiar with SVM, but it seems the relevant parts are: > > control->pause_filter_count; > vmcb_mark_dirty(svm->vmcb, VMCB_INTERCEPTS); > > And it seems they are directly related to programming the hardware, i.e., > they got automatically loaded to hardware during VMRUN. "control" is the control area of the VMCB, i.e. the above pause_filter_count is equivalent to a VMCS field. > They need to be updated in the SVM specific code when @ple_window_dirty is > true in the relevant code path. > > Anyway, even it is feasible and worth to do, we should do in a separate > patchset. Ya. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03C3B6FC6 for ; Wed, 29 May 2024 12:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716987262; cv=none; b=RdqLupSdwjkVv9wC30ydw3WDdrqw3IrgZxdOsb4ymg3MC1m4gmOrRaCFlJpb9pSZzaC8BU2sfGoO9RWotcQ5VwRK/HYcuyyb1ndvIv7ZAKnlEHzW8d4MZkzdh4i0v0YWGTlnztN5GtXQWF3ebpt6bG6U4/eMSuizNnSQB1Yu/+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716987262; c=relaxed/simple; bh=7C3Ln9w/sSUWPP+BUdVx+PL58R8HTzOVmDKg36W3xec=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=DBZhJKTGfV5SruF/UbusO4sXB7CC00tN2hbmHsD21y36zJ0QEvNV1ORsqIq22fBmKI01GSEDfMMKv/WGwXdp4wq18a2vMJ6wMSZ8vs7V/vuY0wjpyEKQdJhnb2YiqDzIiC7h9d8bhZ/ouHK4BbvfYlMHuDVCt9p9SFwXV065A9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=27KaI3Ub; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="27KaI3Ub" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-6819fd023b9so2194784a12.3 for ; Wed, 29 May 2024 05:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716987260; x=1717592060; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1KVQFhVFh80Fdd96OAcePaAYKBvjrIO3JB8q5MbeFQU=; b=27KaI3UbOfCoRhke1cY9+3lF+pC9jfVNcr2V0hD7p3n3lTheNBn5QXNWxog9ZUxnLb Rcu0E0+5bvDtDM/RFrSOTPcPIaravgjkiqKYwc1mpB4+9jZFMC9K2u5CFcqrE4B/PWGv 6MyjPQfi8gSkMOrfau1PgcZJZlmvuhtXuuKaCZuiykAQ5G4WNgB7eGjhFZvRyij9H87j 58kOtnbfiXjHirahLWVhNrQ7KmxwbffLgp4mhNN3MPBkwdp5QLmgy37J78hnnOSfv4p9 XxTn7DV4bbDKYHuP80du6ha9SbBhOc4V0qPTfRHxQNa1H1XkdBUpslNdVIyL+yg5QSgh c65w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716987260; x=1717592060; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1KVQFhVFh80Fdd96OAcePaAYKBvjrIO3JB8q5MbeFQU=; b=obssnpNDpL9ScJ4chqyC38fTVQ7qhTTA+CV0MPrRYKw7iR+UK0EZt0eg7lSz0urypA gx65S+LJreGPSTGNpmtewcrTuCXATQ3CZVDvF4lBs088T9c+sQibPT+GwFzsg50yKEt8 V427ZCJ/a/N5h8i/csOoi7lHZ9cKfKQ72eMt5tzxvHDvpRv6syyagHZp46QNuNx7OVfw aROKhQyB9PRPI6kBQFuGEhX8AVBWz93wZdJTH1Y8VmciuEwD+6S5Bm51lOEEhGBd/K4i 3T81QdNMCtD60nsMXupDmFxAKuGwxcxK2lAJhba5ZG1WDvUpdv3F3VvNit6vesngVhK7 qGww== X-Forwarded-Encrypted: i=1; AJvYcCV5eJ8O5Kcj09aPB23er/Xyb4nGYxz52WMuaONqwkSBLZhZxieiZ5sj8eCByplxIUM6bPzGwAuQZxVK3iIM4d2jz6BfJwAW X-Gm-Message-State: AOJu0YwY+hKIgWJHpidpdl5MBropXVSjAAzuAPC0c76IB7Z1LkAhol3D UUOnu3vkr6NyrAhkRi+IYWSJvaDRj+/fhsWpnaQB+YrbSu6Z47aSUhFwBhK7FXW7fkUS20FQC/a SVg== X-Google-Smtp-Source: AGHT+IHBbZP8iE9LJoz88cSwyGPtf4IYoLcqAZBm04Syis1dHtNGwvMpLLvLxNB1S+GJVlzsrbdgQQ4xG0k= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:1421:0:b0:680:1ce8:ba9a with SMTP id 41be03b00d2f7-681aea7d0ecmr40830a12.11.1716987260030; Wed, 29 May 2024 05:54:20 -0700 (PDT) Date: Wed, 29 May 2024 05:54:18 -0700 In-Reply-To: <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Message-ID: Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "kvm@vger.kernel.org" , "maz@kernel.org" , "frankja@linux.ibm.com" , "borntraeger@linux.ibm.com" , "mpe@ellerman.id.au" , "aou@eecs.berkeley.edu" , "palmer@dabbelt.com" , "linux-kernel@vger.kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "loongarch@lists.linux.dev" , "paul.walmsley@sifive.com" , "kvmarm@lists.linux.dev" , "imbrenda@linux.ibm.com" , "kvm-riscv@lists.infradead.org" , "zhaotianrui@loongson.cn" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "linux-riscv@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" On Wed, May 29, 2024, Kai Huang wrote: > I am not familiar with SVM, but it seems the relevant parts are: > > control->pause_filter_count; > vmcb_mark_dirty(svm->vmcb, VMCB_INTERCEPTS); > > And it seems they are directly related to programming the hardware, i.e., > they got automatically loaded to hardware during VMRUN. "control" is the control area of the VMCB, i.e. the above pause_filter_count is equivalent to a VMCS field. > They need to be updated in the SVM specific code when @ple_window_dirty is > true in the relevant code path. > > Anyway, even it is feasible and worth to do, we should do in a separate > patchset. Ya. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DC2DC25B75 for ; Wed, 29 May 2024 12:54:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=QT1Xv8LjfCwCr3hBvdehzzgxj76vg+r/zMiuKm62euU=; b=EC4j7wcwlQf+a3Qg09cxw3A/Ht zJ+7vkYTGrNXEQNNVxOXtFcZzpW5MVP0IeS46+PrMNJpWt0Zmg0Muel2ZfzYQuPVniSkpV7QQ8Nue PnbBRV9gN2R0c+/7mfH8g4ayeAZkzZ04adABf8/lLjdJ7ocZZkeriQHoTrs/UjzTmiTNkq2/57iIQ SrbB3jxTJIghXlVUGMKZAuug2OznSDrZ3a+ow3a3N6nVykJiIsUJHgZyMaILF/oOnPgOzj4NJq2hm 9qqDrjY+ZKwN5ndlyMt2m49kTSlpIAfOXLEGL1e1uiBHJshrbucqhybFS16pnSifkzwwUGkvMHvKe Zg/y+5Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCIp1-00000004AJK-3FDr; Wed, 29 May 2024 12:54:27 +0000 Received: from mail-pg1-x549.google.com ([2607:f8b0:4864:20::549]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCIow-00000004AGr-3ReG for linux-riscv@lists.infradead.org; Wed, 29 May 2024 12:54:25 +0000 Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-6819735bfc4so1944401a12.2 for ; Wed, 29 May 2024 05:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716987260; x=1717592060; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1KVQFhVFh80Fdd96OAcePaAYKBvjrIO3JB8q5MbeFQU=; b=ZKcVBqy6gICwaWxs1+tsmuTDAMA623oSBccffhtDgM3FWltguaedUD212m330zpRr4 d2uS3I/HqoX0mTHw2A+BCaljU/ybzMbonldzHhAuUtRuU3rlM2JKi+xFzKSCKBVVLfai +I/rpKKA336n0ldx6BvKlGxOKIqZVvNi5/hwhgixUl47ZTMv08i8fO3nqX1/z0HZhVqq 1o0Tn3h3/r2VHIeQCpnSYK49Z50QWTF4vj0HO5/bTCCIRdpsUhXaptwFKKdEBmAQfLPG GR84f2xQntbT/aO8qzamwe3JmDNxxRhSPDyHYZgZWu2MM55dBY1BC59hcndfXsYt/0a7 Nvsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716987260; x=1717592060; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1KVQFhVFh80Fdd96OAcePaAYKBvjrIO3JB8q5MbeFQU=; b=E/8ybA49HewNedK6jG1W9T38keZr3es1HJaG58zhnn4j5tBQiLfvsqBivZ/SCvnGMO JmZBmgS45rLimZE3hapxLlQ8a2OuagcpL6CeanqaulL2WhJNL/CxcaTeaIhOz2Ai87uL pD29SfN9/InLXDLuO7K2IkQLIY7ggnpoRDzzzrIrsaTWc38MqR+DZDGfE9PbU/XFl8Cb +HIJ/e/QuWzkGtCNpPBs9zAFjG0fhe5zHz2LVObUrhmWcSTQTBBOomAXMYJeCoCGuZ/O xKCu/qPjmcf6gHmW2HVU+HqXnxIeFCe9d1fl5ByorN8s1Q8vJ1nhVyjn99PpDWmc5kEE aRbQ== X-Forwarded-Encrypted: i=1; AJvYcCUKQsTRdrldQlhfZNzWsnpWf/+XJbt/d9X3fTOdf8dxtstBm1w0awqGXZTMbQstOVGKJeVcrww1leigs6o3vlu7MzpmwZs7sjUJBkdCOK4x X-Gm-Message-State: AOJu0YyN3My6Rxk24GR3Jq3rR5lYJpB0h9NuqKhshgMVvUo3DDlME0+W tV+Nf+Qp6TfpCrib1pJF+W7G7vLvXYgE1tofi4KsPdU/tT8JjSf7je8rWcQisTf2j4/ajn0d/HP Y3A== X-Google-Smtp-Source: AGHT+IHBbZP8iE9LJoz88cSwyGPtf4IYoLcqAZBm04Syis1dHtNGwvMpLLvLxNB1S+GJVlzsrbdgQQ4xG0k= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:1421:0:b0:680:1ce8:ba9a with SMTP id 41be03b00d2f7-681aea7d0ecmr40830a12.11.1716987260030; Wed, 29 May 2024 05:54:20 -0700 (PDT) Date: Wed, 29 May 2024 05:54:18 -0700 In-Reply-To: <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Mime-Version: 1.0 References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Message-ID: Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "kvm@vger.kernel.org" , "maz@kernel.org" , "frankja@linux.ibm.com" , "borntraeger@linux.ibm.com" , "mpe@ellerman.id.au" , "aou@eecs.berkeley.edu" , "palmer@dabbelt.com" , "linux-kernel@vger.kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "loongarch@lists.linux.dev" , "paul.walmsley@sifive.com" , "kvmarm@lists.linux.dev" , "imbrenda@linux.ibm.com" , "kvm-riscv@lists.infradead.org" , "zhaotianrui@loongson.cn" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "linux-riscv@lists.infradead.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_055422_901368_697C8B5E X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2024, Kai Huang wrote: > I am not familiar with SVM, but it seems the relevant parts are: > > control->pause_filter_count; > vmcb_mark_dirty(svm->vmcb, VMCB_INTERCEPTS); > > And it seems they are directly related to programming the hardware, i.e., > they got automatically loaded to hardware during VMRUN. "control" is the control area of the VMCB, i.e. the above pause_filter_count is equivalent to a VMCS field. > They need to be updated in the SVM specific code when @ple_window_dirty is > true in the relevant code path. > > Anyway, even it is feasible and worth to do, we should do in a separate > patchset. Ya. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5838EC25B75 for ; Wed, 29 May 2024 13:01:43 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=XTueE6Eb; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Vq8Vk3zMpz79c8 for ; Wed, 29 May 2024 22:55:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20230601 header.b=XTueE6Eb; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::54a; helo=mail-pg1-x54a.google.com; envelope-from=3fcvxzgykdf0n95ie7bjjbg9.7jhgdipskk7-89qgdnon.jug56n.jmb@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Vq8Tv1wb2z3gL3 for ; Wed, 29 May 2024 22:54:25 +1000 (AEST) Received: by mail-pg1-x54a.google.com with SMTP id 41be03b00d2f7-6658175f9d4so2000417a12.0 for ; Wed, 29 May 2024 05:54:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716987260; x=1717592060; darn=lists.ozlabs.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1KVQFhVFh80Fdd96OAcePaAYKBvjrIO3JB8q5MbeFQU=; b=XTueE6EbKl4g8JQP3wK464wJsNTD2EolTD4cTuFi297ULHCBcXq6sqju7lAtnE3Jt6 53fslLQNzUxSlqB6+uEfX2bWHAyffLLFPyQj1SCn9M7Ha2Wm/n6M3vA3Pvfqqi5U4aGT gRHrODxefRJir8rqeRmc9EZMa+zm2cC4MiOzlhv1rSIiwGvp6de18ILJ6rA4k9qwDK0r tjwVE36D5t9r4bjsMFyaUPhFoEnJmA5Be2xR1gInv6NaMFBIOI/SrTozuVTQx48TEvRD JkPQZZyH40ctm+N20F9iQdmmaHSCP+1+WgRlVkHl5jhWXzK3Qy72izUpSJ5K9wxAfk9o XuWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716987260; x=1717592060; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1KVQFhVFh80Fdd96OAcePaAYKBvjrIO3JB8q5MbeFQU=; b=KuFsWEQEpV6+kPEBuRbNBpSalUbuD2Por0GnIVnthIZMuoekhwHCnrpO0Xll5bGLZK 2gLe7MgAiOUr2LysMMfJ1owSFy9kviQZzs7RY2flL07aMJ6tIeTuj2XErizaV2Ap9Jcz TJ4zLpHcJRSaCQo2l8jP/n23QFlYRsd+x3iwTbW5JhJ/ppLwtDIWqRaZVexb5RSMFimv sTX6SRam7rA0rmZC3zl69fyJWrwM81y1fQx+tLQ7RMcW3Bu+Gr+/vn42ed9Pr3Nnkkn7 W9Pb+7UjYLmP4XLkWbEOHnLkvTouxgCcXQOMeVCh5YWUGPR4VVUltOy2ZMD7Ssg7RML1 vy+A== X-Forwarded-Encrypted: i=1; AJvYcCVDg2FnZXw1gXnaz+Aah4iIHNDF9XC2yBrUfI5DRNhnfv1EkuxjeTD72PLDclH9YWRys69EYlk83O5NW6/lKScHKB9sRH6FaJBf+3cMCw== X-Gm-Message-State: AOJu0YzJFeyOvuY1dxZIVlNNvnaF84+6ymRxzz1Baj0utkvEAnreH28o BQn6MguVNZ4JIKkgKm2LTdRJvv9DpRdPwKCqtEwJDc+6u380OIcXZW2fR3rY0M5IUVJPNwzbB17 tPw== X-Google-Smtp-Source: AGHT+IHBbZP8iE9LJoz88cSwyGPtf4IYoLcqAZBm04Syis1dHtNGwvMpLLvLxNB1S+GJVlzsrbdgQQ4xG0k= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:1421:0:b0:680:1ce8:ba9a with SMTP id 41be03b00d2f7-681aea7d0ecmr40830a12.11.1716987260030; Wed, 29 May 2024 05:54:20 -0700 (PDT) Date: Wed, 29 May 2024 05:54:18 -0700 In-Reply-To: <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Mime-Version: 1.0 References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Message-ID: Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() From: Sean Christopherson To: Kai Huang Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "imbrenda@linux.ibm.com" , "frankja@linux.ibm.com" , "maz@kernel.org" , "chenhuacai@kernel.org" , "borntraeger@linux.ibm.com" , "aou@eecs.berkeley.edu" , "maobibo@loongson.cn" , "loongarch@lists.linux.dev" , "paul.walmsley@sifive.com" , "kvmarm@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "oliver.upton@linux.dev" , "palmer@dabbelt.com" , "kvm-riscv@lists.infradead.org" , "anup@brainfault.org" , "pbonzini@redhat.com" , "zhaotianrui@loongson.cn" , "linuxppc-dev@lists.ozlabs.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, May 29, 2024, Kai Huang wrote: > I am not familiar with SVM, but it seems the relevant parts are: > > control->pause_filter_count; > vmcb_mark_dirty(svm->vmcb, VMCB_INTERCEPTS); > > And it seems they are directly related to programming the hardware, i.e., > they got automatically loaded to hardware during VMRUN. "control" is the control area of the VMCB, i.e. the above pause_filter_count is equivalent to a VMCS field. > They need to be updated in the SVM specific code when @ple_window_dirty is > true in the relevant code path. > > Anyway, even it is feasible and worth to do, we should do in a separate > patchset. Ya. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2839FC25B75 for ; Wed, 29 May 2024 12:54:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=OL/UWMnVYYXtZUpf1N7a/7XHIQhP+TzqYRzjNHrSseA=; b=qXs4I9f4nawvIPklEZLro/Hy4w HJUtyLX6KwQUi34YRxbXKOPX1yKdh98nWhaKSsgg5fEeNAz4mz8LpzpLUn8w4PJVwT3AXa/sMOIop OB6KijnePhWbyTQf2z5HUTMSm6pOr6d+d+c57GiM46J3kVUQji7Tl6kOfZsYN9TRIKLLup7j7vIsU elR/lyG2kzyzM6cLnIBl4qqMDxIpGRGQogMrxpLm7ffDhOUtzcIp46xVJxmwACcB3GnaJUyvxL9EU 8dD4j/f6YCUvkcFXcIsdq+QpMObW9txnBTc+z+GjSiJzqDLEROSCZOpA1ASaxXDp6HUxUeSDJBnNt Ih5a3ffw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCIp0-00000004AIQ-12bB; Wed, 29 May 2024 12:54:26 +0000 Received: from mail-pg1-x549.google.com ([2607:f8b0:4864:20::549]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sCIow-00000004AGt-3Son for linux-arm-kernel@lists.infradead.org; Wed, 29 May 2024 12:54:24 +0000 Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-6658175f9d4so2000419a12.0 for ; Wed, 29 May 2024 05:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1716987260; x=1717592060; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=1KVQFhVFh80Fdd96OAcePaAYKBvjrIO3JB8q5MbeFQU=; b=ZKcVBqy6gICwaWxs1+tsmuTDAMA623oSBccffhtDgM3FWltguaedUD212m330zpRr4 d2uS3I/HqoX0mTHw2A+BCaljU/ybzMbonldzHhAuUtRuU3rlM2JKi+xFzKSCKBVVLfai +I/rpKKA336n0ldx6BvKlGxOKIqZVvNi5/hwhgixUl47ZTMv08i8fO3nqX1/z0HZhVqq 1o0Tn3h3/r2VHIeQCpnSYK49Z50QWTF4vj0HO5/bTCCIRdpsUhXaptwFKKdEBmAQfLPG GR84f2xQntbT/aO8qzamwe3JmDNxxRhSPDyHYZgZWu2MM55dBY1BC59hcndfXsYt/0a7 Nvsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716987260; x=1717592060; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1KVQFhVFh80Fdd96OAcePaAYKBvjrIO3JB8q5MbeFQU=; b=KPalViA8f/A1nCLL6ear7lklwzZ0YgEfl+ZV2m0ZSMwZ6KQHjIDDyuvv1ptL+vYb3H Dib8RVCM3vqCdL9ilRS53nOvt9oi2I/Cs507p+hBidinm7kAHWwRm2QAotBsd49Tk5p2 vYIA262rv74VfBQMC0E2XXn2bKcSMomzRDRBc9HI2KmXkB1JX8cGm10T7NhnhSr+KrTO kg7vAxdnQ7EKk+DJMJoZrxa0Si0BXIf93mg0QNhI5vgoKsufaFj7zoBRT8GIyITHPfK2 FF5pnOuZhEQ04t0q0vL1QgzTSt1QDksb5q1Bd/MUkN6XmIbw4Mj8u+0vGEXO+OuL8giq iOEQ== X-Forwarded-Encrypted: i=1; AJvYcCVVIXSSmGUhzWf5danhL9MrgI4y2eaaHvaeyOLxONoNf95a0CqO17QfsbLfWhMcirQ0rXCw0U3KG3NU9HNF+Qqes7Z5/0TkIoCeKG4SCoYy7ol2G2c= X-Gm-Message-State: AOJu0Yy4G44dsB7UatLSUU5M2DGyZW53S0kAvDeGa1yvNtotzApQiKjc HUKlDXMFuHBxQvq28dCYvSNli7hdyzsvOTfqhjXP96xbpGzXekFlu6qyLJ1oqy7s7LU5dsQWbPn +qg== X-Google-Smtp-Source: AGHT+IHBbZP8iE9LJoz88cSwyGPtf4IYoLcqAZBm04Syis1dHtNGwvMpLLvLxNB1S+GJVlzsrbdgQQ4xG0k= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:1421:0:b0:680:1ce8:ba9a with SMTP id 41be03b00d2f7-681aea7d0ecmr40830a12.11.1716987260030; Wed, 29 May 2024 05:54:20 -0700 (PDT) Date: Wed, 29 May 2024 05:54:18 -0700 In-Reply-To: <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Mime-Version: 1.0 References: <20240522014013.1672962-1-seanjc@google.com> <20240522014013.1672962-4-seanjc@google.com> <2a221116a03f57dca8274b6bc2da7541b21d86bb.camel@intel.com> Message-ID: Subject: Re: [PATCH v2 3/6] KVM: x86: Fold kvm_arch_sched_in() into kvm_arch_vcpu_load() From: Sean Christopherson To: Kai Huang Cc: "chenhuacai@kernel.org" , "kvm@vger.kernel.org" , "maz@kernel.org" , "frankja@linux.ibm.com" , "borntraeger@linux.ibm.com" , "mpe@ellerman.id.au" , "aou@eecs.berkeley.edu" , "palmer@dabbelt.com" , "linux-kernel@vger.kernel.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" , "loongarch@lists.linux.dev" , "paul.walmsley@sifive.com" , "kvmarm@lists.linux.dev" , "imbrenda@linux.ibm.com" , "kvm-riscv@lists.infradead.org" , "zhaotianrui@loongson.cn" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mips@vger.kernel.org" , "anup@brainfault.org" , "oliver.upton@linux.dev" , "linux-riscv@lists.infradead.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240529_055422_895124_B94BF8CA X-CRM114-Status: GOOD ( 12.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 29, 2024, Kai Huang wrote: > I am not familiar with SVM, but it seems the relevant parts are: > > control->pause_filter_count; > vmcb_mark_dirty(svm->vmcb, VMCB_INTERCEPTS); > > And it seems they are directly related to programming the hardware, i.e., > they got automatically loaded to hardware during VMRUN. "control" is the control area of the VMCB, i.e. the above pause_filter_count is equivalent to a VMCS field. > They need to be updated in the SVM specific code when @ple_window_dirty is > true in the relevant code path. > > Anyway, even it is feasible and worth to do, we should do in a separate > patchset. Ya. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel