From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE013C25B75 for ; Thu, 30 May 2024 03:12:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 383DB884C3; Thu, 30 May 2024 05:12:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 7EA4F8864C; Thu, 30 May 2024 05:12:17 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 83F6988225 for ; Thu, 30 May 2024 05:12:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 44U3BnDa010871; Thu, 30 May 2024 11:11:49 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Thu, 30 May 2024 11:11:49 +0800 Date: Thu, 30 May 2024 11:11:46 +0800 From: Leo Liang To: Conor Dooley CC: , Conor Dooley , Padmarao Begari , Cyril Jean , Tom Rini Subject: Re: [PATCH v1 1/2] board: microchip: icicle: correct type for node offset Message-ID: References: <20240515150434.406916-1-conor@kernel.org> <20240515150434.406916-2-conor@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240515150434.406916-2-conor@kernel.org> User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25) X-Originating-IP: [10.0.15.183] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 44U3BnDa010871 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, May 15, 2024 at 04:04:30PM +0100, Conor Dooley wrote: > From: Conor Dooley > > Node offsets returned by libfdt can contain negative error numbers, so > the variable type should be "int". As things stand, if the ethernet > nodes are not found in the early init callback, the if (node < 0) tests > pass and the code errors out while trying to set the local-mac-address > for a non-existent node. > > Fixes: 64413e1b7c ("riscv: Add Microchip MPFS Icicle Kit support") > Signed-off-by: Conor Dooley > --- > board/microchip/mpfs_icicle/mpfs_icicle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Leo Yu-Chi Liang