From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Anthony PERARD <anthony@xenproject.org>,
Juergen Gross <jgross@suse.com>,
Oleksii Kurochko <oleksii.kurochko@gmail.com>,
George Dunlap <George.Dunlap@citrix.com>,
Jan Beulich <JBeulich@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>
Subject: Re: [PATCH] tools: (Actually) drop libsystemd as a dependency
Date: Thu, 30 May 2024 15:14:37 +0200 [thread overview]
Message-ID: <Zlh7vRwvICxVg06f@macbook> (raw)
In-Reply-To: <71bbc310-1093-44d1-a0b0-e5a8ab10a0ea@citrix.com>
On Thu, May 30, 2024 at 12:12:19PM +0100, Andrew Cooper wrote:
> On 30/05/2024 12:02 pm, Roger Pau Monné wrote:
> > On Thu, May 30, 2024 at 11:14:39AM +0100, Andrew Cooper wrote:
> >> When reinstating some of systemd.m4 between v1 and v2, I reintroduced a little
> >> too much. While {c,o}xenstored are indeed no longer linked against
> >> libsystemd, ./configure still looks for it.
> >>
> >> Drop this too.
> >>
> >> Fixes: ae26101f6bfc ("tools: Drop libsystemd as a dependency")
> >> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > LGTM, but my knowledge of systemd is very limited.
> >
> > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Thanks. TBH, this is all M4/autoconf, rather than systemd.
Right, but it's about systemd dependencies which is what I don't know
about. The m4 stuff LGTM, whether it's appropriate to drop the
dependency is what I can't be sure about.
Thanks, Roger.
next prev parent reply other threads:[~2024-05-30 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 10:14 [PATCH] tools: (Actually) drop libsystemd as a dependency Andrew Cooper
2024-05-30 11:02 ` Roger Pau Monné
2024-05-30 11:12 ` Andrew Cooper
2024-05-30 13:14 ` Roger Pau Monné [this message]
2024-05-30 14:43 ` Oleksii K.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zlh7vRwvICxVg06f@macbook \
--to=roger.pau@citrix.com \
--cc=George.Dunlap@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony@xenproject.org \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=oleksii.kurochko@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.