Re: [PATCH 04/10] drm/i915/display: include intel_uncore.h where needed

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, May 29, 2024 at 08:48:08PM +0300, Jani Nikula wrote:
> Include what you use. With this, we can drop the include from xe compat
> i915_drv.h.

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_bios.c         | 1 +
>  drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h | 1 -
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index b0a49b2f957f..e53a789e3170 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -36,6 +36,7 @@
>  #include "intel_display.h"
>  #include "intel_display_types.h"
>  #include "intel_gmbus.h"
> +#include "intel_uncore.h"
>  
>  #define _INTEL_BIOS_PRIVATE
>  #include "intel_vbt_defs.h"
> diff --git a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> index 9776cc3332fe..e5966f07a924 100644
> --- a/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> +++ b/drivers/gpu/drm/xe/compat-i915-headers/i915_drv.h
> @@ -22,7 +22,6 @@
>  #include "i915_reg_defs.h"
>  #include "i915_utils.h"
>  #include "intel_step.h"
> -#include "intel_uncore.h"
>  #include "intel_runtime_pm.h"
>  #include <linux/pm_runtime.h>
>  
> -- 
> 2.39.2
>