Re: [PATCH v7 3/4] perf annotate: LLVM-based disassembler

["Steinar H. Gunderson" <sesse@google.com>]

On Tue, May 28, 2024 at 09:06:24PM -0700, Namhyung Kim wrote:
>> +       struct symbol_lookup_storage *storage =
>> +               (struct symbol_lookup_storage *)disinfo;
> You don't need this in C. :)  Also we usually put a blank line
> after declaration (at least, at the beginning).

Done.

> We put the arguments at the same line and align them.
> Please do the same in other places.

Done, I believe.

>> +       LLVMDisasmDispose(disasm);
>> +       free(buf);
>> +       free(line_storage);
>> +       return 0;
> Often we just set a different return value here and share the
> error handling logic at the end.

Done.

/* Steinar */