Re: [Buildroot] [PATCH 1/1] package/beecrypt: fix build with gcc 14

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/beecrypt: fix build with gcc 14
Date: Sun, 16 Jun 2024 10:57:14 +0200	[thread overview]
Message-ID: <Zm6o6hFptzclDC4Z@landeda> (raw)
In-Reply-To: <20240615204233.3339310-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-06-15 22:42 +0200, Fabrice Fontaine spake thusly:
> Fix the following build failure with gcc 14:
> 
> blockmode.c: In function 'blockEncryptCTR':
> blockmode.c:162:42: error: implicit declaration of function 'swapu32' [-Wimplicit-function-declaration]
>   162 |                                 buf[i] = swapu32(fdback[j]);
>       |                                          ^~~~~~~
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/651e0e31305b1f211071d94ea74f7b7a5793b03e
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/beecrypt/0004-beecrypt-4.2.1-c99.patch | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 package/beecrypt/0004-beecrypt-4.2.1-c99.patch
> 
> diff --git a/package/beecrypt/0004-beecrypt-4.2.1-c99.patch b/package/beecrypt/0004-beecrypt-4.2.1-c99.patch
> new file mode 100644
> index 0000000000..489ce437f6
> --- /dev/null
> +++ b/package/beecrypt/0004-beecrypt-4.2.1-c99.patch
> @@ -0,0 +1,17 @@
> +Add missing header to fix C99 conformance in blockmode.c
> +
> +Upstream: https://sourceforge.net/p/beecrypt/patches/13
> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Thanks for this effort.

However, beecrypt 4.2.1 was the last version to be released, in
2015-07-12, almost nine years ago now. After that, there has been
no development activity on that package.

I looked on Github and Gtilab in case there was something there that
would vaguely resemble a new maintenance effort, but there is
virtually nothing of interest there.

Using a cryptography library that has had no release in almost 9
years is not a good idea, to say the least.

beecrypt only installs a library, and nothing in the tree depends
on it.

I suggest we just drop that package instead.

Regards,
Yann E. MORIN.

> +diff --git a/blockmode.c b/blockmode.c
> +index 46d1fde..9998c23 100644
> +--- a/blockmode.c
> ++++ b/blockmode.c
> +@@ -29,6 +29,7 @@
> + # include "config.h"
> + #endif
> + 
> ++#include "beecrypt/endianness.h"
> + #include "beecrypt/blockmode.h"
> + 
> + int blockEncryptECB(const blockCipher* bc, blockCipherParam* bp, uint32_t* dst, const uint32_t* src, unsigned int nblocks)
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot