Re: [Buildroot] [PATCH 1/1] package/nut: needs threads

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Bernd Kuhls <bernd@kuhls.net>, Asaf Kahlon <asafka7@gmail.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/nut: needs threads
Date: Sun, 16 Jun 2024 10:59:48 +0200	[thread overview]
Message-ID: <Zm6phM57fgAhcqs1@landeda> (raw)
In-Reply-To: <20240615182023.2963494-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-06-15 20:20 +0200, Fabrice Fontaine spake thusly:
> threads are mandantory since bump to version 2.8.2 in commit
> 4edd837ac0193db83202030ee2997ac811e6bc45 and
> https://github.com/networkupstools/nut/commit/ff401e538bcbead62a3532887135518ef9e779df:
> 
> In file included from nutipc.cpp:38:
> ../include/nutipc.hpp:455:3: error: 'pthread_t' does not name a type
>   455 |   pthread_t m_impl;
>       |   ^~~~~~~~~
> 
> Fixes: 4edd837ac0193db83202030ee2997ac811e6bc45
>  - http://autobuild.buildroot.org/results/d16a24d60b298d7616a516ec0c6c30696ed93a58
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/collectd/Config.in | 5 +++--
>  package/nut/Config.in      | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/package/collectd/Config.in b/package/collectd/Config.in
> index 80759e9566..35f544b626 100644
> --- a/package/collectd/Config.in
> +++ b/package/collectd/Config.in
> @@ -430,13 +430,14 @@ config BR2_PACKAGE_COLLECTD_NTPD
>  config BR2_PACKAGE_COLLECTD_NUT
>  	bool "nut"
>  	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	select BR2_PACKAGE_NUT
>  	help
>  	  The NUT plugin collects uninterruptible power supply (UPS)
>  	  statistics using the Network UPS Tools (NUT).
>  
> -comment "nut needs a toolchain w/ C++"
> -	depends on !BR2_INSTALL_LIBSTDCPP
> +comment "nut needs a toolchain w/ C++, threads"
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
>  
>  config BR2_PACKAGE_COLLECTD_OLSRD
>  	bool "olsrd"
> diff --git a/package/nut/Config.in b/package/nut/Config.in
> index df647b9b48..0ecd33d583 100644
> --- a/package/nut/Config.in
> +++ b/package/nut/Config.in
> @@ -1,11 +1,12 @@
> -comment "nut needs a toolchain w/ C++"
> +comment "nut needs a toolchain w/ C++, threads"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_INSTALL_LIBSTDCPP
> +	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
>  
>  config BR2_PACKAGE_NUT
>  	bool "nut"
>  	depends on BR2_USE_MMU # fork()
>  	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>  	help
>  	  Network UPS tools
>  
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot