Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: yegorslists@googlemail.com
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/ncftp: fix GCC 14.x related build errors
Date: Sun, 16 Jun 2024 13:22:29 +0200	[thread overview]
Message-ID: <Zm7K9fkXOlLrekgS@landeda> (raw)
In-Reply-To: <20240613113924.3778837-1-yegorslists@googlemail.com>

Yegor, All,

On 2024-06-13 13:39 +0200, yegorslists@googlemail.com spake thusly:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> Patches were taken from Gentoo:
> 
> https://bugs.gentoo.org/921487
> https://gitweb.gentoo.org/repo/gentoo.git/tree/net-ftp/ncftp/files/ncftp-3.2.7-fix-clang.patch
> 
> Fixes:
> http://autobuild.buildroot.net/results/058578eae885ce6e206c25b5a24aa11b625adf88/

Thank you for your efforts in helping fix build failures! 👍

> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
[--SNIP--]
> diff --git a/.checkpackageignore b/.checkpackageignore
> index dd1fd31e86..52b5090034 100644
> --- a/.checkpackageignore
> +++ b/.checkpackageignore
> @@ -1067,6 +1067,8 @@ package/musl/0001-avoid-kernel-if_ether.h.patch lib_patch.Upstream
>  package/musl/0002-package-musl-Make-scheduler-functions-Linux-compatib.patch lib_patch.Upstream
>  package/nano/0001-lib-getrandom.c-fix-build-with-uclibc-1.0.35.patch lib_patch.Upstream
>  package/nanocom/0001-fix-build-with-gcc-10.patch lib_patch.Upstream
> +package/ncftp/0001-ncftp-3.2.7-fix-gcc14.patch lib_patch.Upstream
> +package/ncftp/0002-ncftp-3.2.7-fix-clang.patch lib_patch.Upstream

Do not add an exclusion for new patches; instead, add an Upstream tag.

If the patches were not from upstream, then submit them and add the URL
to that submission as an Upstream tag; if the patches are not suitable
for upstream, then state so in the Upstream tag, and explain why.

See the manual:
    https://buildroot.org/downloads/manual/manual.html#_additional_patch_documentation

Could you rework this and resubmit, please?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot