Re: [Buildroot] [External] [PATCH 8/9] support/scripts/apply-patches: use appropriate TAR

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Brandon, All,

On 2024-06-05 15:22 +0000, Maier, Brandon L                            Collins spake thusly:
[--SNIP--]
> > diff --git a/support/scripts/apply-patches.sh b/support/scripts/apply-
> > patches.sh
> > index 6da83f6826..39a0c050d6 100755
> > --- a/support/scripts/apply-patches.sh
> > +++ b/support/scripts/apply-patches.sh
> > @@ -146,7 +146,7 @@ function scan_patchdir {
> >                  unpackedarchivedir="$builddir/.patches-$(basename $i)-unpacked"
> >                  rm -rf "$unpackedarchivedir" 2> /dev/null
> >                  mkdir "$unpackedarchivedir"
> > -                tar -C "$unpackedarchivedir" -xaf "${path}/$i"
> > +                $(TAR) -C "$unpackedarchivedir" -xaf "${path}/$i"
> 
> Shouldn't this be `${TAR}` since it's a shell script?

Damned, one I missed... Thanks!

I tried to find a case where I could exercise that code path, but I
could not find a package with uses a tarball as a patch...

I'll respin a bit later; thanks for your eagle eyes! :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot